Daimona / BotRiconferme

src/Task/UpdateList.php

Spacing +31 added lines, -31 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -23,15 +23,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$this->actualList = $this->getActualAdmins();
 		$pageBotList = $this->getBotList();
 		$this->botList = $pageBotList->getDecodedContent();
@@ -59,7 +59,7 @@ 
 	 * @return string[][]
 	 * @phan-return array<string,string[]>
 	 */
-	protected function getActualAdmins(): array {
+	protected function getActualAdmins (): array {
 		$params = [
 			'action' => 'query',
 			'list' => 'allusers',
@@ -77,8 +77,8 @@ 
 	 * @return string[][]
 	 * @phan-return array<string,string[]>
 	 */
-	protected function extractAdmins( Generator $data ): array {
-		$ret = [];
+	protected function extractAdmins ( Generator $data ): array {
+		$ret = [ ];
 		$blacklist = $this->getOpt( 'exclude-admins' );
 		foreach ( $data as $u ) {
 			if ( in_array( $u->name, $blacklist, true ) ) {
@@ -95,16 +95,16 @@ 
 	 *
 	 * @return string[][]
 	 */
-	protected function getMissingGroups(): array {
-		$missing = [];
+	protected function getMissingGroups (): array {
+		$missing = [ ];
 		foreach ( $this->actualList as $admin => $data ) {
-			$missingProps = array_diff( $data, array_keys( $this->botList[$admin] ?? [] ) );
+			$missingProps = array_diff( $data, array_keys( $this->botList[ $admin ] ?? [ ] ) );
 			$missingGroups = array_diff( $missingProps, self::NON_GROUP_KEYS );
 
 			foreach ( $missingGroups as $group ) {
 				$ts = $this->getFlagDate( $admin, $group );
 				if ( $ts === null ) {
-					$aliases = $data['aliases'] ?? [];
+					$aliases = $data[ 'aliases' ] ?? [ ];
 					if ( $aliases ) {
 						$this->getLogger()->info( "No $group flag date for $admin, trying aliases" );
 						foreach ( $aliases as $alias ) {
@@ -115,7 +115,7 @@ 
 						}
 					}
 					if ( $ts === null ) {
-						$this->errors[] = "$group flag date unavailable for $admin";
+						$this->errors[ ] = "$group flag date unavailable for $admin";
 						continue;
 					}
 				}
@@ -132,7 +132,7 @@ 
 	 * @param string $group
 	 * @return string|null
 	 */
-	protected function getFlagDate( string $admin, string $group ): ?string {
+	protected function getFlagDate ( string $admin, string $group ): ?string {
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
 
 		$wiki = $this->getWiki();
@@ -163,7 +163,7 @@ 
 	 * @param string $group
 	 * @return string|null
 	 */
-	private function extractTimestamp( Generator $data, string $group ): ?string {
+	private function extractTimestamp ( Generator $data, string $group ): ?string {
 		$ts = null;
 		foreach ( $data as $entry ) {
 			if (
@@ -182,8 +182,8 @@ 
 	 *
 	 * @return string[][]
 	 */
-	protected function getExtraGroups(): array {
-		$extra = [];
+	protected function getExtraGroups (): array {
+		$extra = [ ];
 		foreach ( $this->botList as $name => $groups ) {
 			$groups = array_diff_key( $groups, array_fill_keys( self::NON_GROUP_KEYS, 1 ) );
 			if ( !isset( $this->actualList[ $name ] ) ) {
@@ -199,7 +199,7 @@ 
 	 * @param string[] $names
 	 * @return Generator
 	 */
-	private function getRenameEntries( array $names ): Generator {
+	private function getRenameEntries ( array $names ): Generator {
 		$titles = array_map( static function ( string $x ): string {
 			return "Utente:$x";
 		}, $names );
@@ -223,14 +223,14 @@ 
 	 * @param string[] $names
 	 * @return string[] [ old_name => new_name ]
 	 */
-	protected function getRenamedUsers( array $names ): array {
+	protected function getRenamedUsers ( array $names ): array {
 		if ( !$names ) {
-			return [];
+			return [ ];
 		}
 		$this->getLogger()->info( 'Checking rename for ' . implode( ', ', $names ) );
 
 		$data = $this->getRenameEntries( $names );
-		$ret = [];
+		$ret = [ ];
 		foreach ( $data as $entry ) {
 			// 1 month is arbitrary
 			if ( strtotime( $entry->timestamp ) > strtotime( '-1 month' ) ) {
@@ -249,18 +249,18 @@ 
 	 * @phan-param array<string,array<string,string|string[]>> $newContent
 	 * @param string[][] $removed
 	 */
-	private function handleRenames( array &$newContent, array $removed ): void {
+	private function handleRenames ( array &$newContent, array $removed ): void {
 		$renameMap = $this->getRenamedUsers( array_keys( $removed ) );
 		foreach ( $removed as $oldName => $info ) {
 			if (
 				array_key_exists( $oldName, $renameMap ) &&
-				array_key_exists( $renameMap[$oldName], $newContent )
+				array_key_exists( $renameMap[ $oldName ], $newContent )
 			) {
 				// This user was renamed! Add this name as alias, if they're still listed
 				$newName = $renameMap[ $oldName ];
 				$this->getLogger()->info( "Found rename $oldName -> $newName" );
-				$aliases = array_unique( array_merge( $newContent[ $newName ]['aliases'] ?? [], [ $oldName ] ) );
-				$newContent[ $newName ]['aliases'] = $aliases;
+				$aliases = array_unique( array_merge( $newContent[ $newName ][ 'aliases' ] ?? [ ], [ $oldName ] ) );
+				$newContent[ $newName ][ 'aliases' ] = $aliases;
 				// Transfer overrides to the new name.
 				$overrides = array_diff_key( $info, [ 'override' => 1, 'override-perm' => 1 ] );
 				$newContent[ $newName ] = array_merge( $newContent[ $newName ], $overrides );
@@ -275,12 +275,12 @@ 
 	 * @param string[][] $extra
 	 * @return string[][] Removed users
 	 */
-	private function handleExtraAndMissing(
+	private function handleExtraAndMissing (
 		array &$newContent,
 		array $missing,
 		array $extra
 	): array {
-		$removed = [];
+		$removed = [ ];
 		foreach ( $newContent as $user => $data ) {
 			if ( isset( $missing[ $user ] ) ) {
 				$newContent[ $user ] = array_merge( $data, $missing[ $user ] );
@@ -290,7 +290,7 @@ 
 				if ( array_diff_key( $newGroups, array_fill_keys( self::NON_GROUP_KEYS, 1 ) ) ) {
 					$newContent[ $user ] = $newGroups;
 				} else {
-					$removed[$user] = $data;
+					$removed[ $user ] = $data;
 					unset( $newContent[ $user ] );
 				}
 			}
@@ -307,7 +307,7 @@ 
 	 * @param string[][] $extra
 	 * @return array[]
 	 */
-	protected function getNewContent( array $missing, array $extra ): array {
+	protected function getNewContent ( array $missing, array $extra ): array {
 		$newContent = $this->botList;
 
 		$removed = $this->handleExtraAndMissing( $newContent, $missing, $extra );
@@ -326,12 +326,12 @@ 
 	 *
 	 * @param array[] &$newContent
 	 */
-	protected function removeOverrides( array &$newContent ): void {
-		$removed = [];
+	protected function removeOverrides ( array &$newContent ): void {
+		$removed = [ ];
 		foreach ( $newContent as $user => $groups ) {
 			if ( PageBotList::isOverrideExpired( $groups ) ) {
 				unset( $newContent[ $user ][ 'override' ] );
-				$removed[] = $user;
+				$removed[ ] = $user;
 			}
 		}