Passed
Push — master ( 3461b4...390609 )
by Daimona
01:42
created
includes/Logger.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 	/**
16 16
 	 * @param string $minlevel
17 17
 	 */
18
-	public function __construct( $minlevel = LogLevel::INFO ) {
18
+	public function __construct ( $minlevel = LogLevel::INFO ) {
19 19
 		$this->minLevel = $this->levelToInt( $minlevel );
20 20
 	}
21 21
 
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	 * @param string $level
26 26
 	 * @return int
27 27
 	 */
28
-	private function levelToInt( string $level ) : int {
28
+	private function levelToInt ( string $level ) : int {
29 29
 		// Order matters
30 30
 		$mapping = [
31 31
 			LogLevel::DEBUG,
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * @inheritDoc
45 45
 	 * @suppress PhanUnusedPublicMethodParameter
46 46
 	 */
47
-	public function log( $level, $message, array $context = [] ) {
47
+	public function log ( $level, $message, array $context = [ ] ) {
48 48
 		if ( $this->levelToInt( $level ) >= $this->minLevel ) {
49 49
 			printf( "%s [%s] - %s\n", date( 'd M H:i:s' ), $level, $message );
50 50
 		}
Please login to merge, or discard this patch.
includes/Message.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 	/**
27 27
 	 * @param string $key
28 28
 	 */
29
-	public function __construct( string $key ) {
29
+	public function __construct ( string $key ) {
30 30
 		$this->value = Config::getInstance()->getWikiMessage( $key );
31 31
 	}
32 32
 
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 * @param array $args
35 35
 	 * @return self
36 36
 	 */
37
-	public function params( array $args ) : self {
37
+	public function params ( array $args ) : self {
38 38
 		$this->value = strtr( $this->value, $args );
39 39
 		return $this;
40 40
 	}
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 	/**
43 43
 	 * @return string
44 44
 	 */
45
-	public function text() : string {
45
+	public function text () : string {
46 46
 		$this->parsePlurals();
47 47
 		return $this->value;
48 48
 	}
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 	/**
51 51
 	 * Replace {{$plur|<amount>|sing|plur}}
52 52
 	 */
53
-	protected function parsePlurals() {
53
+	protected function parsePlurals () {
54 54
 		$reg = '!\{\{\$plur\|(?P<amount>\d+)\|(?P<sing>[^}|]+)\|(?P<plur>[^|}]+)}}!';
55 55
 
56 56
 		if ( preg_match( $reg, $this->value ) === 0 ) {
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 		$this->value = preg_replace_callback(
60 60
 			$reg,
61 61
 			function ( $matches ) {
62
-				return intval( $matches['amount'] ) > 1 ? trim( $matches['plur'] ) : trim( $matches['sing'] );
62
+				return intval( $matches[ 'amount' ] ) > 1 ? trim( $matches[ 'plur' ] ) : trim( $matches[ 'sing' ] );
63 63
 			},
64 64
 			$this->value
65 65
 		);
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	 * @suppress PhanUnreferencedPublicMethod
74 74
 	 * @fixme Is this necessary?
75 75
 	 */
76
-	public static function getTimeWithArticle( int $timestamp ) : string {
76
+	public static function getTimeWithArticle ( int $timestamp ) : string {
77 77
 		$oldLoc = setlocale( LC_TIME, 'it_IT', 'Italian_Italy', 'Italian' );
78 78
 		$timeString = strftime( '%e %B alle %R', $timestamp );
79 79
 		// Remove the left space if day has a single digit
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 	 * @param string $timeString Full format, e.g. "15 aprile 2019 18:27"
91 91
 	 * @return int
92 92
 	 */
93
-	public static function getTimestampFromLocalTime( string $timeString ) : int {
93
+	public static function getTimestampFromLocalTime ( string $timeString ) : int {
94 94
 		$englishTime = str_ireplace(
95 95
 			array_values( self::MONTHS ),
96 96
 			array_keys( self::MONTHS ),
@@ -108,12 +108,12 @@  discard block
 block discarded – undo
108 108
 	 * @param string $emptyText
109 109
 	 * @return string
110 110
 	 */
111
-	public static function commaList( array $data, string $emptyText = 'nessuno' ) : string {
111
+	public static function commaList ( array $data, string $emptyText = 'nessuno' ) : string {
112 112
 		if ( count( $data ) > 1 ) {
113 113
 			$last = array_pop( $data );
114 114
 			$ret = implode( ', ', $data ) . " e $last";
115 115
 		} elseif ( $data ) {
116
-			$ret = (string)$data[0];
116
+			$ret = (string)$data[ 0 ];
117 117
 		} else {
118 118
 			$ret = $emptyText;
119 119
 		}
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 		return $ret;
122 122
 	}
123 123
 
124
-	public function __toString() {
124
+	public function __toString () {
125 125
 		return $this->text();
126 126
 	}
127 127
 }
Please login to merge, or discard this patch.
includes/Request/CurlRequest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Request;
4 4
 
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 	 * @inheritDoc
13 13
 	 * @throws APIRequestException
14 14
 	 */
15
-	protected function reallyMakeRequest( string $params ) : string {
15
+	protected function reallyMakeRequest ( string $params ) : string {
16 16
 		$curl = curl_init();
17 17
 		if ( $curl === false ) {
18 18
 			throw new APIRequestException( 'Cannot open cURL handler.' );
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
55 55
 	 * @internal Only used as CB for cURL (CURLOPT_HEADERFUNCTION)
56 56
 	 * @suppress PhanUnreferencedPublicMethod,PhanUnusedPublicNoOverrideMethodParameter
57 57
 	 */
58
-	public function headersHandler( $ch, string $header ) : int {
58
+	public function headersHandler ( $ch, string $header ) : int {
59 59
 		$bits = explode( ':', $header, 2 );
60
-		if ( trim( $bits[0] ) === 'Set-Cookie' ) {
61
-			$this->newCookies[] = $bits[1];
60
+		if ( trim( $bits[ 0 ] ) === 'Set-Cookie' ) {
61
+			$this->newCookies[ ] = $bits[ 1 ];
62 62
 		}
63 63
 
64 64
 		return strlen( $header );
Please login to merge, or discard this patch.
includes/TaskResult.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	 * @param int $status One of the Task::STATUS_* constants
22 22
 	 * @param string[] $errors
23 23
 	 */
24
-	public function __construct( int $status, array $errors = [] ) {
24
+	public function __construct ( int $status, array $errors = [ ] ) {
25 25
 		$this->status = $status;
26 26
 		$this->errors = $errors;
27 27
 	}
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 	/**
30 30
 	 * @return int
31 31
 	 */
32
-	public function getStatus() : int {
32
+	public function getStatus () : int {
33 33
 		return $this->status;
34 34
 	}
35 35
 
@@ -37,14 +37,14 @@  discard block
 block discarded – undo
37 37
 	 * @return string[]
38 38
 	 * @suppress PhanUnreferencedPublicMethod
39 39
 	 */
40
-	public function getErrors() {
40
+	public function getErrors () {
41 41
 		return $this->errors;
42 42
 	}
43 43
 
44 44
 	/**
45 45
 	 * @param TaskResult $that
46 46
 	 */
47
-	public function merge( TaskResult $that ) {
47
+	public function merge ( TaskResult $that ) {
48 48
 		$this->status |= $that->status;
49 49
 		$this->errors = array_merge( $this->errors, $that->errors );
50 50
 	}
@@ -52,15 +52,15 @@  discard block
 block discarded – undo
52 52
 	/**
53 53
 	 * @return string
54 54
 	 */
55
-	public function __toString() {
55
+	public function __toString () {
56 56
 		if ( $this->isOK() ) {
57 57
 			$stat = 'OK';
58 58
 			$errs = "\tNo errors.";
59 59
 		} else {
60 60
 			$stat = 'ERROR';
61
-			$formattedErrs = [];
61
+			$formattedErrs = [ ];
62 62
 			foreach ( $this->errors as $err ) {
63
-				$formattedErrs[] = "\t - $err";
63
+				$formattedErrs[ ] = "\t - $err";
64 64
 			}
65 65
 			$errs = implode( "\n", $formattedErrs );
66 66
 		}
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	 *
73 73
 	 * @return bool
74 74
 	 */
75
-	public function isOK() : bool {
75
+	public function isOK () : bool {
76 76
 		return ( $this->status | self::STATUS_GOOD ) === self::STATUS_GOOD;
77 77
 	}
78 78
 }
Please login to merge, or discard this patch.
includes/Task/Subtask/OpenUpdates.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 	/**
14 14
 	 * @inheritDoc
15 15
 	 */
16
-	public function runInternal() : int {
16
+	public function runInternal () : int {
17 17
 		$pages = $this->getDataProvider()->getCreatedPages();
18 18
 
19 19
 		if ( !$pages ) {
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	 *
36 36
 	 * @param PageRiconferma[] $pages
37 37
 	 */
38
-	protected function addToMainPage( array $pages ) {
38
+	protected function addToMainPage ( array $pages ) {
39 39
 		$this->getLogger()->info(
40 40
 			'Adding the following to main: ' . implode( ', ', $pages )
41 41
 		);
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	 *
69 69
 	 * @param PageRiconferma[] $pages
70 70
 	 */
71
-	protected function addToVotazioni( array $pages ) {
71
+	protected function addToVotazioni ( array $pages ) {
72 72
 		$this->getLogger()->info(
73 73
 			'Adding the following to votes: ' . implode( ', ', $pages )
74 74
 		);
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 	 * @param int $amount
106 106
 	 * @throws TaskException
107 107
 	 */
108
-	protected function addToNews( int $amount ) {
108
+	protected function addToNews ( int $amount ) {
109 109
 		$this->getLogger()->info( "Increasing the news counter by $amount" );
110 110
 		$newsPage = $this->getPage( $this->getOpt( 'news-page-title' ) );
111 111
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 
119 119
 		$matches = $newsPage->getMatch( $reg );
120 120
 
121
-		$newNum = (int)$matches[2] + $amount;
121
+		$newNum = (int)$matches[ 2 ] + $amount;
122 122
 		$newContent = preg_replace( $reg, '${1}' . $newNum, $content );
123 123
 
124 124
 		$summary = $this->msg( 'news-page-summary' )
Please login to merge, or discard this patch.