Passed
Push — master ( 4e642f...9effa9 )
by Daimona
01:57
created
src/Request/NativeRequest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Request;
4 4
 
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
 	/**
10 10
 	 * @inheritDoc
11 11
 	 */
12
-	protected function reallyMakeRequest( string $params ): string {
12
+	protected function reallyMakeRequest ( string $params ): string {
13 13
 		$context = [
14 14
 			'http' => [
15 15
 				'method' => $this->method,
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 		];
19 19
 		$url = $this->url;
20 20
 		if ( $this->method === self::METHOD_POST ) {
21
-			$context['http']['content'] = $params;
21
+			$context[ 'http' ][ 'content' ] = $params;
22 22
 		} else {
23 23
 			$url = "$url?$params";
24 24
 		}
Please login to merge, or discard this patch.
src/Request/RequestBase.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Request;
4 4
 
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 	/** @var string */
42 42
 	protected $method = self::METHOD_GET;
43 43
 	/** @var string[] */
44
-	protected $newCookies = [];
44
+	protected $newCookies = [ ];
45 45
 	/** @var callable|null */
46 46
 	private $cookiesHandlerCallback;
47 47
 
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 	 * @param string $domain
58 58
 	 * @param callable $cookiesHandlerCallback
59 59
 	 */
60
-	public function __construct(
60
+	public function __construct (
61 61
 		LoggerInterface $logger,
62 62
 		array $params,
63 63
 		string $domain,
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 	 *
75 75
 	 * @return self For chaining
76 76
 	 */
77
-	public function setPost(): self {
77
+	public function setPost (): self {
78 78
 		$this->method = self::METHOD_POST;
79 79
 		return $this;
80 80
 	}
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 	 * @param string[] $cookies
84 84
 	 * @return self For chaining
85 85
 	 */
86
-	public function setCookies( array $cookies ): self {
86
+	public function setCookies ( array $cookies ): self {
87 87
 		$this->cookiesToSet = $cookies;
88 88
 		return $this;
89 89
 	}
@@ -92,12 +92,12 @@  discard block
 block discarded – undo
92 92
 	 * Execute a query request
93 93
 	 * @return Generator
94 94
 	 */
95
-	public function executeAsQuery(): Generator {
96
-		if ( ( $this->params['action'] ?? false ) !== 'query' ) {
95
+	public function executeAsQuery (): Generator {
96
+		if ( ( $this->params[ 'action' ] ?? false ) !== 'query' ) {
97 97
 			throw new BadMethodCallException( 'Not an ApiQuery!' );
98 98
 		}
99 99
 		// TODO Is this always correct?
100
-		$key = $this->params['list'] ?? 'pages';
100
+		$key = $this->params[ 'list' ] ?? 'pages';
101 101
 		$curParams = $this->params;
102 102
 		$lim = $this->parseLimit();
103 103
 		do {
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	 * Execute a request that doesn't need any continuation.
127 127
 	 * @return stdClass
128 128
 	 */
129
-	public function executeSingle(): stdClass {
129
+	public function executeSingle (): stdClass {
130 130
 		$curParams = $this->params;
131 131
 		$res = $this->makeRequestInternal( $curParams );
132 132
 		$this->handleErrorAndWarnings( $res );
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 	/**
137 137
 	 * @return int
138 138
 	 */
139
-	private function parseLimit(): int {
139
+	private function parseLimit (): int {
140 140
 		foreach ( $this->params as $name => $val ) {
141 141
 			if ( substr( $name, -strlen( 'limit' ) ) === 'limit' ) {
142 142
 				return $val === 'max' ? -1 : (int)$val;
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 	 * @param string $resKey
154 154
 	 * @return int|null
155 155
 	 */
156
-	private function countQueryResults( stdClass $res, string $resKey ): ?int {
156
+	private function countQueryResults ( stdClass $res, string $resKey ): ?int {
157 157
 		if ( !isset( $res->query->$resKey ) ) {
158 158
 			return null;
159 159
 		}
@@ -181,9 +181,9 @@  discard block
 block discarded – undo
181 181
 	 * @phan-param array<int|string|bool> $params
182 182
 	 * @return stdClass
183 183
 	 */
184
-	private function makeRequestInternal( array $params ): stdClass {
184
+	private function makeRequestInternal ( array $params ): stdClass {
185 185
 		if ( $this->method === self::METHOD_POST ) {
186
-			$params['maxlag'] = self::MAXLAG;
186
+			$params[ 'maxlag' ] = self::MAXLAG;
187 187
 		}
188 188
 		$query = http_build_query( $params );
189 189
 
@@ -203,13 +203,13 @@  discard block
 block discarded – undo
203 203
 	 *
204 204
 	 * @param string $rawHeader
205 205
 	 */
206
-	protected function handleResponseHeader( string $rawHeader ): void {
206
+	protected function handleResponseHeader ( string $rawHeader ): void {
207 207
 		[ $headerName, $headerValue ] = explode( ':', $rawHeader, 2 );
208 208
 		if ( strtolower( trim( $headerName ) ) === 'set-cookie' ) {
209 209
 			// TODO Maybe use a cookie file?
210
-			$cookieKeyVal = explode( ';', $headerValue )[0];
210
+			$cookieKeyVal = explode( ';', $headerValue )[ 0 ];
211 211
 			[ $name, $value ] = explode( '=', $cookieKeyVal );
212
-			$this->newCookies[$name] = $value;
212
+			$this->newCookies[ $name ] = $value;
213 213
 		}
214 214
 	}
215 215
 
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 	 * @param string $params
220 220
 	 * @return string
221 221
 	 */
222
-	abstract protected function reallyMakeRequest( string $params ): string;
222
+	abstract protected function reallyMakeRequest ( string $params ): string;
223 223
 
224 224
 	/**
225 225
 	 * Get a specific exception class depending on the error code
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 	 * @param stdClass $res
228 228
 	 * @return APIRequestException
229 229
 	 */
230
-	private function getException( stdClass $res ): APIRequestException {
230
+	private function getException ( stdClass $res ): APIRequestException {
231 231
 		switch ( $res->error->code ) {
232 232
 			case 'missingtitle':
233 233
 				$ex = new MissingPageException;
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 	 * @param stdClass $res
254 254
 	 * @throws APIRequestException
255 255
 	 */
256
-	protected function handleErrorAndWarnings( stdClass $res ): void {
256
+	protected function handleErrorAndWarnings ( stdClass $res ): void {
257 257
 		if ( isset( $res->error ) ) {
258 258
 			throw $this->getException( $res );
259 259
 		}
@@ -269,14 +269,14 @@  discard block
 block discarded – undo
269 269
 	 *
270 270
 	 * @return string[]
271 271
 	 */
272
-	protected function getHeaders(): array {
272
+	protected function getHeaders (): array {
273 273
 		$ret = self::HEADERS;
274 274
 		if ( $this->cookiesToSet ) {
275
-			$cookies = [];
275
+			$cookies = [ ];
276 276
 			foreach ( $this->cookiesToSet as $cname => $cval ) {
277
-				$cookies[] = trim( "$cname=$cval" );
277
+				$cookies[ ] = trim( "$cname=$cval" );
278 278
 			}
279
-			$ret[] = 'Cookie: ' . implode( '; ', $cookies );
279
+			$ret[ ] = 'Cookie: ' . implode( '; ', $cookies );
280 280
 		}
281 281
 		return $ret;
282 282
 	}
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
 	 * @param string[] $headers
288 288
 	 * @return string
289 289
 	 */
290
-	protected function buildHeadersString( array $headers ): string {
290
+	protected function buildHeadersString ( array $headers ): string {
291 291
 		$ret = '';
292 292
 		foreach ( $headers as $header ) {
293 293
 			$ret .= "$header\r\n";
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
 	 * @param string $actualParams
300 300
 	 * @return string
301 301
 	 */
302
-	protected function getDebugURL( string $actualParams ): string {
302
+	protected function getDebugURL ( string $actualParams ): string {
303 303
 		return strpos( $this->url, 'login' ) !== false
304 304
 			? '[Login request]'
305 305
 			: "{$this->url}?$actualParams";
Please login to merge, or discard this patch.
src/Request/CurlRequest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Request;
4 4
 
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 	 * @inheritDoc
14 14
 	 * @throws APIRequestException
15 15
 	 */
16
-	protected function reallyMakeRequest( string $params ): string {
16
+	protected function reallyMakeRequest ( string $params ): string {
17 17
 		$curl = curl_init();
18 18
 		if ( $curl === false ) {
19 19
 			throw new APIRequestException( 'Cannot open cURL handler.' );
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 	 * @internal Only used as CB for cURL (CURLOPT_HEADERFUNCTION)
60 60
 	 * @suppress PhanUnreferencedPublicMethod,PhanUnusedPublicNoOverrideMethodParameter
61 61
 	 */
62
-	public function headersHandler( $ch, string $header ): int {
62
+	public function headersHandler ( $ch, string $header ): int {
63 63
 		$this->handleResponseHeader( $header );
64 64
 		return strlen( $header );
65 65
 	}
Please login to merge, or discard this patch.