Daimona / BotRiconferme

includes/Task/Subtask/CreatePages.php

Spacing +12 added lines, -12 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$users = $this->getDataProvider()->getUsersToProcess();
 
 		if ( !$users ) {
@@ -34,7 +34,7 @@ 
 	 *
 	 * @param User $user
 	 */
-	protected function processUser( User $user ) : void {
+	protected function processUser ( User $user ) : void {
 		$this->getLogger()->info( "Processing user $user" );
 		try {
 			$num = $this->getLastPageNum( $user ) + 1;
@@ -69,14 +69,14 @@ 
 	 * @return int
 	 * @throws TaskException
 	 */
-	protected function getLastPageNum( User $user ) : int {
+	protected function getLastPageNum ( User $user ) : int {
 		$this->getLogger()->info( "Retrieving previous pages for $user" );
 
-		$unprefixedTitle = explode( ':', $this->getOpt( 'main-page-title' ), 2 )[1];
+		$unprefixedTitle = explode( ':', $this->getOpt( 'main-page-title' ), 2 )[ 1 ];
 
 		$prefixes = [ "$unprefixedTitle/$user/" ];
 		foreach ( $user->getAliases() as $alias ) {
-			$prefixes[] = "$unprefixedTitle/$alias/";
+			$prefixes[ ] = "$unprefixedTitle/$alias/";
 		}
 
 		$params = [
@@ -110,14 +110,14 @@ 
 	 * @param string $title
 	 * @param User $user
 	 */
-	protected function createPage( string $title, User $user ) : void {
+	protected function createPage ( string $title, User $user ) : void {
 		$this->getLogger()->info( "Creating page $title" );
 		$groups = $user->getGroupsWithDates();
 		$textParams = [
 			'$user' => $user->getName(),
-			'$date' => $groups['sysop'],
-			'$burocrate' => $groups['bureaucrat'] ?? '',
-			'$checkuser' => $groups['checkuser'] ?? ''
+			'$date' => $groups[ 'sysop' ],
+			'$burocrate' => $groups[ 'bureaucrat' ] ?? '',
+			'$checkuser' => $groups[ 'checkuser' ] ?? ''
 		];
 
 		$params = [
@@ -135,7 +135,7 @@ 
 	 * @param Page $basePage
 	 * @param string $newText
 	 */
-	protected function createBasePage( Page $basePage, string $newText ) : void {
+	protected function createBasePage ( Page $basePage, string $newText ) : void {
 		$this->getLogger()->info( "Creating base page $basePage" );
 
 		$params = [
@@ -151,7 +151,7 @@ 
 	 * @param Page $basePage
 	 * @param string $newText
 	 */
-	protected function updateBasePage( Page $basePage, string $newText ) : void {
+	protected function updateBasePage ( Page $basePage, string $newText ) : void {
 		$this->getLogger()->info( "Updating base page $basePage" );
 
 		$params = [

includes/Request/RequestBase.php

Spacing +23 added lines, -23 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Request;
 
@@ -32,7 +32,7 @@ 
 	/** @var string */
 	protected $method = self::METHOD_GET;
 	/** @var string[] */
-	protected $newCookies = [];
+	protected $newCookies = [ ];
 
 	/**
 	 * @private Use RequestFactory
@@ -40,7 +40,7 @@ 
 	 * @param array $params
 	 * @param string $domain
 	 */
-	public function __construct( array $params, string $domain ) {
+	public function __construct ( array $params, string $domain ) {
 		$this->params = [ 'format' => 'json' ] + $params;
 		$this->url = $domain;
 	}
@@ -50,7 +50,7 @@ 
 	 *
 	 * @return self For chaining
 	 */
-	public function setPost() : self {
+	public function setPost () : self {
 		$this->method = self::METHOD_POST;
 		return $this;
 	}
@@ -62,15 +62,15 @@ 
 	 * @todo Return an iterable object which automatically continues the query only if the last
 	 *   entry available is reached, instead of requesting max results.
 	 */
-	public function execute() : \stdClass {
+	public function execute () : \stdClass {
 		$curParams = $this->params;
 		$lim = $this->parseLimit();
-		$sets = [];
+		$sets = [ ];
 		do {
 			$res = $this->makeRequestInternal( $curParams );
 
 			$this->handleErrorAndWarnings( $res );
-			$sets[] = $res;
+			$sets[ ] = $res;
 
 			// Assume that we have finished
 			$finished = true;
@@ -95,7 +95,7 @@ 
 	 * FIXME Should be revamped together with countResults
 	 * @return int
 	 */
-	private function parseLimit() : int {
+	private function parseLimit () : int {
 		foreach ( $this->params as $name => $val ) {
 			if ( substr( $name, -strlen( 'limit' ) ) === 'limit' ) {
 				return $val === 'max' ? -1 : (int)$val;
@@ -113,7 +113,7 @@ 
 	 * @param \stdClass $res
 	 * @return int|null
 	 */
-	private function countResults( \stdClass $res ) : ?int {
+	private function countResults ( \stdClass $res ) : ?int {
 		if ( isset( $res->query->pages ) && count( $res->query->pages ) === 1 ) {
 			$pages = $res->query->pages;
 			return count( reset( $pages )->revisions );
@@ -127,9 +127,9 @@ 
 	 * @param array $params
 	 * @return \stdClass
 	 */
-	private function makeRequestInternal( array $params ) : \stdClass {
+	private function makeRequestInternal ( array $params ) : \stdClass {
 		if ( $this->method === self::METHOD_POST ) {
-			$params['maxlag'] = self::MAXLAG;
+			$params[ 'maxlag' ] = self::MAXLAG;
 		}
 		$query = http_build_query( $params );
 
@@ -145,17 +145,17 @@ 
 	 * @param string $params
 	 * @return string
 	 */
-	abstract protected function reallyMakeRequest( string $params ) : string;
+	abstract protected function reallyMakeRequest ( string $params ) : string;
 
 	/**
 	 * After a request, set cookies for the next ones
 	 *
 	 * @param array $cookies
 	 */
-	protected function setCookies( array $cookies ) : void {
+	protected function setCookies ( array $cookies ) : void {
 		foreach ( $cookies as $cookie ) {
 			$bits = explode( ';', $cookie );
-			[ $name, $value ] = explode( '=', $bits[0] );
+			[ $name, $value ] = explode( '=', $bits[ 0 ] );
 			self::$cookiesToSet[ $name ] = $value;
 		}
 	}
@@ -166,7 +166,7 @@ 
 	 * @param \stdClass $res
 	 * @return APIRequestException
 	 */
-	private function getException( \stdClass $res ) : APIRequestException {
+	private function getException ( \stdClass $res ) : APIRequestException {
 		switch ( $res->error->code ) {
 			case 'missingtitle':
 				$ex = new MissingPageException;
@@ -189,7 +189,7 @@ 
 	 * @param \stdClass $res
 	 * @throws APIRequestException
 	 */
-	protected function handleErrorAndWarnings( \stdClass $res ) : void {
+	protected function handleErrorAndWarnings ( \stdClass $res ) : void {
 		if ( isset( $res->error ) ) {
 			throw $this->getException( $res );
 		} elseif ( isset( $res->warnings ) ) {
@@ -205,7 +205,7 @@ 
 	 * @param \stdClass[] $sets
 	 * @return \stdClass
 	 */
-	private function mergeSets( array $sets ) : \stdClass {
+	private function mergeSets ( array $sets ) : \stdClass {
 		// Use the first set as template
 		$ret = array_shift( $sets );
 
@@ -222,7 +222,7 @@ 
 	 * @param array|\stdClass $second
 	 * @return array|\stdClass array
 	 */
-	private function recursiveMerge( $first, $second ) {
+	private function recursiveMerge ( $first, $second ) {
 		$ret = $first;
 		if ( is_array( $second ) ) {
 			$ret = is_array( $first ) ? array_merge_recursive( $first, $second ) : $second;
@@ -240,14 +240,14 @@ 
 	 *
 	 * @return array
 	 */
-	protected function getHeaders() :array {
+	protected function getHeaders () :array {
 		$ret = self::HEADERS;
 		if ( self::$cookiesToSet ) {
-			$cookies = [];
+			$cookies = [ ];
 			foreach ( self::$cookiesToSet as $cname => $cval ) {
-				$cookies[] = trim( "$cname=$cval" );
+				$cookies[ ] = trim( "$cname=$cval" );
 			}
-			$ret[] = 'Cookie: ' . implode( '; ', $cookies );
+			$ret[ ] = 'Cookie: ' . implode( '; ', $cookies );
 		}
 		return $ret;
 	}
@@ -258,7 +258,7 @@ 
 	 * @param array $headers
 	 * @return string
 	 */
-	protected function buildHeadersString( array $headers ) : string {
+	protected function buildHeadersString ( array $headers ) : string {
 		$ret = '';
 		foreach ( $headers as $header ) {
 			$ret .= "$header\r\n";

includes/Wiki/Wiki.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki;
 
@@ -34,7 +34,7 @@ 
 	 * @param LoggerInterface $logger
 	 * @param RequestFactory $requestFactory
 	 */
-	public function __construct(
+	public function __construct (
 		LoginInfo $li,
 		LoggerInterface $logger,
 		RequestFactory $requestFactory
@@ -47,28 +47,28 @@ 
 	/**
 	 * @return LoginInfo
 	 */
-	public function getLoginInfo() : LoginInfo {
+	public function getLoginInfo () : LoginInfo {
 		return $this->loginInfo;
 	}
 
 	/**
 	 * @return RequestFactory
 	 */
-	public function getRequestFactory() : RequestFactory {
+	public function getRequestFactory () : RequestFactory {
 		return $this->requestFactory;
 	}
 
 	/**
 	 * @param string $ident
 	 */
-	public function setLocalUserIdentifier( string $ident ) : void {
+	public function setLocalUserIdentifier ( string $ident ) : void {
 		$this->localUserIdentifier = $ident;
 	}
 
 	/**
 	 * @return string
 	 */
-	public function getLocalUserIdentifier() : string {
+	public function getLocalUserIdentifier () : string {
 		return $this->localUserIdentifier;
 	}
 
@@ -81,7 +81,7 @@ 
 	 * @throws MissingPageException
 	 * @throws MissingSectionException
 	 */
-	public function getPageContent( string $title, int $section = null ) : string {
+	public function getPageContent ( string $title, int $section = null ) : string {
 		$msg = "Retrieving content of $title" . ( $section !== null ? ", section $section" : '' );
 		$this->logger->info( $msg );
 		$params = [
@@ -93,7 +93,7 @@ 
 		];
 
 		if ( $section !== null ) {
-			$params['rvsection'] = $section;
+			$params[ 'rvsection' ] = $section;
 		}
 
 		$req = $this->buildRequest( $params );
@@ -103,7 +103,7 @@ 
 			throw new MissingPageException( $title );
 		}
 
-		$mainSlot = $page->revisions[0]->slots->main;
+		$mainSlot = $page->revisions[ 0 ]->slots->main;
 
 		if ( $section !== null && isset( $mainSlot->nosuchsection ) ) {
 			throw new MissingSectionException( $title, $section );
@@ -117,7 +117,7 @@ 
 	 * @param array $params
 	 * @throws EditException
 	 */
-	public function editPage( array $params ) : void {
+	public function editPage ( array $params ) : void {
 		$this->login();
 
 		$params = [
@@ -126,7 +126,7 @@ 
 		] + $params;
 
 		if ( BOT_EDITS === true ) {
-			$params['bot'] = 1;
+			$params[ 'bot' ] = 1;
 		}
 
 		$res = $this->buildRequest( $params )->setPost()->execute();
@@ -144,7 +144,7 @@ 
 	 * Login wrapper. Checks if we're already logged in and clears tokens cache
 	 * @throws LoginException
 	 */
-	public function login() : void {
+	public function login () : void {
 		if ( $this->loginInfo === null ) {
 			throw new CannotLoginException( 'Missing login data' );
 		}
@@ -174,7 +174,7 @@ 
 
 		self::$loggedIn = true;
 		// Clear tokens cache
-		$this->tokens = [];
+		$this->tokens = [ ];
 		$this->logger->info( 'Login succeeded' );
 	}
 
@@ -184,7 +184,7 @@ 
 	 * @param string $type
 	 * @return string
 	 */
-	public function getToken( string $type ) : string {
+	public function getToken ( string $type ) : string {
 		if ( !isset( $this->tokens[ $type ] ) ) {
 			$params = [
 				'action' => 'query',
@@ -207,7 +207,7 @@ 
 	 * @param string $title
 	 * @return int
 	 */
-	public function getPageCreationTS( string $title ) : int {
+	public function getPageCreationTS ( string $title ) : int {
 		$params = [
 			'action' => 'query',
 			'prop' => 'revisions',
@@ -220,7 +220,7 @@ 
 
 		$res = $this->buildRequest( $params )->execute();
 		$data = $res->query->pages;
-		return strtotime( reset( $data )->revisions[0]->timestamp );
+		return strtotime( reset( $data )->revisions[ 0 ]->timestamp );
 	}
 
 	/**
@@ -229,7 +229,7 @@ 
 	 * @param string $title
 	 * @param string $reason
 	 */
-	public function protectPage( string $title, string $reason ) : void {
+	public function protectPage ( string $title, string $reason ) : void {
 		$this->logger->info( "Protecting page $title" );
 		$this->login();
 
@@ -250,7 +250,7 @@ 
 	 * @param array $params
 	 * @return RequestBase
 	 */
-	private function buildRequest( array $params ) : RequestBase {
+	private function buildRequest ( array $params ) : RequestBase {
 		return $this->requestFactory->newFromParams( $params );
 	}
 }