Passed
Push — master ( adc4b8...42aaff )
by Daimona
01:39
created
includes/TaskDataProvider.php 1 patch
Spacing   +18 added lines, -20 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -13,14 +13,14 @@  discard block
 block discarded – undo
13 13
 	/** @var array[] */
14 14
 	private $allUsers;
15 15
 	/** @var PageRiconferma[] */
16
-	private $createdPages = [];
16
+	private $createdPages = [ ];
17 17
 
18 18
 	/**
19 19
 	 * Get the full content of the JSON users list
20 20
 	 *
21 21
 	 * @return array[]
22 22
 	 */
23
-	public function getUsersList() : array {
23
+	public function getUsersList () : array {
24 24
 		if ( $this->allUsers === null ) {
25 25
 			$this->getLogger()->debug( 'Retrieving users list' );
26 26
 			$content = $this->getController()->getPageContent( $this->getConfig()->get( 'list-title' ) );
@@ -35,9 +35,9 @@  discard block
 block discarded – undo
35 35
 	 *
36 36
 	 * @return array[]
37 37
 	 */
38
-	public function getUsersToProcess() : array {
38
+	public function getUsersToProcess () : array {
39 39
 		if ( $this->processUsers === null ) {
40
-			$this->processUsers = [];
40
+			$this->processUsers = [ ];
41 41
 			foreach ( $this->getUsersList() as $user => $groups ) {
42 42
 				$timestamp = $this->getValidTimestamp( $groups );
43 43
 
@@ -59,13 +59,11 @@  discard block
 block discarded – undo
59 59
 	 * @param array $groups
60 60
 	 * @return int
61 61
 	 */
62
-	private function getValidTimestamp( array $groups ) : int {
62
+	private function getValidTimestamp ( array $groups ) : int {
63 63
 		$checkuser = isset( $groups[ 'checkuser' ] ) ?
64
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() :
65
-			0;
64
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() : 0;
66 65
 		$bureaucrat = isset( $groups[ 'bureaucrat' ] ) ?
67
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() :
68
-			0;
66
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() : 0;
69 67
 
70 68
 		$timestamp = max( $bureaucrat, $checkuser );
71 69
 		if ( $timestamp === 0 ) {
@@ -79,7 +77,7 @@  discard block
 block discarded – undo
79 77
 	 *
80 78
 	 * @return PageRiconferma[]
81 79
 	 */
82
-	public function getOpenPages() : array {
80
+	public function getOpenPages () : array {
83 81
 		static $list = null;
84 82
 		if ( $list === null ) {
85 83
 			$baseTitle = $this->getConfig()->get( 'ric-main-page' );
@@ -93,10 +91,10 @@  discard block
 block discarded – undo
93 91
 
94 92
 			$res = RequestBase::newFromParams( $params )->execute();
95 93
 			$pages = $res->query->pages;
96
-			$list = [];
94
+			$list = [ ];
97 95
 			foreach ( reset( $pages )->templates as $page ) {
98 96
 				if ( preg_match( "!$baseTitle\/[^\/]+\/\d!", $page->title ) !== false ) {
99
-					$list[] = new PageRiconferma( $page->title );
97
+					$list[ ] = new PageRiconferma( $page->title );
100 98
 				}
101 99
 			}
102 100
 		}
@@ -109,14 +107,14 @@  discard block
 block discarded – undo
109 107
 	 *
110 108
 	 * @return PageRiconferma[]
111 109
 	 */
112
-	public function getPagesToClose() : array {
110
+	public function getPagesToClose () : array {
113 111
 		static $list = null;
114 112
 		if ( $list === null ) {
115 113
 			$allPages = $this->getOpenPages();
116
-			$list = [];
114
+			$list = [ ];
117 115
 			foreach ( $allPages as $page ) {
118 116
 				if ( time() > $page->getEndTimestamp() ) {
119
-					$list[] = $page;
117
+					$list[ ] = $page;
120 118
 				}
121 119
 			}
122 120
 		}
@@ -128,21 +126,21 @@  discard block
 block discarded – undo
128 126
 	 *
129 127
 	 * @param string $name
130 128
 	 */
131
-	public function removeUser( string $name ) {
129
+	public function removeUser ( string $name ) {
132 130
 		unset( $this->processUsers[ $name ] );
133 131
 	}
134 132
 
135 133
 	/**
136 134
 	 * @return PageRiconferma[]
137 135
 	 */
138
-	public function getCreatedPages() : array {
136
+	public function getCreatedPages () : array {
139 137
 		return $this->createdPages;
140 138
 	}
141 139
 
142 140
 	/**
143 141
 	 * @param PageRiconferma $page
144 142
 	 */
145
-	public function addCreatedPages( PageRiconferma $page ) {
146
-		$this->createdPages[] = $page;
143
+	public function addCreatedPages ( PageRiconferma $page ) {
144
+		$this->createdPages[ ] = $page;
147 145
 	}
148 146
 }
Please login to merge, or discard this patch.
includes/Task/Subtask/ClosePages.php 1 patch
Spacing   +50 added lines, -51 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * @inheritDoc
16 16
 	 */
17
-	public function run() : TaskResult {
17
+	public function run () : TaskResult {
18 18
 		$this->getLogger()->info( 'Starting task ClosePages' );
19 19
 
20 20
 		$pages = $this->getDataProvider()->getPagesToClose();
@@ -52,11 +52,11 @@  discard block
 block discarded – undo
52 52
 	 * @param PageRiconferma[] $pages
53 53
 	 * @return PageRiconferma[]
54 54
 	 */
55
-	private function getFailures( array $pages ) : array {
56
-		$ret = [];
55
+	private function getFailures ( array $pages ) : array {
56
+		$ret = [ ];
57 57
 		foreach ( $pages as $page ) {
58 58
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
59
-				$ret[] = $page;
59
+				$ret[ ] = $page;
60 60
 			}
61 61
 		}
62 62
 		return $ret;
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 	/**
66 66
 	 * @param PageRiconferma $page
67 67
 	 */
68
-	protected function addVoteCloseText( PageRiconferma $page ) {
68
+	protected function addVoteCloseText ( PageRiconferma $page ) {
69 69
 		$content = $page->getContent();
70 70
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!';
71 71
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -83,13 +83,13 @@  discard block
 block discarded – undo
83 83
 	 * @param PageRiconferma[] $pages
84 84
 	 * @see UpdatesAround::addToMainPage()
85 85
 	 */
86
-	protected function removeFromMainPage( array $pages ) {
86
+	protected function removeFromMainPage ( array $pages ) {
87 87
 		$this->getLogger()->info(
88 88
 			'Removing from main: ' . implode( ', ', array_map( 'strval', $pages ) )
89 89
 		);
90 90
 
91 91
 		$mainPage = new Page( $this->getConfig()->get( 'ric-main-page' ) );
92
-		$translations = [];
92
+		$translations = [ ];
93 93
 		foreach ( $pages as $page ) {
94 94
 			$translations[ '{{' . $page->getTitle() . '}}' ] = '';
95 95
 		}
@@ -107,17 +107,17 @@  discard block
 block discarded – undo
107 107
 	 *
108 108
 	 * @param PageRiconferma[] $pages
109 109
 	 */
110
-	protected function addToArchive( array $pages ) {
110
+	protected function addToArchive ( array $pages ) {
111 111
 		$this->getLogger()->info(
112 112
 			'Adding to archive: ' . implode( ', ', array_map( 'strval', $pages ) )
113 113
 		);
114 114
 
115
-		$simple = $votes = [];
115
+		$simple = $votes = [ ];
116 116
 		foreach ( $pages as $page ) {
117 117
 			if ( $page->isVote() ) {
118
-				$votes[] = $page;
118
+				$votes[ ] = $page;
119 119
 			} else {
120
-				$simple[] = $page;
120
+				$simple[ ] = $page;
121 121
 			}
122 122
 		}
123 123
 
@@ -134,21 +134,21 @@  discard block
 block discarded – undo
134 134
 	 * @param string $archiveTitle
135 135
 	 * @param array $pages
136 136
 	 */
137
-	private function reallyAddToArchive( string $archiveTitle, array $pages ) {
137
+	private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
138 138
 		$curTitle = "$archiveTitle/" . date( 'Y' );
139 139
 
140 140
 		$append = '';
141
-		$archivedList = [];
141
+		$archivedList = [ ];
142 142
 		foreach ( $pages as $page ) {
143 143
 			$append .= '{{' . $page->getTitle() . "}}\n";
144
-			$archivedList[] = $page->getUserNum();
144
+			$archivedList[ ] = $page->getUserNum();
145 145
 		}
146 146
 
147 147
 		if ( count( $archivedList ) > 1 ) {
148 148
 			$last = array_pop( $archivedList );
149 149
 			$userNums = implode( ', ', $archivedList ) . " e $last";
150 150
 		} else {
151
-			$userNums = $archivedList[0];
151
+			$userNums = $archivedList[ 0 ];
152 152
 		}
153 153
 
154 154
 		$summary = $this->msg( 'close-archive-summary' )
@@ -167,15 +167,14 @@  discard block
 block discarded – undo
167 167
 	 * @param PageRiconferma $page
168 168
 	 * @see CreatePages::updateBasePage()
169 169
 	 */
170
-	protected function updateBasePage( PageRiconferma $page ) {
170
+	protected function updateBasePage ( PageRiconferma $page ) {
171 171
 		$this->getLogger()->info( "Updating base page for $page" );
172 172
 
173 173
 		$basePage = new Page( $page->getBaseTitle() );
174 174
 		$current = $basePage->getContent();
175 175
 
176 176
 		$outcomeText = $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ?
177
-			'non riconfermato' :
178
-			'riconfermato';
177
+			'non riconfermato' : 'riconfermato';
179 178
 		$text = $page->isVote() ? "votazione: $outcomeText" : 'riconferma tacita';
180 179
 
181 180
 		$newContent = str_replace( 'riconferma in corso', $text, $current );
@@ -191,16 +190,16 @@  discard block
 block discarded – undo
191 190
 	 * @param PageRiconferma[] $pages
192 191
 	 * @see UpdatesAround::addVote()
193 192
 	 */
194
-	protected function updateVote( array $pages ) {
193
+	protected function updateVote ( array $pages ) {
195 194
 		$this->getLogger()->info(
196 195
 			'Updating votazioni: ' . implode( ', ', array_map( 'strval', $pages ) )
197 196
 		);
198 197
 		$votePage = new Page( $this->getConfig()->get( 'ric-vote-page' ) );
199 198
 		$content = $votePage->getContent();
200 199
 
201
-		$titles = [];
200
+		$titles = [ ];
202 201
 		foreach ( $pages as $page ) {
203
-			$titles[] = preg_quote( $page->getTitle() );
202
+			$titles[ ] = preg_quote( $page->getTitle() );
204 203
 		}
205 204
 
206 205
 		$titleReg = implode( '|', array_map( 'preg_quote', $titles ) );
@@ -231,7 +230,7 @@  discard block
 block discarded – undo
231 230
 	 * @param array $pages
232 231
 	 * @see UpdatesAround::addNews()
233 232
 	 */
234
-	protected function updateNews( array $pages ) {
233
+	protected function updateNews ( array $pages ) {
235 234
 		$simpleAmount = $voteAmount = 0;
236 235
 		foreach ( $pages as $page ) {
237 236
 			if ( $page->isVote() ) {
@@ -251,12 +250,12 @@  discard block
 block discarded – undo
251 250
 		$simpleReg = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
252 251
 		$voteReg = '!(\| *riconferme[ _]voto[ _]amministratori *= *)(\d+)!';
253 252
 
254
-		$simpleMatches = $voteMatches = [];
253
+		$simpleMatches = $voteMatches = [ ];
255 254
 		preg_match( $simpleReg, $content, $simpleMatches );
256 255
 		preg_match( $voteReg, $content, $voteMatches );
257 256
 
258
-		$newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
259
-		$newVote = (int)$voteMatches[2] - $voteAmount ?: '';
257
+		$newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
258
+		$newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
260 259
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $content );
261 260
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
262 261
 
@@ -276,7 +275,7 @@  discard block
 block discarded – undo
276 275
 	 *
277 276
 	 * @param PageRiconferma[] $pages
278 277
 	 */
279
-	protected function updateAdminList( array $pages ) {
278
+	protected function updateAdminList ( array $pages ) {
280 279
 		$this->getLogger()->info(
281 280
 			'Updating admin list: ' . implode( ', ', array_map( 'strval', $pages ) )
282 281
 		);
@@ -284,17 +283,17 @@  discard block
 block discarded – undo
284 283
 		$newContent = $adminsPage->getContent();
285 284
 		$newDate = date( 'Ymd', strtotime( '+1 year' ) );
286 285
 
287
-		$riconfNames = $removeNames = [];
286
+		$riconfNames = $removeNames = [ ];
288 287
 		foreach ( $pages as $page ) {
289 288
 			$user = $page->getUser();
290 289
 			$reg = "!(\{\{Amministratore\/riga\|$user.+\| *)\d+( *\|(?: *pausa)? *\}\}\n)!";
291 290
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
292 291
 				// Remove the line
293 292
 				$newContent = preg_replace( $reg, '', $newContent );
294
-				$removeNames[] = $user;
293
+				$removeNames[ ] = $user;
295 294
 			} else {
296 295
 				$newContent = preg_replace( $reg, '$1' . $newDate . '$2', $newContent );
297
-				$riconfNames[] = $user;
296
+				$riconfNames[ ] = $user;
298 297
 			}
299 298
 		}
300 299
 
@@ -302,7 +301,7 @@  discard block
 block discarded – undo
302 301
 			$lastUser = array_pop( $riconfNames );
303 302
 			$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
304 303
 		} elseif ( $riconfNames ) {
305
-			$riconfList = $riconfNames[0];
304
+			$riconfList = $riconfNames[ 0 ];
306 305
 		} else {
307 306
 			$riconfList = 'nessuno';
308 307
 		}
@@ -311,7 +310,7 @@  discard block
 block discarded – undo
311 310
 			$lastUser = array_pop( $removeNames );
312 311
 			$removeList = implode( ', ', $removeNames ) . " e $lastUser";
313 312
 		} elseif ( $removeNames ) {
314
-			$removeList = $removeNames[0];
313
+			$removeList = $removeNames[ 0 ];
315 314
 		} else {
316 315
 			$removeList = 'nessuno';
317 316
 		}
@@ -334,13 +333,13 @@  discard block
 block discarded – undo
334 333
 	/**
335 334
 	 * @param PageRiconferma[] $pages
336 335
 	 */
337
-	protected function updateCUList( array $pages ) {
336
+	protected function updateCUList ( array $pages ) {
338 337
 		$this->getLogger()->info( 'Checking if CU list needs updating.' );
339 338
 		$cuList = new Page( $this->getConfig()->get( 'cu-list-title' ) );
340 339
 		$admins = $this->getDataProvider()->getUsersList();
341 340
 		$newContent = $cuList->getContent();
342 341
 
343
-		$riconfNames = $removeNames = [];
342
+		$riconfNames = $removeNames = [ ];
344 343
 		foreach ( $pages as $page ) {
345 344
 			$user = $page->getUser();
346 345
 			if ( array_key_exists( 'checkuser', $admins[ $user ] ) ) {
@@ -348,10 +347,10 @@  discard block
 block discarded – undo
348 347
 				if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
349 348
 					// Remove the line
350 349
 					$newContent = preg_replace( $reg, '', $newContent );
351
-					$removeNames[] = $user;
350
+					$removeNames[ ] = $user;
352 351
 				} else {
353 352
 					$newContent = preg_replace( $reg, '$1{{subst:#time:j F Y}}$2', $newContent );
354
-					$riconfNames[] = $user;
353
+					$riconfNames[ ] = $user;
355 354
 				}
356 355
 			}
357 356
 		}
@@ -368,7 +367,7 @@  discard block
 block discarded – undo
368 367
 			$lastUser = array_pop( $riconfNames );
369 368
 			$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
370 369
 		} elseif ( $riconfNames ) {
371
-			$riconfList = $riconfNames[0];
370
+			$riconfList = $riconfNames[ 0 ];
372 371
 		} else {
373 372
 			$riconfList = 'nessuno';
374 373
 		}
@@ -377,7 +376,7 @@  discard block
 block discarded – undo
377 376
 			$lastUser = array_pop( $removeNames );
378 377
 			$removeList = implode( ', ', $removeNames ) . " e $lastUser";
379 378
 		} elseif ( $removeNames ) {
380
-			$removeList = $removeNames[0];
379
+			$removeList = $removeNames[ 0 ];
381 380
 		} else {
382 381
 			$removeList = 'nessuno';
383 382
 		}
@@ -399,17 +398,17 @@  discard block
 block discarded – undo
399 398
 	/**
400 399
 	 * @param PageRiconferma[] $pages
401 400
 	 */
402
-	protected function updateBurList( array $pages ) {
401
+	protected function updateBurList ( array $pages ) {
403 402
 		$this->getLogger()->info( 'Checking if bur list needs updating.' );
404 403
 		$admins = $this->getDataProvider()->getUsersList();
405 404
 
406
-		$remove = [];
405
+		$remove = [ ];
407 406
 		foreach ( $pages as $page ) {
408 407
 			$user = $page->getUser();
409 408
 			if ( array_key_exists( 'bureaucrat', $admins[ $user ] ) &&
410 409
 				$page->getOutcome() & PageRiconferma::OUTCOME_FAIL
411 410
 			) {
412
-				$remove[] = $user;
411
+				$remove[ ] = $user;
413 412
 			}
414 413
 		}
415 414
 
@@ -428,7 +427,7 @@  discard block
 block discarded – undo
428 427
 			$lastUser = array_pop( $remove );
429 428
 			$removeList = implode( ', ', $remove ) . " e $lastUser";
430 429
 		} else {
431
-			$removeList = $remove[0];
430
+			$removeList = $remove[ 0 ];
432 431
 		}
433 432
 
434 433
 		$summary = $this->msg( 'bur-list-update-summary' )
@@ -447,7 +446,7 @@  discard block
 block discarded – undo
447 446
 	 *
448 447
 	 * @param PageRiconferma[] $pages
449 448
 	 */
450
-	protected function requestRemoval( array $pages ) {
449
+	protected function requestRemoval ( array $pages ) {
451 450
 		$this->getLogger()->info(
452 451
 			'Requesting removal on meta for: ' . implode( ', ', array_map( 'strval', $pages ) )
453 452
 		);
@@ -490,14 +489,14 @@  discard block
 block discarded – undo
490 489
 	 *
491 490
 	 * @param PageRiconferma[] $pages
492 491
 	 */
493
-	protected function updateAnnunci( array $pages ) {
492
+	protected function updateAnnunci ( array $pages ) {
494 493
 		$this->getLogger()->info( 'Updating annunci' );
495 494
 
496
-		$names = [];
495
+		$names = [ ];
497 496
 		$text = '';
498 497
 		foreach ( $pages as $page ) {
499 498
 			$user = $page->getUser();
500
-			$names[] = $user;
499
+			$names[ ] = $user;
501 500
 			$text .= "{{Breve|admin|{{subst:#time:j}}|[[Utente:$user|]] " .
502 501
 				"non è stato riconfermato [[WP:A|amministratore]].}}\n";
503 502
 		}
@@ -520,7 +519,7 @@  discard block
 block discarded – undo
520 519
 			$lastUser = array_pop( $names );
521 520
 			$namesList = implode( ', ', $names ) . " e $lastUser";
522 521
 		} else {
523
-			$namesList = $names[0];
522
+			$namesList = $names[ 0 ];
524 523
 		}
525 524
 
526 525
 		$summary = $this->msg( 'annunci-summary' )
@@ -539,16 +538,16 @@  discard block
 block discarded – undo
539 538
 	 *
540 539
 	 * @param PageRiconferma[] $pages
541 540
 	 */
542
-	protected function updateUltimeNotizie( array $pages ) {
541
+	protected function updateUltimeNotizie ( array $pages ) {
543 542
 		$this->getLogger()->info( 'Updating ultime notizie' );
544 543
 		$notiziePage = new Page( $this->getConfig()->get( 'ultimenotizie-title' ) );
545 544
 
546
-		$names = [];
545
+		$names = [ ];
547 546
 		$text = '';
548 547
 		foreach ( $pages as $page ) {
549 548
 			$user = $page->getUser();
550 549
 			$title = $page->getTitle();
551
-			$names[] = $user;
550
+			$names[ ] = $user;
552 551
 			$text .= "'''{{subst:#time:j F}}''': [[Utente:$user|]] non è stato [[$title|riconfermato]] " .
553 552
 				'[[WP:A|amministratore]]; ora gli admin sono {{subst:#expr: {{NUMBEROFADMINS}} - 1}}.';
554 553
 		}
@@ -567,7 +566,7 @@  discard block
 block discarded – undo
567 566
 			$lastUser = array_pop( $names );
568 567
 			$namesList = implode( ', ', $names ) . " e $lastUser";
569 568
 		} else {
570
-			$namesList = $names[0];
569
+			$namesList = $names[ 0 ];
571 570
 		}
572 571
 
573 572
 		$summary = $this->msg( 'ultimenotizie-summary' )
Please login to merge, or discard this patch.