Daimona / BotRiconferme

includes/Task/Subtask/FailedUpdates.php

Spacing +16 added lines, -16 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -16,7 +16,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$failed = $this->getFailures();
 		if ( $failed ) {
 			$bureaucrats = $this->getFailedBureaucrats( $failed );
@@ -36,12 +36,12 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	private function getFailures() : array {
-		$ret = [];
+	private function getFailures () : array {
+		$ret = [ ];
 		$allPages = $this->getDataProvider()->getPagesToClose();
 		foreach ( $allPages as $page ) {
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -50,7 +50,7 @@ 
 	/**
 	 * @param User[] $users
 	 */
-	protected function updateBurList( array $users ) {
+	protected function updateBurList ( array $users ) {
 		$this->getLogger()->info( 'Updating bur list. Removing: ' . implode( ', ', $users ) );
 		$remList = Element::regexFromArray( $users );
 		$burList = new Page( $this->getConfig()->get( 'bur-list-title' ) );
@@ -73,7 +73,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function requestRemoval( array $pages ) {
+	protected function requestRemoval ( array $pages ) {
 		$this->getLogger()->info( 'Requesting flag removal for: ' . implode( ', ', $pages ) );
 
 		$flagRemPage = new Page(
@@ -109,15 +109,15 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAnnunci( array $pages ) {
+	protected function updateAnnunci ( array $pages ) {
 		$this->getLogger()->info( 'Updating annunci' );
 		$section = 1;
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUser()->getName();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= $this->msg( 'annunci-text' )->params( [ '$user' => $user ] )->text();
 		}
 
@@ -149,16 +149,16 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateUltimeNotizie( array $pages ) {
+	protected function updateUltimeNotizie ( array $pages ) {
 		$this->getLogger()->info( 'Updating ultime notizie' );
 		$notiziePage = new Page( $this->getConfig()->get( 'ultimenotizie-page-title' ) );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		$msg = $this->msg( 'ultimenotizie-text' );
 		foreach ( $pages as $page ) {
 			$user = $page->getUser()->getName();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= $msg->params( [ '$user' => $user, '$title' => $page->getTitle() ] )->text();
 		}
 
@@ -187,12 +187,12 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return User[]
 	 */
-	private function getFailedBureaucrats( array $pages ) : array {
-		$ret = [];
+	private function getFailedBureaucrats ( array $pages ) : array {
+		$ret = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( $user->inGroup( 'bureaucrat' ) ) {
-				$ret[] = $user;
+				$ret[ ] = $user;
 			}
 		}
 		return $ret;

includes/Task/Subtask/SimpleUpdates.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -16,7 +16,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 
 		if ( !$pages ) {
@@ -38,15 +38,15 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addToVotazioni()
 	 */
-	protected function updateVotazioni( array $pages ) {
+	protected function updateVotazioni ( array $pages ) {
 		$this->getLogger()->info(
 			'Updating votazioni: ' . implode( ', ', $pages )
 		);
 		$votePage = new Page( $this->getConfig()->get( 'vote-page-title' ) );
 
-		$users = [];
+		$users = [ ];
 		foreach ( $pages as $page ) {
-			$users[] = $page->getUser();
+			$users[ ] = $page->getUser();
 		}
 		$usersReg = Element::regexFromArray( $users );
 
@@ -67,7 +67,7 @@ 
 	 * @param array $pages
 	 * @see UpdatesAround::addToNews()
 	 */
-	protected function updateNews( array $pages ) {
+	protected function updateNews ( array $pages ) {
 		$simpleAmount = $voteAmount = 0;
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
@@ -87,8 +87,8 @@ 
 		$simpleMatches = $newsPage->getMatch( $simpleReg );
 		$voteMatches = $newsPage->getMatch( $voteReg );
 
-		$newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
-		$newVote = (int)$voteMatches[2] - $voteAmount ?: '';
+		$newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
+		$newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $newsPage->getContent() );
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
 
@@ -106,21 +106,21 @@ 
 	 *
 	 * @param bool[] $outcomes
 	 */
-	protected function updateAdminList( array $outcomes ) {
+	protected function updateAdminList ( array $outcomes ) {
 		$this->getLogger()->info( 'Updating admin list' );
 		$adminsPage = new Page( $this->getConfig()->get( 'admins-list-title' ) );
 		$newContent = $adminsPage->getContent();
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $outcomes as $user => $confirmed ) {
 			$userReg = ( new User( $user ) )->getRegex();
 			$reg = "!(\{\{Amministratore\/riga\|$userReg.+\| *)\d+( *\|[ \w]*\}\}.*\n)!";
 			if ( $confirmed ) {
 				$newContent = preg_replace( $reg, '${1}{{subst:#time:Ymd|+1 year}}$2', $newContent );
-				$riconfNames[] = $user;
+				$riconfNames[ ] = $user;
 			} else {
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user;
+				$removeNames[ ] = $user;
 			}
 		}
 
@@ -140,21 +140,21 @@ 
 	/**
 	 * @param bool[] $outcomes
 	 */
-	protected function updateCUList( array $outcomes ) {
+	protected function updateCUList ( array $outcomes ) {
 		$this->getLogger()->info( 'Updating CU list.' );
 		$cuList = new Page( $this->getConfig()->get( 'cu-list-title' ) );
 		$newContent = $cuList->getContent();
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $outcomes as $user => $confirmed ) {
 			$userReg = ( new User( $user ) )->getRegex();
 			$reg = "!(\{\{ *Checkuser *\| *$userReg *\|[^}]+\| *)[\w \d]+(}}.*\n)!";
 			if ( $confirmed ) {
 				$newContent = preg_replace( $reg, '${1}{{subst:#time:j F Y}}$2', $newContent );
-				$riconfNames[] = $user;
+				$riconfNames[ ] = $user;
 			} else {
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user;
+				$removeNames[ ] = $user;
 			}
 		}
 
@@ -178,8 +178,8 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return bool[]
 	 */
-	private function getGroupOutcomes( string $group, array $pages ) : array {
-		$ret = [];
+	private function getGroupOutcomes ( string $group, array $pages ) : array {
+		$ret = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( $user->inGroup( $group ) ) {

includes/Task/StartVote.php

Spacing +14 added lines, -14 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,15 +15,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getOpenPages();
 
 		if ( !$pages ) {
@@ -37,12 +37,12 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return int a STATUS_* constant
 	 */
-	protected function processPages( array $pages ) : int {
-		$donePages = [];
+	protected function processPages ( array $pages ) : int {
+		$donePages = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->hasOpposition() && !$page->isVote() ) {
 				$this->openVote( $page );
-				$donePages[] = $page;
+				$donePages[ ] = $page;
 			}
 		}
 
@@ -60,7 +60,7 @@ 
 	 *
 	 * @param PageRiconferma $page
 	 */
-	protected function openVote( PageRiconferma $page ) {
+	protected function openVote ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Starting vote on $page" );
 
 		$content = $page->getContent();
@@ -99,12 +99,12 @@ 
 	 * @see SimpleUpdates::updateVotazioni()
 	 * @see UpdatesAround::addToVotazioni()
 	 */
-	protected function updateVotazioni( array $pages ) {
+	protected function updateVotazioni ( array $pages ) {
 		$votePage = new Page( $this->getConfig()->get( 'vote-page-title' ) );
 
-		$users = [];
+		$users = [ ];
 		foreach ( $pages as $page ) {
-			$users[] = $page->getUser();
+			$users[ ] = $page->getUser();
 		}
 		$usersReg = Element::regexFromArray( $users );
 
@@ -142,7 +142,7 @@ 
 	 * @see SimpleUpdates::updateNews()
 	 * @throws TaskException
 	 */
-	protected function updateNews( int $amount ) {
+	protected function updateNews ( int $amount ) {
 		$this->getLogger()->info( "Turning $amount pages into votes" );
 		$newsPage = new Page( $this->getConfig()->get( 'news-page-title' ) );
 
@@ -157,8 +157,8 @@ 
 			throw new TaskException( 'Param "voto" not found in news page' );
 		}
 
-		$newTac = intval( $newsPage->getMatch( $regTac )[2] ) - $amount ?: '';
-		$newVot = intval( $newsPage->getMatch( $regVot )[2] ) + $amount ?: '';
+		$newTac = intval( $newsPage->getMatch( $regTac )[ 2 ] ) - $amount ?: '';
+		$newVot = intval( $newsPage->getMatch( $regVot )[ 2 ] ) + $amount ?: '';
 
 		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
 		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );

includes/Wiki/Page/PageRiconferma.php

Spacing +22 added lines, -22 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki\Page;
 
@@ -13,7 +13,7 @@ 
 	private $supportSection;
 	private $opposeSection;
 	/** @var array Counts of votes for each section */
-	private $sectionCounts = [];
+	private $sectionCounts = [ ];
 
 	// Possible outcomes of a vote
 	const OUTCOME_OK = 0;
@@ -31,7 +31,7 @@ 
 	 * because they can vary depending on whether the page is a vote, which is relatively
 	 * expensive to know since it requires parsing the content of the page.
 	 */
-	private function defineSections() {
+	private function defineSections () {
 		$this->supportSection = $this->isVote() ? 3 : 0;
 		$this->opposeSection = $this->isVote() ? 4 : 3;
 	}
@@ -41,8 +41,8 @@ 
 	 *
 	 * @return User
 	 */
-	public function getUser() : User {
-		$name = explode( '/', $this->title )[2];
+	public function getUser () : User {
+		$name = explode( '/', $this->title )[ 2 ];
 		return new User( $name );
 	}
 
@@ -51,7 +51,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getNum() : int {
+	public function getNum () : int {
 		$bits = explode( '/', $this->getTitle() );
 		return intval( end( $bits ) );
 	}
@@ -61,8 +61,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUserNum() : string {
-		return explode( '/', $this->getTitle(), 3 )[2];
+	public function getUserNum () : string {
+		return explode( '/', $this->getTitle(), 3 )[ 2 ];
 	}
 
 	/**
@@ -70,7 +70,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function getBaseTitle() : string {
+	public function getBaseTitle () : string {
 		// @phan-suppress-next-line PhanTypeMismatchArgumentInternal Phan bug
 		return substr( $this->getTitle(), 0, strrpos( $this->getTitle(), '/' ) );
 	}
@@ -80,7 +80,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getOpposingCount() : int {
+	public function getOpposingCount () : int {
 		$this->defineSections();
 		return $this->getCountForSection( $this->opposeSection );
 	}
@@ -91,7 +91,7 @@ 
 	 * @return int
 	 * @throws \BadMethodCallException
 	 */
-	public function getSupportCount() : int {
+	public function getSupportCount () : int {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'Cannot get support for a non-vote page.' );
 		}
@@ -105,13 +105,13 @@ 
 	 * @param int $secNum
 	 * @return int
 	 */
-	protected function getCountForSection( int $secNum ) : int {
+	protected function getCountForSection ( int $secNum ) : int {
 		if ( !isset( $this->sectionCounts[ $secNum ] ) ) {
 			$content = $this->controller->getPageContent( $this->title, $secNum );
 			// Let's hope that this is good enough...
-			$this->sectionCounts[$secNum] = preg_match_all( "/^\# *(?![# *:]|\.\.\.$)/m", $content );
+			$this->sectionCounts[ $secNum ] = preg_match_all( "/^\# *(?![# *:]|\.\.\.$)/m", $content );
 		}
-		return $this->sectionCounts[$secNum];
+		return $this->sectionCounts[ $secNum ];
 	}
 
 	/**
@@ -119,9 +119,9 @@ 
 	 *
 	 * @return int
 	 */
-	protected function getQuorum() : int {
+	protected function getQuorum () : int {
 		$reg = "!soddisfare il \[\[[^|\]]+\|quorum]] di '''(\d+) voti'''!";
-		return intval( $this->getMatch( $reg )[1] );
+		return intval( $this->getMatch( $reg )[ 1 ] );
 	}
 
 	/**
@@ -129,7 +129,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function hasOpposition() : bool {
+	public function hasOpposition () : bool {
 		return $this->getOpposingCount() >= self::REQUIRED_OPPOSE;
 	}
 
@@ -138,7 +138,7 @@ 
 	 *
 	 * @return int One of the OUTCOME_* constants
 	 */
-	public function getOutcome() : int {
+	public function getOutcome () : int {
 		if ( !$this->isVote() ) {
 			return self::OUTCOME_OK;
 		}
@@ -161,7 +161,7 @@ 
 	 * @throws \BadMethodCallException
 	 * @throws \LogicException
 	 */
-	public function getOutcomeText() : string {
+	public function getOutcomeText () : string {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'No need for an outcome text.' );
 		}
@@ -195,7 +195,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isVote() : bool {
+	public function isVote () : bool {
 		$sectionReg = '/<!-- SEZIONE DA UTILIZZARE PER/';
 		return !$this->matches( $sectionReg );
 	}
@@ -205,7 +205,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getCreationTimestamp() : int {
+	public function getCreationTimestamp () : int {
 		return $this->controller->getPageCreationTS( $this->title );
 	}
 	/**
@@ -213,7 +213,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getEndTimestamp() : int {
+	public function getEndTimestamp () : int {
 		if ( $this->isVote() ) {
 			$reg = "!La votazione ha inizio il.+ alle ore ([\d:]+) e ha termine il (.+) alla stessa ora!";
 			list( , $hours, $day ) = $this->getMatch( $reg );

includes/Request/RequestBase.php

Spacing +23 added lines, -23 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Request;
 
@@ -30,14 +30,14 @@ 
 	/** @var string */
 	protected $method = 'GET';
 	/** @var string[] */
-	protected $newCookies = [];
+	protected $newCookies = [ ];
 
 	/**
 	 * Use self::newFromParams, which will provide the right class to use
 	 *
 	 * @param array $params
 	 */
-	protected function __construct( array $params ) {
+	protected function __construct ( array $params ) {
 		$this->params = [ 'format' => 'json' ] + $params;
 		$this->url = DEFAULT_URL;
 	}
@@ -48,7 +48,7 @@ 
 	 * @param array $params
 	 * @return self
 	 */
-	public static function newFromParams( array $params ) : self {
+	public static function newFromParams ( array $params ) : self {
 		if ( extension_loaded( 'curl' ) ) {
 			$ret = new CurlRequest( $params );
 		} else {
@@ -62,7 +62,7 @@ 
 	 *
 	 * @return self For chaining
 	 */
-	public function setPost() : self {
+	public function setPost () : self {
 		$this->method = 'POST';
 		return $this;
 	}
@@ -73,7 +73,7 @@ 
 	 * @param string $url
 	 * @return self for chaining
 	 */
-	public function setUrl( string $url ) : self {
+	public function setUrl ( string $url ) : self {
 		$this->url = $url;
 		return $this;
 	}
@@ -83,14 +83,14 @@ 
 	 *
 	 * @return \stdClass
 	 */
-	public function execute() : \stdClass {
+	public function execute () : \stdClass {
 		$curParams = $this->params;
-		$sets = [];
+		$sets = [ ];
 		do {
 			$res = $this->makeRequestInternal( $curParams );
 
 			$this->handleErrorAndWarnings( $res );
-			$sets[] = $res;
+			$sets[ ] = $res;
 
 			$finished = true;
 			if ( isset( $res->continue ) ) {
@@ -108,9 +108,9 @@ 
 	 * @param array $params
 	 * @return \stdClass
 	 */
-	private function makeRequestInternal( array $params ) : \stdClass {
+	private function makeRequestInternal ( array $params ) : \stdClass {
 		if ( $this->method === 'POST' ) {
-			$params['maxlag'] = self::MAXLAG;
+			$params[ 'maxlag' ] = self::MAXLAG;
 		}
 		$params = http_build_query( $params );
 
@@ -126,17 +126,17 @@ 
 	 * @param string $params
 	 * @return string
 	 */
-	abstract protected function reallyMakeRequest( string $params ) : string;
+	abstract protected function reallyMakeRequest ( string $params ) : string;
 
 	/**
 	 * After a request, set cookies for the next ones
 	 *
 	 * @param array $cookies
 	 */
-	protected function setCookies( array $cookies ) {
+	protected function setCookies ( array $cookies ) {
 		foreach ( $cookies as $cookie ) {
 			$bits = explode( ';', $cookie );
-			list( $name, $value ) = explode( '=', $bits[0] );
+			list( $name, $value ) = explode( '=', $bits[ 0 ] );
 			self::$cookiesToSet[ $name ] = $value;
 		}
 	}
@@ -147,7 +147,7 @@ 
 	 * @param \stdClass $res
 	 * @return APIRequestException
 	 */
-	private function getException( \stdClass $res ) : APIRequestException {
+	private function getException ( \stdClass $res ) : APIRequestException {
 		switch ( $res->error->code ) {
 			case 'missingtitle':
 				$ex = new MissingPageException;
@@ -170,7 +170,7 @@ 
 	 * @param \stdClass $res
 	 * @throws APIRequestException
 	 */
-	protected function handleErrorAndWarnings( \stdClass $res ) {
+	protected function handleErrorAndWarnings ( \stdClass $res ) {
 		if ( isset( $res->error ) ) {
 			throw $this->getException( $res );
 		} elseif ( isset( $res->warnings ) ) {
@@ -186,7 +186,7 @@ 
 	 * @param \stdClass[] $sets
 	 * @return \stdClass
 	 */
-	private function mergeSets( array $sets ) : \stdClass {
+	private function mergeSets ( array $sets ) : \stdClass {
 		// Use the first set as template
 		$ret = array_shift( $sets );
 
@@ -203,7 +203,7 @@ 
 	 * @param array|\stdClass $second
 	 * @return array|\stdClass array
 	 */
-	private function recursiveMerge( $first, $second ) {
+	private function recursiveMerge ( $first, $second ) {
 		$ret = $first;
 		if ( is_array( $second ) ) {
 			$ret = is_array( $first ) ? array_merge_recursive( $first, $second ) : $second;
@@ -221,14 +221,14 @@ 
 	 *
 	 * @return array
 	 */
-	protected function getHeaders() :array {
+	protected function getHeaders () :array {
 		$ret = self::HEADERS;
 		if ( self::$cookiesToSet ) {
-			$cookies = [];
+			$cookies = [ ];
 			foreach ( self::$cookiesToSet as $cname => $cval ) {
-				$cookies[] = trim( "$cname=$cval" );
+				$cookies[ ] = trim( "$cname=$cval" );
 			}
-			$ret[] = 'Cookie: ' . implode( '; ', $cookies );
+			$ret[ ] = 'Cookie: ' . implode( '; ', $cookies );
 		}
 		return $ret;
 	}
@@ -239,7 +239,7 @@ 
 	 * @param array $headers
 	 * @return string
 	 */
-	protected function buildHeadersString( array $headers ) : string {
+	protected function buildHeadersString ( array $headers ) : string {
 		$ret = '';
 		foreach ( $headers as $header ) {
 			$ret .= "$header\r\n";