Daimona / BotRiconferme

includes/PageRiconferma.php

Spacing +24 added lines, -24 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -29,7 +29,7 @@ 
 	 * @param string $title
 	 * @param WikiController $controller
 	 */
-	public function __construct( string $title, WikiController $controller ) {
+	public function __construct ( string $title, WikiController $controller ) {
 		$this->title = $title;
 		$this->controller = $controller;
 	}
@@ -37,7 +37,7 @@ 
 	/**
 	 * @return string
 	 */
-	public function getTitle() : string {
+	public function getTitle () : string {
 		return $this->title;
 	}
 
@@ -46,8 +46,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUser() : string {
-		return explode( '/', $this->title )[2];
+	public function getUser () : string {
+		return explode( '/', $this->title )[ 2 ];
 	}
 
 	/**
@@ -55,7 +55,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getNum() : int {
+	public function getNum () : int {
 		$bits = explode( '/', $this->getTitle() );
 		return intval( end( $bits ) );
 	}
@@ -65,8 +65,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUserNum() : string {
-		return explode( '/', $this->getTitle(), 3 )[2];
+	public function getUserNum () : string {
+		return explode( '/', $this->getTitle(), 3 )[ 2 ];
 	}
 
 	/**
@@ -74,7 +74,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function getBaseTitle() : string {
+	public function getBaseTitle () : string {
 		// @phan-suppress-next-line PhanTypeMismatchArgumentInternal Phan bug
 		return substr( $this->getTitle(), 0, strrpos( $this->getTitle(), '/' ) );
 	}
@@ -84,7 +84,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function getContent() : string {
+	public function getContent () : string {
 		if ( $this->content === null ) {
 			$this->content = $this->controller->getPageContent( $this->title );
 		}
@@ -96,7 +96,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getOpposingCount() : int {
+	public function getOpposingCount () : int {
 		return $this->getCountForSection( self::SECTION_OPPOSE );
 	}
 
@@ -105,7 +105,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getSupportCount() : int {
+	public function getSupportCount () : int {
 		return $this->getCountForSection( self::SECTION_SUPPORT );
 	}
 
@@ -115,7 +115,7 @@ 
 	 * @param int $secNum
 	 * @return int
 	 */
-	protected function getCountForSection( int $secNum ) : int {
+	protected function getCountForSection ( int $secNum ) : int {
 		$params = [
 			'action' => 'query',
 			'prop' => 'revisions',
@@ -127,7 +127,7 @@ 
 
 		$res = RequestBase::newFromParams( $params )->execute();
 		$page = reset( $res->query->pages );
-		$content = $page->revisions[0]->slots->main->{ '*' };
+		$content = $page->revisions[ 0 ]->slots->main->{ '*' };
 		// Let's hope that this is good enough...
 		return substr_count( $content, "\n\# *(?![#*])" );
 	}
@@ -135,11 +135,11 @@ 
 	/**
 	 * Gets the quorum used for the current page
 	 */
-	protected function getQuorum() : int {
+	protected function getQuorum () : int {
 		$reg = "!soddisfare il \[\[[^|\]]+\|quorum]] di '''(\d+) voti'''!";
-		$matches = [];
+		$matches = [ ];
 		preg_match( $reg, $this->getContent(), $matches );
-		return intval( $matches[1] );
+		return intval( $matches[ 1 ] );
 	}
 
 	/**
@@ -147,7 +147,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function hasOpposition() : bool {
+	public function hasOpposition () : bool {
 		return $this->getOpposingCount() >= 15;
 	}
 
@@ -157,7 +157,7 @@ 
 	 * @return int One of the OUTCOME_* constants
 	 * @throws \BadMethodCallException
 	 */
-	public function getOutcome() : int {
+	public function getOutcome () : int {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'Cannot get outcome for a non-vote page.' );
 		}
@@ -176,7 +176,7 @@ 
 	 * @return string
 	 * @throws \BadMethodCallException
 	 */
-	public function getOutcomeText() : string {
+	public function getOutcomeText () : string {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'No need for an outcome text.' );
 		}
@@ -208,7 +208,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isVote() : bool {
+	public function isVote () : bool {
 		$sectionReg = '/<!-- SEZIONE DA UTILIZZARE PER/';
 		return preg_match( $sectionReg, $this->getContent() ) === false;
 	}
@@ -218,9 +218,9 @@ 
 	 *
 	 * @return int
 	 */
-	public function getEndTimestamp() : int {
+	public function getEndTimestamp () : int {
 		if ( $this->isVote() ) {
-			$matches = [];
+			$matches = [ ];
 			$reg = "!La votazione ha inizio il.+ e ha termine.+ '''([^']+)''' alle ore '''([^']+)'''!";
 			preg_match( $reg, $this->getContent(), $matches );
 			list( , $day, $hours ) = $matches;
@@ -232,7 +232,7 @@ 
 		}
 	}
 
-	public function __toString() {
+	public function __toString () {
 		return $this->getTitle();
 	}
 }

includes/Task/StartVote.php

Spacing +17 added lines, -17 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task StartVote' );
 
 		$pages = $this->getDataProvider()->getOpenPages();
@@ -32,12 +32,12 @@ 
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function processPages( array $pages ) {
-		$actualPages = [];
+	protected function processPages ( array $pages ) {
+		$actualPages = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->hasOpposition() && !$page->isVote() ) {
 				$this->openVote( $page );
-				$actualPages[] = $page;
+				$actualPages[ ] = $page;
 			}
 		}
 
@@ -54,7 +54,7 @@ 
 	 *
 	 * @param PageRiconferma $page
 	 */
-	protected function openVote( PageRiconferma $page ) {
+	protected function openVote ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Starting vote on $page" );
 
 		$content = $page->getContent();
@@ -93,13 +93,13 @@ 
 	 * @see ClosePages::updateVote()
 	 * @see UpdatesAround::addVote()
 	 */
-	protected function updateVotePage( array $pages ) {
+	protected function updateVotePage ( array $pages ) {
 		$votePage = $this->getConfig()->get( 'ric-vote-page' );
 		$content = $this->getController()->getPageContent( $votePage );
 
-		$titles = [];
+		$titles = [ ];
 		foreach ( $pages as $page ) {
-			$titles[] = preg_quote( $page->getTitle() );
+			$titles[ ] = preg_quote( $page->getTitle() );
 		}
 		$titleReg = implode( '|', $titles );
 		$search = "!^\*.+ La \[\[($titleReg)\|procedura]] termina.+\n!gm";
@@ -122,14 +122,14 @@ 
 			$newContent = preg_replace( $introReg, '$0' . "\n$newLines", $newContent, 1 );
 		} else {
 			// Start section
-			$matches = [];
+			$matches = [ ];
 			if ( preg_match( $introReg, $content, $matches ) === false ) {
 				throw new TaskException( 'Intro not found in vote page' );
 			}
 			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
 			// Replace semicolon with full stop
 			$newLines = substr( $newLines, 0, -2 ) . ".\n";
-			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $newContent, 1 );
+			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[ 0 ]}\n$newLines", $newContent, 1 );
 		}
 
 		$summary = strtr(
@@ -139,7 +139,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -160,7 +160,7 @@ 
 	 * @see UpdatesAround::addNews()
 	 * @see ClosePages::updateNews()
 	 */
-	protected function updateNews( int $amount ) {
+	protected function updateNews ( int $amount ) {
 		$this->getLogger()->info( "Turning $amount pages into votes" );
 		$newsPage = $this->getConfig()->get( 'ric-news-page' );
 
@@ -168,7 +168,7 @@ 
 		$regTac = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 		$regVot = '!(\| *riconferme[ _]voto[ _]amministratori *= *)(\d+)!';
 
-		$tacMatches = $votMatches = [];
+		$tacMatches = $votMatches = [ ];
 		if ( preg_match( $regTac, $content, $tacMatches ) === false ) {
 			throw new TaskException( 'Param "tacite" not found in news page' );
 		}
@@ -176,8 +176,8 @@ 
 			throw new TaskException( 'Param "voto" not found in news page' );
 		}
 
-		$newTac = (int)$tacMatches[2] - $amount ?: '';
-		$newVot = (int)$votMatches[2] + $amount ?: '';
+		$newTac = (int)$tacMatches[ 2 ] - $amount ?: '';
+		$newVot = (int)$votMatches[ 2 ] + $amount ?: '';
 
 		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
 		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );
@@ -189,7 +189,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);

includes/Task/ClosePages.php

Spacing +33 added lines, -34 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task ClosePages' );
 
 		$pages = $this->getPagesList();
@@ -42,12 +42,12 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	protected function getPagesList() : array {
+	protected function getPagesList () : array {
 		$allPages = $this->getDataProvider()->getOpenPages();
-		$ret = [];
+		$ret = [ ];
 		foreach ( $allPages as $page ) {
 			if ( time() > $page->getEndTimestamp() ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -56,7 +56,7 @@ 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	protected function addVoteCloseText( PageRiconferma $page ) {
+	protected function addVoteCloseText ( PageRiconferma $page ) {
 		$content = $page->getContent();
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!';
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -75,14 +75,14 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addToMainPage()
 	 */
-	protected function removeFromMainPage( array $pages ) {
+	protected function removeFromMainPage ( array $pages ) {
 		$this->getLogger()->info(
 			'Removing from main: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
 		$mainPage = $this->getConfig()->get( 'ric-main-page' );
 		$content = $this->getController()->getPageContent( $mainPage );
-		$translations = [];
+		$translations = [ ];
 		foreach ( $pages as $page ) {
 			$translations[ '{{' . $page->getTitle() . '}}' ] = '';
 		}
@@ -100,17 +100,17 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToArchive( array $pages ) {
+	protected function addToArchive ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding to archive: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
-		$simple = $votes = [];
+		$simple = $votes = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
-				$votes[] = $page;
+				$votes[ ] = $page;
 			} else {
-				$simple[] = $page;
+				$simple[ ] = $page;
 			}
 		}
 
@@ -127,21 +127,21 @@ 
 	 * @param string $archiveTitle
 	 * @param array $pages
 	 */
-	private function reallyAddToArchive( string $archiveTitle, array $pages ) {
+	private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
 		$curTitle = "$archiveTitle/" . date( 'Y' );
 
 		$append = '';
-		$archivedList = [];
+		$archivedList = [ ];
 		foreach ( $pages as $page ) {
 			$append .= '{{' . $page->getTitle() . "}}\n";
-			$archivedList[] = $page->getUserNum();
+			$archivedList[ ] = $page->getUserNum();
 		}
 
 		if ( count( $archivedList ) > 1 ) {
 			$last = array_pop( $archivedList );
 			$userNums = implode( ', ', $archivedList ) . " e $last";
 		} else {
-			$userNums = $archivedList[0];
+			$userNums = $archivedList[ 0 ];
 		}
 
 		$summary = strtr(
@@ -162,14 +162,13 @@ 
 	 * @param PageRiconferma $page
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ) {
+	protected function updateBasePage ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		$current = $this->getController()->getPageContent( $page->getBaseTitle() );
 
 		$text = $page->isVote() ?
-			'votazione: ' . ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ? 'non riconfermato' : 'riconfermato' ) :
-			'riconferma tacita';
+			'votazione: ' . ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ? 'non riconfermato' : 'riconfermato' ) : 'riconferma tacita';
 
 		$newContent = str_replace( 'riconferma in corso', $text, $current );
 		$params = [
@@ -185,13 +184,13 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addVote()
 	 */
-	protected function updateVote( array $pages ) {
+	protected function updateVote ( array $pages ) {
 		$votePage = $this->getConfig()->get( 'ric-vote-page' );
 		$content = $this->getController()->getPageContent( $votePage );
 
-		$titles = [];
+		$titles = [ ];
 		foreach ( $pages as $page ) {
-			$titles[] = preg_quote( $page->getTitle() );
+			$titles[ ] = preg_quote( $page->getTitle() );
 		}
 
 		$titleReg = implode( '|', $titles );
@@ -214,7 +213,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -232,7 +231,7 @@ 
 	 * @param array $pages
 	 * @see UpdatesAround::addNews()
 	 */
-	protected function updateNews( array $pages ) {
+	protected function updateNews ( array $pages ) {
 		$simpleAmount = $voteAmount = 0;
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
@@ -249,12 +248,12 @@ 
 		$simpleReg = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 		$voteReg = '!(\| *riconferme[ _]voto[ _]amministratori *= *)(\d+)!';
 
-		$simpleMatches = $voteMatched = [];
+		$simpleMatches = $voteMatched = [ ];
 		preg_match( $simpleReg, $content, $simpleMatches );
 		preg_match( $voteReg, $content, $voteMatches );
 
-		$newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
-		$newVote = (int)$voteMatches[2] - $voteAmount ?: '';
+		$newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
+		$newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $content );
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
 
@@ -265,7 +264,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -284,22 +283,22 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAdminList( array $pages ) {
+	protected function updateAdminList ( array $pages ) {
 		$listTitle = $this->getConfig()->get( 'admins-list' );
 		$newContent = $this->getController()->getPageContent( $listTitle );
 		$newDate = date( 'Ymd', strtotime( '+1 year' ) );
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			$reg = "!(\{\{Amministratore\/riga\|$user.+\| *)\d+( *\|(?: *pausa)? *\}\}\n)!";
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
 				// Remove the line
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user;
+				$removeNames[ ] = $user;
 			} else {
 				$newContent = preg_replace( $reg, '$1' . $newDate . '$2', $newContent );
-				$riconfNames[] = $user;
+				$riconfNames[ ] = $user;
 			}
 		}
 
@@ -308,7 +307,7 @@ 
 			$lastUser = array_pop( $riconfNames );
 			$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
 		} elseif ( $riconfNames ) {
-			$riconfList = $riconfNames[0];
+			$riconfList = $riconfNames[ 0 ];
 		} else {
 			$riconfList = 'nessuno';
 		}
@@ -317,7 +316,7 @@ 
 			$lastUser = array_pop( $removeNames );
 			$removeList = implode( ', ', $removeNames ) . " e $lastUser";
 		} elseif ( $removeNames ) {
-			$removeList = $removeNames[0];
+			$removeList = $removeNames[ 0 ];
 		} else {
 			$removeList = 'nessuno';
 		}