Daimona / BotRiconferme

includes/Task/Subtask/FailedUpdates.php

Spacing +15 added lines, -15 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$failed = $this->getFailures();
 		if ( $failed ) {
 			$this->updateBurList( $failed );
@@ -31,12 +31,12 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	private function getFailures() : array {
-		$ret = [];
+	private function getFailures () : array {
+		$ret = [ ];
 		$allPages = $this->getDataProvider()->getPagesToClose();
 		foreach ( $allPages as $page ) {
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -45,16 +45,16 @@ 
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateBurList( array $pages ) {
+	protected function updateBurList ( array $pages ) {
 		$this->getLogger()->info( 'Checking if bur list needs updating.' );
 
-		$remove = [];
+		$remove = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( $user->inGroup( 'bureaucrat' ) &&
 				( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL )
 			) {
-				$remove[] = $user->getName();
+				$remove[ ] = $user->getName();
 			}
 		}
 
@@ -84,7 +84,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function requestRemoval( array $pages ) {
+	protected function requestRemoval ( array $pages ) {
 		$this->getLogger()->info(
 			'Requesting removal on meta for: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
@@ -122,14 +122,14 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAnnunci( array $pages ) {
+	protected function updateAnnunci ( array $pages ) {
 		$this->getLogger()->info( 'Updating annunci' );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUser()->getName();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= "{{Breve|admin|{{subst:#time:j}}|[[Utente:$user|]] " .
 				"non è stato riconfermato [[WP:A|amministratore]].}}\n";
 		}
@@ -163,16 +163,16 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateUltimeNotizie( array $pages ) {
+	protected function updateUltimeNotizie ( array $pages ) {
 		$this->getLogger()->info( 'Updating ultime notizie' );
 		$notiziePage = new Page( $this->getConfig()->get( 'ultimenotizie-page-title' ) );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUser()->getName();
 			$title = $page->getTitle();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= "'''{{subst:#time:j F}}''': [[Utente:$user|]] non è stato [[$title|riconfermato]] " .
 				'[[WP:A|amministratore]]; ora gli admin sono {{subst:#expr: {{NUMBEROFADMINS}} - 1}}.';
 		}

includes/Wiki/Page/PageRiconferma.php

Spacing +19 added lines, -19 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki\Page;
 
@@ -22,7 +22,7 @@ 
 	/**
 	 * @param string $title
 	 */
-	public function __construct( string $title ) {
+	public function __construct ( string $title ) {
 		parent::__construct( $title );
 		$this->supportSection = $this->isVote() ? 3 : 0;
 		$this->opposeSection = $this->isVote() ? 4 : 3;
@@ -33,8 +33,8 @@ 
 	 *
 	 * @return User
 	 */
-	public function getUser() : User {
-		$name = explode( '/', $this->title )[2];
+	public function getUser () : User {
+		$name = explode( '/', $this->title )[ 2 ];
 		return new User( $name );
 	}
 
@@ -43,7 +43,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getNum() : int {
+	public function getNum () : int {
 		$bits = explode( '/', $this->getTitle() );
 		return intval( end( $bits ) );
 	}
@@ -53,8 +53,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUserNum() : string {
-		return explode( '/', $this->getTitle(), 3 )[2];
+	public function getUserNum () : string {
+		return explode( '/', $this->getTitle(), 3 )[ 2 ];
 	}
 
 	/**
@@ -62,7 +62,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function getBaseTitle() : string {
+	public function getBaseTitle () : string {
 		// @phan-suppress-next-line PhanTypeMismatchArgumentInternal Phan bug
 		return substr( $this->getTitle(), 0, strrpos( $this->getTitle(), '/' ) );
 	}
@@ -72,7 +72,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getOpposingCount() : int {
+	public function getOpposingCount () : int {
 		return $this->getCountForSection( $this->opposeSection );
 	}
 
@@ -82,7 +82,7 @@ 
 	 * @return int
 	 * @throws \BadMethodCallException
 	 */
-	public function getSupportCount() : int {
+	public function getSupportCount () : int {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'Cannot get support for a non-vote page.' );
 		}
@@ -95,7 +95,7 @@ 
 	 * @param int $secNum
 	 * @return int
 	 */
-	protected function getCountForSection( int $secNum ) : int {
+	protected function getCountForSection ( int $secNum ) : int {
 		$content = $this->controller->getPageContent( $this->title, $secNum );
 		// Let's hope that this is good enough...
 		return substr_count( $content, "\n\# *(?![#*])" );
@@ -106,9 +106,9 @@ 
 	 *
 	 * @return int
 	 */
-	protected function getQuorum() : int {
+	protected function getQuorum () : int {
 		$reg = "!soddisfare il \[\[[^|\]]+\|quorum]] di '''(\d+) voti'''!";
-		return intval( $this->getMatch( $reg )[1] );
+		return intval( $this->getMatch( $reg )[ 1 ] );
 	}
 
 	/**
@@ -116,7 +116,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function hasOpposition() : bool {
+	public function hasOpposition () : bool {
 		return $this->getOpposingCount() >= 15;
 	}
 
@@ -126,7 +126,7 @@ 
 	 * @return int One of the OUTCOME_* constants
 	 * @throws \BadMethodCallException
 	 */
-	public function getOutcome() : int {
+	public function getOutcome () : int {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'Cannot get outcome for a non-vote page.' );
 		}
@@ -146,7 +146,7 @@ 
 	 * @throws \BadMethodCallException
 	 * @throws \LogicException
 	 */
-	public function getOutcomeText() : string {
+	public function getOutcomeText () : string {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'No need for an outcome text.' );
 		}
@@ -180,7 +180,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isVote() : bool {
+	public function isVote () : bool {
 		$sectionReg = '/<!-- SEZIONE DA UTILIZZARE PER/';
 		return !$this->matches( $sectionReg );
 	}
@@ -190,7 +190,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getCreationTimestamp() : int {
+	public function getCreationTimestamp () : int {
 		return $this->controller->getPageCreationTS( $this->title );
 	}
 	/**
@@ -198,7 +198,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getEndTimestamp() : int {
+	public function getEndTimestamp () : int {
 		if ( $this->isVote() ) {
 			$reg = "!La votazione ha inizio il.+ e ha termine.+ '''([^']+)''' alle ore '''([^']+)'''!";
 			list( , $day, $hours ) = $this->getMatch( $reg );

includes/TaskDataProvider.php

Spacing +18 added lines, -20 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -15,14 +15,14 @@ 
 	/** @var array[] */
 	private $allUsers;
 	/** @var PageRiconferma[] */
-	private $createdPages = [];
+	private $createdPages = [ ];
 
 	/**
 	 * Get the full content of the JSON users list
 	 *
 	 * @return array[]
 	 */
-	public function getUsersList() : array {
+	public function getUsersList () : array {
 		if ( $this->allUsers === null ) {
 			$this->getLogger()->debug( 'Retrieving users list' );
 			$this->allUsers = PageBotList::get()->getAdminsList();
@@ -36,9 +36,9 @@ 
 	 *
 	 * @return array[]
 	 */
-	public function getUsersToProcess() : array {
+	public function getUsersToProcess () : array {
 		if ( $this->processUsers === null ) {
-			$this->processUsers = [];
+			$this->processUsers = [ ];
 			foreach ( $this->getUsersList() as $user => $groups ) {
 				$timestamp = $this->getValidTimestamp( $groups );
 
@@ -60,13 +60,11 @@ 
 	 * @param array $groups
 	 * @return int
 	 */
-	private function getValidTimestamp( array $groups ) : int {
+	private function getValidTimestamp ( array $groups ) : int {
 		$checkuser = isset( $groups[ 'checkuser' ] ) ?
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() :
-			0;
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() : 0;
 		$bureaucrat = isset( $groups[ 'bureaucrat' ] ) ?
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() :
-			0;
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() : 0;
 
 		$timestamp = max( $bureaucrat, $checkuser );
 		if ( $timestamp === 0 ) {
@@ -80,7 +78,7 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getOpenPages() : array {
+	public function getOpenPages () : array {
 		static $list = null;
 		if ( $list === null ) {
 			$mainTitle = $this->getConfig()->get( 'main-page-title' );
@@ -93,10 +91,10 @@ 
 			];
 
 			$pages = RequestBase::newFromParams( $params )->execute()->query->pages;
-			$list = [];
+			$list = [ ];
 			foreach ( reset( $pages )->templates as $page ) {
 				if ( preg_match( "!$mainTitle\/[^\/]+\/\d!", $page->title ) ) {
-					$list[] = new PageRiconferma( $page->title );
+					$list[ ] = new PageRiconferma( $page->title );
 				}
 			}
 		}
@@ -109,14 +107,14 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getPagesToClose() : array {
+	public function getPagesToClose () : array {
 		static $list = null;
 		if ( $list === null ) {
 			$allPages = $this->getOpenPages();
-			$list = [];
+			$list = [ ];
 			foreach ( $allPages as $page ) {
 				if ( time() > $page->getEndTimestamp() ) {
-					$list[] = $page;
+					$list[ ] = $page;
 				}
 			}
 		}
@@ -128,21 +126,21 @@ 
 	 *
 	 * @param string $name
 	 */
-	public function removeUser( string $name ) {
+	public function removeUser ( string $name ) {
 		unset( $this->processUsers[ $name ] );
 	}
 
 	/**
 	 * @return PageRiconferma[]
 	 */
-	public function getCreatedPages() : array {
+	public function getCreatedPages () : array {
 		return $this->createdPages;
 	}
 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	public function addCreatedPages( PageRiconferma $page ) {
-		$this->createdPages[] = $page;
+	public function addCreatedPages ( PageRiconferma $page ) {
+		$this->createdPages[ ] = $page;
 	}
 }