Daimona / BotRiconferme

src/Request/RequestBase.php

Spacing +25 added lines, -25 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Request;
 
@@ -41,7 +41,7 @@ 
 	/** @var string */
 	protected $method = self::METHOD_GET;
 	/** @var string[] */
-	protected $newCookies = [];
+	protected $newCookies = [ ];
 	/** @var callable|null */
 	private $cookiesHandlerCallback;
 
@@ -57,7 +57,7 @@ 
 	 * @param string $domain
 	 * @param callable $cookiesHandlerCallback
 	 */
-	public function __construct(
+	public function __construct (
 		LoggerInterface $logger,
 		array $params,
 		string $domain,
@@ -74,7 +74,7 @@ 
 	 *
 	 * @return self For chaining
 	 */
-	public function setPost(): self {
+	public function setPost (): self {
 		$this->method = self::METHOD_POST;
 		return $this;
 	}
@@ -83,7 +83,7 @@ 
 	 * @param string[] $cookies
 	 * @return self For chaining
 	 */
-	public function setCookies( array $cookies ): self {
+	public function setCookies ( array $cookies ): self {
 		$this->cookiesToSet = $cookies;
 		return $this;
 	}
@@ -92,12 +92,12 @@ 
 	 * Execute a query request
 	 * @return Generator
 	 */
-	public function executeAsQuery(): Generator {
-		if ( ( $this->params['action'] ?? false ) !== 'query' ) {
+	public function executeAsQuery (): Generator {
+		if ( ( $this->params[ 'action' ] ?? false ) !== 'query' ) {
 			throw new BadMethodCallException( 'Not an ApiQuery!' );
 		}
 		// TODO Is this always correct?
-		$key = $this->params['list'] ?? 'pages';
+		$key = $this->params[ 'list' ] ?? 'pages';
 		$curParams = $this->params;
 		$lim = $this->parseLimit();
 		do {
@@ -126,7 +126,7 @@ 
 	 * Execute a request that doesn't need any continuation.
 	 * @return stdClass
 	 */
-	public function executeSingle(): stdClass {
+	public function executeSingle (): stdClass {
 		$curParams = $this->params;
 		$res = $this->makeRequestInternal( $curParams );
 		$this->handleErrorAndWarnings( $res );
@@ -136,7 +136,7 @@ 
 	/**
 	 * @return int
 	 */
-	private function parseLimit(): int {
+	private function parseLimit (): int {
 		foreach ( $this->params as $name => $val ) {
 			if ( substr( $name, -strlen( 'limit' ) ) === 'limit' ) {
 				return $val === 'max' ? -1 : (int)$val;
@@ -153,7 +153,7 @@ 
 	 * @param string $resKey
 	 * @return int|null
 	 */
-	private function countQueryResults( stdClass $res, string $resKey ): ?int {
+	private function countQueryResults ( stdClass $res, string $resKey ): ?int {
 		if ( !isset( $res->query->$resKey ) ) {
 			return null;
 		}
@@ -181,9 +181,9 @@ 
 	 * @phan-param array<int|string|bool> $params
 	 * @return stdClass
 	 */
-	private function makeRequestInternal( array $params ): stdClass {
+	private function makeRequestInternal ( array $params ): stdClass {
 		if ( $this->method === self::METHOD_POST ) {
-			$params['maxlag'] = self::MAXLAG;
+			$params[ 'maxlag' ] = self::MAXLAG;
 		}
 		$query = http_build_query( $params );
 
@@ -203,10 +203,10 @@ 
 	 *
 	 * @param string $cookie "{key}={value}"
 	 */
-	protected function saveNewCookie( string $cookie ): void {
+	protected function saveNewCookie ( string $cookie ): void {
 		$bits = explode( ';', $cookie );
-		[ $name, $value ] = explode( '=', $bits[0] );
-		$this->newCookies[$name] = $value;
+		[ $name, $value ] = explode( '=', $bits[ 0 ] );
+		$this->newCookies[ $name ] = $value;
 	}
 
 	/**
@@ -215,7 +215,7 @@ 
 	 * @param string $params
 	 * @return string
 	 */
-	abstract protected function reallyMakeRequest( string $params ): string;
+	abstract protected function reallyMakeRequest ( string $params ): string;
 
 	/**
 	 * Get a specific exception class depending on the error code
@@ -223,7 +223,7 @@ 
 	 * @param stdClass $res
 	 * @return APIRequestException
 	 */
-	private function getException( stdClass $res ): APIRequestException {
+	private function getException ( stdClass $res ): APIRequestException {
 		switch ( $res->error->code ) {
 			case 'missingtitle':
 				$ex = new MissingPageException;
@@ -249,7 +249,7 @@ 
 	 * @param stdClass $res
 	 * @throws APIRequestException
 	 */
-	protected function handleErrorAndWarnings( stdClass $res ): void {
+	protected function handleErrorAndWarnings ( stdClass $res ): void {
 		if ( isset( $res->error ) ) {
 			throw $this->getException( $res );
 		}
@@ -265,14 +265,14 @@ 
 	 *
 	 * @return string[]
 	 */
-	protected function getHeaders(): array {
+	protected function getHeaders (): array {
 		$ret = self::HEADERS;
 		if ( $this->cookiesToSet ) {
-			$cookies = [];
+			$cookies = [ ];
 			foreach ( $this->cookiesToSet as $cname => $cval ) {
-				$cookies[] = trim( "$cname=$cval" );
+				$cookies[ ] = trim( "$cname=$cval" );
 			}
-			$ret[] = 'Cookie: ' . implode( '; ', $cookies );
+			$ret[ ] = 'Cookie: ' . implode( '; ', $cookies );
 		}
 		return $ret;
 	}
@@ -283,7 +283,7 @@ 
 	 * @param string[] $headers
 	 * @return string
 	 */
-	protected function buildHeadersString( array $headers ): string {
+	protected function buildHeadersString ( array $headers ): string {
 		$ret = '';
 		foreach ( $headers as $header ) {
 			$ret .= "$header\r\n";
@@ -295,7 +295,7 @@ 
 	 * @param string $actualParams
 	 * @return string
 	 */
-	protected function getDebugURL( string $actualParams ): string {
+	protected function getDebugURL ( string $actualParams ): string {
 		return strpos( $this->url, 'login' ) !== false
 			? '[Login request]'
 			: "{$this->url}?$actualParams";