CrossKnowledge / DataTableBundle

DataTable/Table/Element/Column/Column.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         return $this;
     }
     /**
-     * @return mixed
+     * @return string
      */
     public function getOptions()
     {

Spacing +4 added lines, -4 removed lines

@@ -14,7 +14,7 @@ 
      * @var array
      */
     public static $clientSideColumnOptions = [
-        'cellType','className','contentPadding', 'createdCell', 'data', 'defaultContent', 'name', 'orderable',
+        'cellType', 'className', 'contentPadding', 'createdCell', 'data', 'defaultContent', 'name', 'orderable',
         'orderData', 'orderDataType', 'render', 'searchable', 'title', 'type', 'visible', 'width'
     ];
 
@@ -33,7 +33,7 @@ 
      */
     protected $formatValueCallback;
 
-    public function __construct($title='', $options=[])
+    public function __construct($title = '', $options = [])
     {
         $this->optionsResolver = new OptionsResolver();
         $this->configureOptions($this->optionsResolver);
@@ -92,7 +92,7 @@ 
     {
         if (is_callable($this->formatValueCallback)) {
             return call_user_func_array($this->formatValueCallback, [$value, $rowData]);
-        } else{
+        } else {
             return $value;
         }
     }
@@ -106,7 +106,7 @@ 
     /**
      * @param \Closure $callback
      */
-    public function setFormatValueCallback(\Closure $callback=null)
+    public function setFormatValueCallback(\Closure $callback = null)
     {
         $this->formatValueCallback = $callback;
         return $this;

Tests/UsesContainerTrait.php

Unused Use Statements -2 removed lines

@@ -5,9 +5,7 @@
 use CrossKnowledge\DataTableBundle\DataTable\Table\AbstractTable;
 use CrossKnowledge\DataTableBundle\DependencyInjection\Compiler\DatatablePass;
 use CrossKnowledge\DataTableBundle\DependencyInjection\CrossKnowledgeDataTableExtension;
-use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\Definition;
 
 trait UsesContainerTrait
 {

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 
 trait UsesContainerTrait
 {
-    protected function compileContainer(ContainerBuilder $container, $loadExt=true)
+    protected function compileContainer(ContainerBuilder $container, $loadExt = true)
     {
         if ($loadExt) {
             $extension = new CrossKnowledgeDataTableExtension();

DataTable/Renderer/JsonRenderer.php

Spacing +2 added lines, -2 removed lines

@@ -12,13 +12,13 @@
         $viewVars = $table->buildView();
         $jsonVars = [];
         $jsonVars['recordsTotal'] = $viewVars['unfilteredRowsCount'];
-        if ($viewVars['filteredRowsCount']!==false) {
+        if ($viewVars['filteredRowsCount'] !== false) {
             $jsonVars['recordsFiltered'] = $viewVars['filteredRowsCount'];
         } else {
             $jsonVars['recordsFiltered'] = $viewVars['unfilteredRowsCount'];
         }
         $jsonVars['data'] = array_map(
-            function ($item) {
+            function($item) {
                 $t = [];
                 foreach ($item as $k => $v) {
                     $t[] = $v;

DataTable/Table/Element/Column/Link.php

Spacing +2 added lines, -2 removed lines

@@ -11,10 +11,10 @@
     {
         parent::configureOptions($resolver);
         $resolver->setRequired('LinkTextField');
-        $resolver->setDefault('AltTextField', function (Options $options) {
+        $resolver->setDefault('AltTextField', function(Options $options) {
             return $options['LinkTextField'];
         });
-        $resolver->setDefault('UrlField', function (Options $options) {
+        $resolver->setDefault('UrlField', function(Options $options) {
             return $options['LinkTextField'];
         });
         $resolver->setDefault('UrlCallback', function($value, $row) {

Doc Comments +1 added lines

@@ -24,6 +24,7 @@
     }
     /**
      * Build a link
+     * @param string $value
      */
     public function formatCell($value, array $rowData, $context)
     {

Tests/DataTable/ColumnBuilderTest.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
     {
         $builder = new ColumnBuilder();
 
-        for ($i=0;$i<3;$i++) {
+        for ($i = 0; $i<3; $i++) {
             $builder->add("testcolumn".$i, new Column("test column ".$i));
         }
 

Tests/DataTable/Column/ColumnTest.php

Indentation +2 added lines, -2 removed lines

@@ -28,10 +28,10 @@
     public function testBasicGetterSetter()
     {
         $column = (new Column("test", ['auto_escape' => false]))
-                   ->setFormatValueCallback(function() {
+                    ->setFormatValueCallback(function() {
                         return 'test ok';
                     })
-                   ->setIdentifier('test');
+                    ->setIdentifier('test');
 
         $this->assertEquals("test", $column->getOptions()['title']);
         $this->assertEquals("test ok", call_user_func($column->getFormatValueCallback()));

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
     public function testFormatCellUsesCallback()
     {
         $column = new Column("test");
-        $column->setFormatValueCallback(function($val, $row){
+        $column->setFormatValueCallback(function($val, $row) {
             return $val.'ok';
         });
 

Tests/DataTable/Renderer/TwigRendererTest.php

Indentation +3 added lines, -3 removed lines

@@ -20,11 +20,11 @@
                     ->getMock();
 
         $templateMock = $this->getMockBuilder(\Twig_TemplateInterface::class)
-                             ->disableOriginalConstructor()
-                             ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
 
         $twig->expects($this->once())->method('loadTemplate')
-             ->will($this->returnValue($templateMock));
+                ->will($this->returnValue($templateMock));
 
         $renderer = new TwigRenderer($twig);
         $renderer->render($mock);

Tests/DataTable/RegistryTest.php

Indentation +2 added lines, -2 removed lines

@@ -12,8 +12,8 @@
     public function testRetrieveTableById()
     {
         $table = $this->getMockBuilder(AbstractTable::class)
-                      ->disableOriginalConstructor()
-                      ->getMock();
+                        ->disableOriginalConstructor()
+                        ->getMock();
 
         $registry = new DataTableRegistry(['test' => $table]);
         $this->assertEquals($table, $registry->retrieveByTableId('test'));

Tests/DataTable/Table/AbstractTableTest.php

Indentation +27 added lines, -27 removed lines

@@ -20,12 +20,12 @@ 
     protected function getTableMock($cols, $rows)
     {
         $formFactory = $this->getMockBuilder(FormFactory::class)
-                             ->disableOriginalConstructor()
-                             ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
 
         $form = $this->getMockBuilder('Symfony\Component\Form\Form')
-                     ->disableOriginalConstructor()
-                     ->getMock();
+                        ->disableOriginalConstructor()
+                        ->getMock();
 
         $authChecker = $this->getMockBuilder(AuthorizationChecker::class)
                             ->disableOriginalConstructor()
@@ -39,20 +39,20 @@ 
         $layout    = new Bootstrap();
 
         $mock = $this->getMockBuilder(AbstractTable::class)
-                     ->setConstructorArgs([
-                         $formFactory, $authChecker,
-                         $router, $formatter, $layout
-                     ])
-                     ->setMethods(['getColumns', 'getFilterForm'])
-                     ->getMockForAbstractClass();
+                        ->setConstructorArgs([
+                            $formFactory, $authChecker,
+                            $router, $formatter, $layout
+                        ])
+                        ->setMethods(['getColumns', 'getFilterForm'])
+                        ->getMockForAbstractClass();
 
         $mock->expects($this->any())
             ->method('getDataIterator')
             ->will($this->returnValue($rows));
 
         $mock->expects($this->any())
-             ->method('getColumns')
-             ->will($this->returnValue($cols));
+                ->method('getColumns')
+                ->will($this->returnValue($cols));
 
         $mock->expects($this->any())
             ->method('getFilterForm')
@@ -72,7 +72,7 @@ 
 
         $filterForm = $table->getFilterForm();
         $filterForm->expects($this->never())
-                   ->method('createView');
+                    ->method('createView');
 
         $viewData = $table->buildView();
         $this->assertEquals($viewData['datatable'], $table);
@@ -85,7 +85,7 @@ 
 
         $filterForm = $table->getFilterForm();
         $filterForm->expects($this->once())
-                   ->method('createView');
+                    ->method('createView');
         $table->buildView();
     }
     /**
@@ -97,7 +97,7 @@ 
         $table->setOptions(['has_filter_form' => false]);
         $filterForm = $table->getFilterForm();
         $filterForm->expects($this->never())
-                   ->method('createView');
+                    ->method('createView');
 
         $table->buildView();
 
@@ -106,7 +106,7 @@ 
 
         $filterForm = $table->getFilterForm();
         $filterForm->expects($this->once())
-                   ->method('createView');
+                    ->method('createView');
         $table->buildView();
     }
     /**
@@ -131,17 +131,17 @@ 
     public function buildViewProvider()
     {
         return [
-          [
-              [
-                  'firstCol' => new Column('title 1st col'),
-                  'secondCol' => new Column('title 2nd col')
-              ],
-              [
-                  ['firstCol' => 'row1column1value', 'secondCol' => 'row2column2value'],
-                  ['firstCol' => 'row2column1value', 'secondCol' => 'row2column2value']
-              ],
-              2
-          ]
+            [
+                [
+                    'firstCol' => new Column('title 1st col'),
+                    'secondCol' => new Column('title 2nd col')
+                ],
+                [
+                    ['firstCol' => 'row1column1value', 'secondCol' => 'row2column2value'],
+                    ['firstCol' => 'row2column1value', 'secondCol' => 'row2column2value']
+                ],
+                2
+            ]
         ];
     }
 }
\ No newline at end of file