CraftLogan\LaravelOverflow\LaravelOverflow::__construct()

Complexity

Conditions	1
Paths	1

Size

Total Lines

6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function __construct(Request $request, Model $model, $overflow_column = "properties")

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
        $this->model = $model;
        $this->overflow_column = $overflow_column;
    }