CraftLogan\LaravelOverflow\LaravelOverflow

Complexity

Total Complexity

1

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1

<?php

namespace CraftLogan\LaravelOverflow;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Http\Request;
use CraftLogan\LaravelOverflow\Overflowable;

class LaravelOverflow
{
    use Overflowable;

    protected $model;
    protected $overflow_column;
    protected $request;

    public function __construct(Request $request, Model $model, $overflow_column = "properties")

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
        $this->model = $model;
        $this->overflow_column = $overflow_column;
    }

}