View GitHub Repository Formularium

Schedule Inspection
Subscribe
Passed
Pull Request — master (#37)
by Bruno
07:17
created
Status
Category
Toggle Patches
Formularium/Frontend/Vue/Vue2CodeClassTypescriptRenderer.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -24,7 +24,7 @@  discard block
 
 block discarded – undo
24 24 
      */
25 25 
     protected function serializeProps(array $props): string
26 26 
     {
27 
-        $s = array_map(function ($p) {
27 
+        $s = array_map(function($p) {
28 28 
             return "'{$p['name']}': { 'type': {$p['type']}" . ($p['required'] ?? false ? ", 'required': true" : '') . " } ";
29 29 
         }, $props);
30 30 
         return "{\n        " . implode(",\n        ", $s) . "\n    }";
 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36 
         $props = $this->vueCode->props($m);
37 37 
         // get only props names
38 38 
         $propsNames = array_map(
39 
-            function (Prop $p) {
39 
+            function(Prop $p) {
40 40 
                 return $p->name;
41 41 
             },
42 42 
             $props
 
@@ -67,7 +67,7 @@  discard block
 
 block discarded – undo
67 67 
             'propsCode' => implode(
68 68 
                 "\n",
69 69 
                 array_map(
70 
-                    function (Prop $p) {
70 
+                    function(Prop $p) {
71 71 
                         return $p->toDecorator();
72 72 
                     },
73 73 
                     $props
 
@@ -76,7 +76,7 @@  discard block
 
 block discarded – undo
76 76 
             'propsBind' => implode(
77 77 
                 ' ',
78 78 
                 array_map(
79 
-                    function (Prop $p) {
79 
+                    function(Prop $p) {
80 80 
                         return $p->toBind();
81 81 
                     },
82 82 
                     $props
 
@@ -84,14 +84,14 @@  discard block
 
 block discarded – undo
84 84 
             ),
85 85 
             'imports' => implode(
86 86 
                 "\n",
87 
-                array_map(function ($key, $value) {
87 
+                array_map(function($key, $value) {
88 88 
                     return "import $key from \"$value\";";
89 89 
                 }, array_keys($this->vueCode->imports), $this->vueCode->imports)
90 90 
             ),
91 91 
             'computedCode' => implode(
92 92 
                 "\n",
93 93 
                 array_map(
94 
-                    function (Computed $c) {
94 
+                    function(Computed $c) {
95 95 
                         return $c->toGetter();
96 96 
                     },
97 97 
                     $this->vueCode->computed
 
@@ -103,7 +103,7 @@  discard block
 
 block discarded – undo
103 103 
             ),
104 104 
             'methodsCode' => implode(
105 105 
                 "\n",
106 
-                array_map(function ($key, $value) {
106 
+                array_map(function($key, $value) {
107 107 
                     return "$key { $value }";
108 108 
                 }, array_keys($this->vueCode->methods), $this->vueCode->methods)
109 109 
             ),
Please login to merge, or discard this patch.
Formularium/Frontend/Vue/VueCode.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -25,12 +25,11 @@
 
 block discarded – undo
25 25 
  */
26 26 
 function expandJS(array $data): array
27 27 
 {
28 
-    return array_map(function ($key, $value) {
28 
+    return array_map(function($key, $value) {
29 29 
         return "$key" .
30 30 
             (
31 31 
                 is_array($value) ?
32 
-                ': {' . implode(",\n", expandJS($value)) . '}' :
33 
-                ($value ? ':' . $value : '')
32 
+                ': {' . implode(",\n", expandJS($value)) . '}' : ($value ? ':' . $value : '')
34 33 
             );
35 34 
     }, array_keys($data), $data);
36 35 
 }
Please login to merge, or discard this patch.
Formularium/Frontend/Vue/VueCode/Prop.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -70,7 +70,7 @@
 
 block discarded – undo
70 70 
             $options["default"] =  $this->default;
71 71 
         }
72 72 
         return "@Prop(" .
73 
-             ($options ? json_encode($options, JSON_PRETTY_PRINT) : '{}') .
73 
+                ($options ? json_encode($options, JSON_PRETTY_PRINT) : '{}') .
74 74 
             ') readonly ' .
75 75 
             $this->name .
76 76 
             ($this->required ? '!' : '') .
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -46,7 +46,7 @@  discard block
 
 block discarded – undo
46 46 
     public function toStruct(): string
47 47 
     {
48 48 
         $t = VueCode::mapTypeToJS($this->type);
49 
-        return "\"{$this->name}\": {\n".
49 
+        return "\"{$this->name}\": {\n" .
50 50 
             "  type: {$t}" .
51 51 
             ($this->required ?? false ? ", required: true" : '') .
52 52 
             ($this->default ?? false ? ", default: " . $this->default : '') .
 
@@ -67,7 +67,7 @@  discard block
 
 block discarded – undo
67 67 
         $t = VueCode::mapTypeToJS($this->type);
68 68 
         $options = [];
69 69 
         if ($this->default) {
70 
-            $options["default"] =  $this->default;
70 
+            $options["default"] = $this->default;
71 71 
         }
72 72 
         return "@Prop(" .
73 73 
              ($options ? json_encode($options, JSON_PRETTY_PRINT) : '{}') .
Please login to merge, or discard this patch.
Formularium/Frontend/Vue/Vue2CodeDictRenderer.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -28,7 +28,7 @@  discard block
 
 block discarded – undo
28 28 
         $props = $this->vueCode->props($m);
29 29 
         // get only props names
30 30 
         $propsNames = array_map(
31 
-            function ($p) {
31 
+            function($p) {
32 32 
                 return $p->name;
33 33 
             },
34 34 
             $props
 
@@ -39,7 +39,7 @@  discard block
 
 block discarded – undo
39 39 
         $propsNames = array_combine($propsNames, $propsNames);
40 40 
         // get the binding
41 41 
         $propsBind = array_map(
42 
-            function (Prop $p) {
42 
+            function(Prop $p) {
43 43 
                 return $p->toBind();
44 44 
             },
45 45 
             $props
 
@@ -64,21 +64,21 @@  discard block
 
 block discarded – undo
64 64 
             'jsonData' => $jsonData,
65 65 
             'propsCode' => implode(
66 66 
                 "\n",
67 
-                array_map(function (Prop $p) {
67 
+                array_map(function(Prop $p) {
68 68 
                     return $p->toStruct();
69 69 
                 }, $props)
70 70 
             ),
71 71 
             'propsBind' => implode(' ', $propsBind),
72 72 
             'imports' => implode(
73 73 
                 "\n",
74 
-                array_map(function ($key, $value) {
74 
+                array_map(function($key, $value) {
75 75 
                     return "import $key from \"$value\";";
76 76 
                 }, array_keys($this->vueCode->imports), $this->vueCode->imports)
77 77 
             ),
78 78 
             'computedCode' => implode(
79 79 
                 "\n",
80 80 
                 array_map(
81 
-                    function (Computed $c) {
81 
+                    function(Computed $c) {
82 82 
                         return $c->toStruct();
83 83 
                     },
84 84 
                     $this->vueCode->computed
 
@@ -90,7 +90,7 @@  discard block
 
 block discarded – undo
90 90 
             ),
91 91 
             'methodsCode' => implode(
92 92 
                 "\n",
93 
-                array_map(function ($key, $value) {
93 
+                array_map(function($key, $value) {
94 94 
                     return "$key { $value },";
95 95 
                 }, array_keys($this->vueCode->methods), $this->vueCode->methods)
96 96 
             ),
Please login to merge, or discard this patch.