Inspection of "Update" - ControleOnline/api-platform-products - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 97e6ad...1483a3 )

by Luiz Kim

created 2025-04-09 23:36 UTC

Status

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -29,17 +29,17 @@  discard block
 block discarded – undo
 #[ApiResource(
     operations: [
         new Get(security: 'is_granted(\'IS_AUTHENTICATED_ANONYMOUSLY\')'),
-        new Put(security: 'is_granted(\'ROLE_CLIENT\')', denormalizationContext: ['groups' => ['product:write']]),
+        new Put(security: 'is_granted(\'ROLE_CLIENT\')', denormalizationContext: [ 'groups' => [ 'product:write' ] ]),
         new Delete(security: 'is_granted(\'ROLE_CLIENT\')'),
         new Post(securityPostDenormalize: 'is_granted(\'ROLE_CLIENT\')'),
         new GetCollection(security: 'is_granted(\'IS_AUTHENTICATED_ANONYMOUSLY\')'),
     ],
-    formats: ['jsonld', 'json', 'html', 'jsonhal', 'csv' => ['text/csv']],
-    normalizationContext: ['groups' => ['product:read']],
-    denormalizationContext: ['groups' => ['product:write']]
-)]
-#[ApiFilter(OrderFilter::class, properties: ['product', 'price', 'description'])]
-#[ApiFilter(RandomOrderFilter::class)]
+    formats: [ 'jsonld', 'json', 'html', 'jsonhal', 'csv' => [ 'text/csv' ] ],
+    normalizationContext: [ 'groups' => [ 'product:read' ] ],
+    denormalizationContext: [ 'groups' => [ 'product:write' ] ]
+) ]
+#[ApiFilter(OrderFilter::class, properties: [ 'product', 'price', 'description' ]) ]
+#[ApiFilter(RandomOrderFilter::class) ]
 class Product
 {
     /**
@@ -49,28 +49,28 @@  discard block
 block discarded – undo
      * @ORM\GeneratedValue(strategy="IDENTITY")
      * @Groups({"product_category:read","product:read","order_product:read"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['id' => 'exact'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'id' => 'exact' ]) ]
     private $id;
 
     /**
      * @ORM\Column(name="product", type="string", length=255, nullable=true)
      * @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['product' => 'partial'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'product' => 'partial' ]) ]
     private $product;
 
     /**
      * @ORM\OneToMany(targetEntity="ProductFile", mappedBy="product")
      * @Groups({"product:read","product_category:read","order_product:read"})
      */
-    #[ApiFilter(filterClass: ExistsFilter::class, properties: ['productFiles'])]
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['productFiles.file.fileType' => 'exact'])]
+    #[ApiFilter(filterClass: ExistsFilter::class, properties: [ 'productFiles' ]) ]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'productFiles.file.fileType' => 'exact' ]) ]
     private $productFiles;
 
     /**
      * @ORM\OneToMany(targetEntity="ProductCategory", mappedBy="product")
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['productCategory.category' => 'exact'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'productCategory.category' => 'exact' ]) ]
     private $productCategory;
 
     /**
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
      * @ORM\Column(name="sku", type="string", length=32, nullable=true, options={"default"="NULL"})
      * @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['sku' => 'partial'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'sku' => 'partial' ]) ]
     private $sku = null;
 
     /**
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
      * @ORM\Column(name="type", type="string", length=0, nullable=false, options={"default"="'product'"})
      * @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['type' => 'exact'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'type' => 'exact' ]) ]
     private $type = 'product';
 
     /**
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
      * @ORM\Column(name="product_condition", type="string", length=0, nullable=false, options={"default"="'new'"})
      * @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['productCondition' => 'exact'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'productCondition' => 'exact' ]) ]
     private $productCondition = 'new';
 
     /**
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
      * @ORM\Column(name="featured", type="boolean", nullable=false, options={"default"="0"})
      * @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['featured' => 'exact'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'featured' => 'exact' ]) ]
     private $featured = false;
 
     /**
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
      * @ORM\Column(name="active", type="boolean", nullable=false, options={"default"="1"})
      * @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['active' => 'exact'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'active' => 'exact' ]) ]
     private $active = true;
 
     /**
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
      * })
      * @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['company' => 'exact'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'company' => 'exact' ]) ]
     private $company;
 
     /**
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
      * })
      * @Groups({"product:read", "product:write"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['defaultOutInventory' => 'exact'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'defaultOutInventory' => 'exact' ]) ]
     private $defaultOutInventory;
 
     /**
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
      * })
      * @Groups({"product:read", "product:write"})
      */
-    #[ApiFilter(filterClass: SearchFilter::class, properties: ['defaultInInventory' => 'exact'])]
+    #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'defaultInInventory' => 'exact' ]) ]
     private $defaultInInventory;
 
     public function __construct()

Please login to merge, or discard this patch.

		@@ -29,17 +29,17 @@ discard block
		block discarded – undo
29	29	#[ApiResource(
30	30	operations: [
31	31	new Get(security: 'is_granted(\'IS_AUTHENTICATED_ANONYMOUSLY\')'),
32		- new Put(security: 'is_granted(\'ROLE_CLIENT\')', denormalizationContext: ['groups' => ['product:write']]),
	32	+ new Put(security: 'is_granted(\'ROLE_CLIENT\')', denormalizationContext: [ 'groups' => [ 'product:write' ] ]),
33	33	new Delete(security: 'is_granted(\'ROLE_CLIENT\')'),
34	34	new Post(securityPostDenormalize: 'is_granted(\'ROLE_CLIENT\')'),
35	35	new GetCollection(security: 'is_granted(\'IS_AUTHENTICATED_ANONYMOUSLY\')'),
36	36	],
37		- formats: ['jsonld', 'json', 'html', 'jsonhal', 'csv' => ['text/csv']],
38		- normalizationContext: ['groups' => ['product:read']],
39		- denormalizationContext: ['groups' => ['product:write']]
40		-)]
41		-#[ApiFilter(OrderFilter::class, properties: ['product', 'price', 'description'])]
42		-#[ApiFilter(RandomOrderFilter::class)]
	37	+ formats: [ 'jsonld', 'json', 'html', 'jsonhal', 'csv' => [ 'text/csv' ] ],
	38	+ normalizationContext: [ 'groups' => [ 'product:read' ] ],
	39	+ denormalizationContext: [ 'groups' => [ 'product:write' ] ]
	40	+) ]
	41	+#[ApiFilter(OrderFilter::class, properties: [ 'product', 'price', 'description' ]) ]
	42	+#[ApiFilter(RandomOrderFilter::class) ]
43	43	class Product
44	44	{
45	45	/**
		@@ -49,28 +49,28 @@ discard block
		block discarded – undo
49	49	* @ORM\GeneratedValue(strategy="IDENTITY")
50	50	* @Groups({"product_category:read","product:read","order_product:read"})
51	51	*/
52		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['id' => 'exact'])]
	52	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'id' => 'exact' ]) ]
53	53	private $id;
54	54
55	55	/**
56	56	* @ORM\Column(name="product", type="string", length=255, nullable=true)
57	57	* @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
58	58	*/
59		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['product' => 'partial'])]
	59	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'product' => 'partial' ]) ]
60	60	private $product;
61	61
62	62	/**
63	63	* @ORM\OneToMany(targetEntity="ProductFile", mappedBy="product")
64	64	* @Groups({"product:read","product_category:read","order_product:read"})
65	65	*/
66		- #[ApiFilter(filterClass: ExistsFilter::class, properties: ['productFiles'])]
67		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['productFiles.file.fileType' => 'exact'])]
	66	+ #[ApiFilter(filterClass: ExistsFilter::class, properties: [ 'productFiles' ]) ]
	67	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'productFiles.file.fileType' => 'exact' ]) ]
68	68	private $productFiles;
69	69
70	70	/**
71	71	* @ORM\OneToMany(targetEntity="ProductCategory", mappedBy="product")
72	72	*/
73		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['productCategory.category' => 'exact'])]
	73	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'productCategory.category' => 'exact' ]) ]
74	74	private $productCategory;
75	75
76	76	/**
		@@ -78,7 +78,7 @@ discard block
		block discarded – undo
78	78	* @ORM\Column(name="sku", type="string", length=32, nullable=true, options={"default"="NULL"})
79	79	* @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
80	80	*/
81		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['sku' => 'partial'])]
	81	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'sku' => 'partial' ]) ]
82	82	private $sku = null;
83	83
84	84	/**
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	* @ORM\Column(name="type", type="string", length=0, nullable=false, options={"default"="'product'"})
87	87	* @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
88	88	*/
89		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['type' => 'exact'])]
	89	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'type' => 'exact' ]) ]
90	90	private $type = 'product';
91	91
92	92	/**
		@@ -101,7 +101,7 @@ discard block
		block discarded – undo
101	101	* @ORM\Column(name="product_condition", type="string", length=0, nullable=false, options={"default"="'new'"})
102	102	* @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
103	103	*/
104		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['productCondition' => 'exact'])]
	104	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'productCondition' => 'exact' ]) ]
105	105	private $productCondition = 'new';
106	106
107	107	/**
		@@ -116,7 +116,7 @@ discard block
		block discarded – undo
116	116	* @ORM\Column(name="featured", type="boolean", nullable=false, options={"default"="0"})
117	117	* @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
118	118	*/
119		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['featured' => 'exact'])]
	119	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'featured' => 'exact' ]) ]
120	120	private $featured = false;
121	121
122	122	/**
		@@ -124,7 +124,7 @@ discard block
		block discarded – undo
124	124	* @ORM\Column(name="active", type="boolean", nullable=false, options={"default"="1"})
125	125	* @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
126	126	*/
127		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['active' => 'exact'])]
	127	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'active' => 'exact' ]) ]
128	128	private $active = true;
129	129
130	130	/**
		@@ -135,7 +135,7 @@ discard block
		block discarded – undo
135	135	* })
136	136	* @Groups({"product_category:read","product:read","product_group_product:read","order_product:read","order_product_queue:read","order:read","order_details:read","order:write","product:write"})
137	137	*/
138		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['company' => 'exact'])]
	138	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'company' => 'exact' ]) ]
139	139	private $company;
140	140
141	141	/**
		@@ -166,7 +166,7 @@ discard block
		block discarded – undo
166	166	* })
167	167	* @Groups({"product:read", "product:write"})
168	168	*/
169		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['defaultOutInventory' => 'exact'])]
	169	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'defaultOutInventory' => 'exact' ]) ]
170	170	private $defaultOutInventory;
171	171
172	172	/**
		@@ -177,7 +177,7 @@ discard block
		block discarded – undo
177	177	* })
178	178	* @Groups({"product:read", "product:write"})
179	179	*/
180		- #[ApiFilter(filterClass: SearchFilter::class, properties: ['defaultInInventory' => 'exact'])]
	180	+ #[ApiFilter(filterClass: SearchFilter::class, properties: [ 'defaultInInventory' => 'exact' ]) ]
181	181	private $defaultInInventory;
182	182
183	183	public function __construct()

ControleOnline / api-platform-products

Push — master ( 97e6ad...1483a3 )

Status

Category

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch