View GitHub Repository BiCoreBundle

Schedule Inspection
Subscribe
Passed
Push — master ( 1e8655...fbfe4b )
by Andrea
17:02
created

checkCampoOpzioniTabella()   A

↳ Parent: TabellaOpzioniFromModelloColonneTrait

Complexity

Conditions 4
Paths 3

Size

Total Lines 10
Code Lines 7

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 2
CRAP Score 9.8312

Importance

Changes 0
Metric Value
cc 4
eloc 7
nc 3
nop 3
dl 0
loc 10
ccs 2
cts 7
cp 0.2857
crap 9.8312
rs 10
c 0
b 0
f 0
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Cdf\BiCoreBundle\Utils\Tabella;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
trait TabellaOpzioniFromModelloColonneTrait

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                             12                         
                
                
                
    protected function setOpzioniTabellaFromModellocolonne(&$opzionibuilder)

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                             12                         
                
                
                
        foreach ($this->modellocolonne as $modellocolonna) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                             4                         
                
                
                
            $campo = $this->bonificaNomeCampo($modellocolonna['nomecampo']);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
It seems like bonificaNomeCampo() must be provided by classes using this trait. How about adding it as abstract method to this trait?
                                                                                   (
                                     Ignorable by Annotation
                                )
                                

                                    
 If this is a false-positive, you can also ignore this issue in your code via the ignore-call   annotation

                                    

                                        

                                            10
                                            
                                                
            /** @scrutinizer ignore-call */ 

                                        

                                                                                

                                            11
                                            
                                                
            $campo = $this->bonificaNomeCampo($modellocolonna['nomecampo']);

                                        

                                                                            

                                

                                                                                                                            

                    
                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                             4                         
                
                
                
            $this->getOpzionitabellaCampiExtra($campo, $modellocolonna, $opzionibuilder);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
It seems like getOpzionitabellaCampiExtra() must be provided by classes using this trait. How about adding it as abstract method to this trait?
                                                                                   (
                                     Ignorable by Annotation
                                )
                                

                                    
 If this is a false-positive, you can also ignore this issue in your code via the ignore-call   annotation

                                    

                                        

                                            11
                                            
                                                
            $this->/** @scrutinizer ignore-call */ 

                                        

                                                                                

                                            12
                                            
                                                
                   getOpzionitabellaCampiExtra($campo, $modellocolonna, $opzionibuilder);

                                        

                                                                            

                                

                                                                                                                            

                    
                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                             4                         
                
                
                
            foreach ($modellocolonna as $key => $value) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                             4                         
                
                
                
                $this->checkCampoOpzioniTabella($campo, $modellocolonna, $opzionibuilder);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                             4                         
                
                
                
                if ('ordine' == $key) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    15
                

                                    
                             3                         
                
                
                
                    $this->setMaxOrdine($value);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
It seems like setMaxOrdine() must be provided by classes using this trait. How about adding it as abstract method to this trait?
                                                                                   (
                                     Ignorable by Annotation
                                )
                                

                                    
 If this is a false-positive, you can also ignore this issue in your code via the ignore-call   annotation

                                    

                                        

                                            15
                                            
                                                
                    $this->/** @scrutinizer ignore-call */ 

                                        

                                                                                

                                            16
                                            
                                                
                           setMaxOrdine($value);

                                        

                                                                            

                                

                                                                                                                            

                    
                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
                }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                             4                         
                
                
                
                $opzionibuilder[$campo][$key] = $value;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
            }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    20
                

                                    
                             12                         
                
                
                
    }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    22
                

                                    
                             4                         
                
                
                
    protected function checkCampoOpzioniTabella($campo, $modellocolonna, &$opzionibuilder)

            


            
                                                                        
                            
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
    {

            


            
                                                                        
                            
            
                                    
            
            

                
                    24
                

                                    
                             4                         
                
                
                
        if (!array_key_exists($campo, $opzionibuilder)) {

            


            
                                                                        
                            
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
            if ((isset($modellocolonna['campoextra']) && true == $modellocolonna['campoextra'])) {

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Unused Code
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
This if statement is empty and can be removed.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for the bodies of  if statements that have no statements or where all statements
have been commented out. This may be the result of changes for debugging or the code
may simply be obsolete.


These if bodies can be removed. If you have an empty if but statements in the else
branch, consider inverting the condition.


if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}





could be turned into


if (rand(1, 6) <= 3) {
    print "Check succeeded";
}





This is much more concise to read.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                        
                            
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
                // tuttapposto

            


            
                                                                        
                            
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
            } else {

            


            
                                                                        
                            
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
                $ex = 'BiCore: '.$campo." field table option not found, did you mean one of these:\n".

            


            
                                                                        
                            
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
                        implode("\n", array_keys($opzionibuilder)).

            


            
                                                                        
                            
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
                        ' ?';

            


            
                                                                        
                            
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
                throw new \Exception($ex);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                
            }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    33
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    34
                

                                    
                             4                         
                
                
                
    }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    35
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    36