Cdf\BiCoreBundle\Utils\Tabella\TabellaOpzioniFromModelloColonneTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

70.59%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setOpzioniTabellaFromModellocolonne()	0	11	4
A	checkCampoOpzioniTabella()	0	10	4

<?php

namespace Cdf\BiCoreBundle\Utils\Tabella;

trait TabellaOpzioniFromModelloColonneTrait
{
    protected function setOpzioniTabellaFromModellocolonne(&$opzionibuilder)
    {
        foreach ($this->modellocolonne as $modellocolonna) {
            $campo = $this->bonificaNomeCampo($modellocolonna['nomecampo']);

It seems like bonificaNomeCampo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->getOpzionitabellaCampiExtra($campo, $modellocolonna, $opzionibuilder);

It seems like getOpzionitabellaCampiExtra() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            foreach ($modellocolonna as $key => $value) {
                $this->checkCampoOpzioniTabella($campo, $modellocolonna, $opzionibuilder);
                if ('ordine' == $key) {
                    $this->setMaxOrdine($value);

It seems like setMaxOrdine() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                }
                $opzionibuilder[$campo][$key] = $value;
            }
        }
    }

    protected function checkCampoOpzioniTabella($campo, $modellocolonna, &$opzionibuilder)
    {
        if (!array_key_exists($campo, $opzionibuilder)) {
            if ((isset($modellocolonna['campoextra']) && true == $modellocolonna['campoextra'])) {

This if statement is empty and can be removed.

                // tuttapposto
            } else {
                $ex = 'BiCore: '.$campo." field table option not found, did you mean one of these:\n".
                        implode("\n", array_keys($opzionibuilder)).
                        ' ?';
                throw new \Exception($ex);
            }
        }
    }
}