UpdateHandlerTrait::handleUpdate() - Code Metrics - Inspection of "Support listing/editing exact value from array col..." - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 49dc1a...1f58a4 )

by Yaro

created 2020-08-11 09:30 UTC

UpdateHandlerTrait::handleUpdate() C

↳ Parent: UpdateHandlerTrait

Complexity

Conditions	11
Paths	26

Size

Total Lines

Duplication

Lines	5
Ratio	8.77 %

Code Coverage

Tests	20
CRAP Score	11.013

Importance

Changes

Metric	Value
dl	5
loc	57
ccs	20
cts	21
cp	0.9524
rs	6.7915
c	0
b	0
f	0
cc	11
nc	26
nop	2
crap	11.013

How to fix Long Method Complexity

<?php

namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;

use Illuminate\Http\Request;
use Spatie\Permission\Exceptions\UnauthorizedException;
use Yaro\Jarboe\Exceptions\PermissionDenied;
use Yaro\Jarboe\Table\CRUD;
use Yaro\Jarboe\Table\Fields\AbstractField;

trait UpdateHandlerTrait
{
    /**
     * Handle update action.
     *
     * @param Request $request
     * @param $id
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     * @throws PermissionDenied
     * @throws UnauthorizedException
     */
    public function handleUpdate(Request $request, $id)
    {
        $this->beforeInit();
        $this->init();
        $this->bound();

        if (!$this->can('update')) {
            throw UnauthorizedException::forPermissions(['update']);
        }

        $model = $this->crud()->repo()->find($id);
        if (!$this->crud()->actions()->isAllowed('edit', $model)) {
            throw new PermissionDenied();
        }

        $fields = $this->crud()->getFieldsWithoutMarkup();

        $inputs = [];
        /** @var AbstractField $field */
        foreach ($fields as $field) {

            if ($field->belongsToArray()) {
                $inputs += [$field->name() => $request->input($field->getDotPatternName())];
            }
        }
        $request->replace(
            $request->all() + $inputs
        );

        $data = [];
        $additional = [];
        /** @var AbstractField $field */
        foreach ($fields as $field) {
            if ($field->hidden('edit') || $field->isReadonly() || $field->shouldSkip($request)) {
                continue;
            }

            $field->beforeUpdate($model);

            if ($field->belongsToArray()) {
                $additional[$field->getAncestorName()][$field->getDescendantName()] = $field->value($request);
                continue;
            }

            $data += [$field->name() => $field->value($request)];
        }

        $data = $data + $additional;

        $model = $this->crud()->repo()->update($id, $data);
        /** @var AbstractField $field */
        foreach ($fields as $field) {
            $field->afterUpdate($model, $request);
        }
        $this->idEntity = $model->getKey();
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return redirect($this->crud()->listUrl());
    }

    abstract protected function beforeInit();

    abstract protected function init();

    abstract protected function bound();

    abstract protected function crud(): CRUD;
    abstract protected function can($action): bool;
}


1			<?php
2
3			namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;
4
5			use Illuminate\Http\Request;
6			use Spatie\Permission\Exceptions\UnauthorizedException;
7			use Yaro\Jarboe\Exceptions\PermissionDenied;
8			use Yaro\Jarboe\Table\CRUD;
9			use Yaro\Jarboe\Table\Fields\AbstractField;
10
11			trait UpdateHandlerTrait
12			{
13			/**
14			* Handle update action.
15			*
16			* @param Request $request
17			* @param $id
18			* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Routing\Redirector
19			* @throws PermissionDenied
20			* @throws UnauthorizedException
21			*/
22	4		public function handleUpdate(Request $request, $id)
23			{
24	4		$this->beforeInit();
25	4		$this->init();
26	4		$this->bound();
27
28	4		if (!$this->can('update')) {
29	2		throw UnauthorizedException::forPermissions(['update']);
30			}
31
32	2		$model = $this->crud()->repo()->find($id);
33	2		if (!$this->crud()->actions()->isAllowed('edit', $model)) {
34	1		throw new PermissionDenied();
35			}
36
37	1		$fields = $this->crud()->getFieldsWithoutMarkup();
38	1
39			$inputs = [];
40	1		/** @var AbstractField $field */
41	1	View Code Duplication	foreach ($fields as $field) {
			0 ignored issues – show Duplication introduced 2020-08-11 09:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42			if ($field->belongsToArray()) {
43			$inputs += [$field->name() => $request->input($field->getDotPatternName())];
44			}
45	1		}
46			$request->replace(
47	1		$request->all() + $inputs
48			);
49
50	1		$data = [];
51			$additional = [];
52	1		/** @var AbstractField $field */
53	1		foreach ($fields as $field) {
54			if ($field->hidden('edit') \|\| $field->isReadonly() \|\| $field->shouldSkip($request)) {
55	1		continue;
56			}
57	1
58			$field->beforeUpdate($model);
59
60			if ($field->belongsToArray()) {
61			$additional[$field->getAncestorName()][$field->getDescendantName()] = $field->value($request);
62			continue;
63			}
64
65			$data += [$field->name() => $field->value($request)];
66			}
67
68			$data = $data + $additional;
69
70			$model = $this->crud()->repo()->update($id, $data);
71			/** @var AbstractField $field */
72			foreach ($fields as $field) {
73			$field->afterUpdate($model, $request);
74			}
75			$this->idEntity = $model->getKey();
			0 ignored issues – show Bug introduced 2019-10-24 14:58 UTC by Report Bug Copy Issue Report The property `idEntity` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
76
77			return redirect($this->crud()->listUrl());
78			}
79
80			abstract protected function beforeInit();
			0 ignored issues – show Documentation introduced 2019-10-24 14:58 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
81			abstract protected function init();
			0 ignored issues – show Documentation introduced 2020-06-03 17:16 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
82			abstract protected function bound();
			0 ignored issues – show Documentation introduced 2019-10-24 14:58 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
83			abstract protected function crud(): CRUD;
84			abstract protected function can($action): bool;
85			}
86

Cherry-Pie / Jarboe

Push — master ( 49dc1a...1f58a4 )

UpdateHandlerTrait::handleUpdate() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like