Yaro\Jarboe\Http\Controllers\Traits\Handlers\UpdateHandlerTrait

Complexity

Total Complexity

11

Size/Duplication

Total Lines	75
Duplicated Lines	6.67 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

95.24%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
C	handleUpdate()	5	57	11
	beforeInit()	0	1	?
	init()	0	1	?
	bound()	0	1	?
	crud()	0	1	?
	can()	0	1	?

<?php

namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;

use Illuminate\Http\Request;
use Spatie\Permission\Exceptions\UnauthorizedException;
use Yaro\Jarboe\Exceptions\PermissionDenied;
use Yaro\Jarboe\Table\CRUD;
use Yaro\Jarboe\Table\Fields\AbstractField;

trait UpdateHandlerTrait
{
    /**
     * Handle update action.
     *
     * @param Request $request
     * @param $id
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     * @throws PermissionDenied
     * @throws UnauthorizedException
     */
    public function handleUpdate(Request $request, $id)
    {
        $this->beforeInit();
        $this->init();
        $this->bound();

        if (!$this->can('update')) {
            throw UnauthorizedException::forPermissions(['update']);
        }

        $model = $this->crud()->repo()->find($id);
        if (!$this->crud()->actions()->isAllowed('edit', $model)) {
            throw new PermissionDenied();
        }

        $fields = $this->crud()->getFieldsWithoutMarkup();

        $inputs = [];
        /** @var AbstractField $field */
        foreach ($fields as $field) {

This code seems to be duplicated across your project.

            if ($field->belongsToArray()) {
                $inputs += [$field->name() => $request->input($field->getDotPatternName())];
            }
        }
        $request->replace(
            $request->all() + $inputs
        );

        $data = [];
        $additional = [];
        /** @var AbstractField $field */
        foreach ($fields as $field) {
            if ($field->hidden('edit') || $field->isReadonly() || $field->shouldSkip($request)) {
                continue;
            }

            $field->beforeUpdate($model);

            if ($field->belongsToArray()) {
                $additional[$field->getAncestorName()][$field->getDescendantName()] = $field->value($request);
                continue;
            }

            $data += [$field->name() => $field->value($request)];
        }

        $data = $data + $additional;

        $model = $this->crud()->repo()->update($id, $data);
        /** @var AbstractField $field */
        foreach ($fields as $field) {
            $field->afterUpdate($model, $request);
        }
        $this->idEntity = $model->getKey();

The property idEntity does not exist. Did you maybe forget to declare it?

        return redirect($this->crud()->listUrl());
    }

    abstract protected function beforeInit();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract protected function init();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract protected function bound();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract protected function crud(): CRUD;
    abstract protected function can($action): bool;
}