Cecil\Assets\Image::resize()

Complexity

Conditions	13
Paths	92

Size

Total Lines	98
Code Lines	48

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function resize(string $path, int $size): string
    {
        /**
         * path = /images/img-1.jpg
         * path = https://example.com/img-2.png.
         */
        $this->path = $path;
        $this->size = $size;

        // is not a local image?
        if (Util::isExternalUrl($this->path)) {
            $this->local = false;
        }

        // source file
        if ($this->local) {
            $this->source = $this->config->getStaticPath().'/'.ltrim($this->path, '/');
            if (!Util::getFS()->exists($this->source)) {
                throw new Exception(sprintf('Can\'t process "%s": file doesn\'t exists.', $this->source));
            }
        } else {
            $this->source = $this->path;
            if (!Util::isUrlFileExists($this->source)) {
                throw new Exception(sprintf('Can\'t process "%s": file doesn\'t exists.', $this->source));
            }
        }

        // images cache path
        $this->cachePath = $this->config->getCachePath().'/'.self::CACHE_IMAGES_DIR;

The property cachePath does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        // is size is already OK?
        list($width, $height) = getimagesize($this->source);
        if ($width <= $this->size && $height <= $this->size) {
            return $this->path;
        }

        // if GD extension is not installed: can't process
        if (!extension_loaded('gd')) {
            return $this->path;
        }

        // ie: .cache/images/thumbs/300
        $this->thumbsDir = $this->cacheDir.'/'.self::CACHE_IMAGES_THUMBS_DIR.'/'.$this->size;
        // ie: .cache/images/thumbs/300/img/logo.png
        $this->imageRelPath = $this->thumbsDir.'/'.ltrim($this->path, '/');
        // where to write the file
        $this->destination = $this->config->getDestinationDir().'/'.$this->imageRelPath;
        if ($this->config->isCacheDirIsAbsolute()) {
            $this->destination = $this->imageRelPath;
        }

        if (Util::getFS()->exists($this->destination)) {
            return $this->path;
        }

        // Image object
        try {
            $img = ImageManager::make($this->source);

            // DEBUG
            var_dump($img->width());

var_dump($img->width()) looks like debug code. Are you sure you do not want to remove it?

            var_dump($img->height());

            $img->resize($this->size, null, function (\Intervention\Image\Constraint $constraint) {
                $constraint->aspectRatio();
                $constraint->upsize();
            });

            // DEBUG
            var_dump($img->width());
            var_dump($img->height());
            //die();
        } catch (NotReadableException $e) {
            throw new Exception(sprintf('Cannot get image "%s"', $this->path));
        }

        // return data:image
        if (!$this->local) {
            return (string) $img->encode('data-url');
        }

        // save/write file
        // is a sub dir is necessary?
        $imageSubDir = Util::getFS()->makePathRelative(
            '/'.dirname($this->imageRelPath),
            '/'.$this->thumbsDir.'/'
        );
        if (!empty($imageSubDir)) {
            $destDir = $this->config->getCacheImagesThumbsPath().'/'.$this->size.'/'.$imageSubDir;
            Util::getFS()->mkdir($destDir);
        }
        //$img->save($this->destination);

        // return relative path
        return '/'.$this->config->get('cache.images.dir')

Are you sure $this->config->get('cache.images.dir') of type array|mixed|null can be used in concatenation?

            .'/'.(string) $this->config->get('cache.images.thumbs.dir')
            .'/'.$this->size
            .'/'.ltrim($this->path, '/');
    }