Cecil\Assets\Image

Complexity

Total Complexity

16

Size/Duplication

Total Lines	148
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	doResize()	0	6	2
A	__construct()	0	3	1
C	resize()	0	98	13

<?php
/*
 * This file is part of the Cecil/Cecil package.
 *
 * Copyright (c) Arnaud Ligny <arnaud@ligny.org>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cecil\Assets;

use Cecil\Builder;
use Cecil\Config;
use Cecil\Exception\Exception;
use Cecil\Util;
use Intervention\Image\Exception\NotReadableException;
use Intervention\Image\ImageManagerStatic as ImageManager;

class Image
{
    /** @var Config */
    private $config;
    /** @var string */
    private $path;
    /** @var int */
    private $size;
    /** @var bool */
    private $local = true;
    /** @var string */
    private $source;
    /** @var string */
    private $destination = null;
    /** @var string */
    private $imageRelPath = null;
    /** @var string */
    private $thumbsDir = null;
    /** @var string */
    private $cacheDir;

    const CACHE_IMAGES_DIR = 'images';
    const CACHE_IMAGES_THUMBS_DIR = 'thumbs';

    public function __construct(Builder $builder)
    {
        $this->config = $builder->getConfig();
    }

    /**
     * Resize an image.
     *
     * @param string $path       Image path (relative from static/ dir or external)
     * @param int    $this->size Image new size (width)
     *
     * @return string Path to image thumbnail
     */
    public function resize(string $path, int $size): string
    {
        /**
         * path = /images/img-1.jpg
         * path = https://example.com/img-2.png.
         */
        $this->path = $path;
        $this->size = $size;

        // is not a local image?
        if (Util::isExternalUrl($this->path)) {
            $this->local = false;
        }

        // source file
        if ($this->local) {
            $this->source = $this->config->getStaticPath().'/'.ltrim($this->path, '/');
            if (!Util::getFS()->exists($this->source)) {
                throw new Exception(sprintf('Can\'t process "%s": file doesn\'t exists.', $this->source));
            }
        } else {
            $this->source = $this->path;
            if (!Util::isUrlFileExists($this->source)) {
                throw new Exception(sprintf('Can\'t process "%s": file doesn\'t exists.', $this->source));
            }
        }

        // images cache path
        $this->cachePath = $this->config->getCachePath().'/'.self::CACHE_IMAGES_DIR;

The property cachePath does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        // is size is already OK?
        list($width, $height) = getimagesize($this->source);
        if ($width <= $this->size && $height <= $this->size) {
            return $this->path;
        }

        // if GD extension is not installed: can't process
        if (!extension_loaded('gd')) {
            return $this->path;
        }

        // ie: .cache/images/thumbs/300
        $this->thumbsDir = $this->cacheDir.'/'.self::CACHE_IMAGES_THUMBS_DIR.'/'.$this->size;
        // ie: .cache/images/thumbs/300/img/logo.png
        $this->imageRelPath = $this->thumbsDir.'/'.ltrim($this->path, '/');
        // where to write the file
        $this->destination = $this->config->getDestinationDir().'/'.$this->imageRelPath;
        if ($this->config->isCacheDirIsAbsolute()) {
            $this->destination = $this->imageRelPath;
        }

        if (Util::getFS()->exists($this->destination)) {
            return $this->path;
        }

        // Image object
        try {
            $img = ImageManager::make($this->source);

            // DEBUG
            var_dump($img->width());

var_dump($img->width()) looks like debug code. Are you sure you do not want to remove it?

            var_dump($img->height());

            $img->resize($this->size, null, function (\Intervention\Image\Constraint $constraint) {
                $constraint->aspectRatio();
                $constraint->upsize();
            });

            // DEBUG
            var_dump($img->width());
            var_dump($img->height());
            //die();
        } catch (NotReadableException $e) {
            throw new Exception(sprintf('Cannot get image "%s"', $this->path));
        }

        // return data:image
        if (!$this->local) {
            return (string) $img->encode('data-url');
        }

        // save/write file
        // is a sub dir is necessary?
        $imageSubDir = Util::getFS()->makePathRelative(
            '/'.dirname($this->imageRelPath),
            '/'.$this->thumbsDir.'/'
        );
        if (!empty($imageSubDir)) {
            $destDir = $this->config->getCacheImagesThumbsPath().'/'.$this->size.'/'.$imageSubDir;
            Util::getFS()->mkdir($destDir);
        }
        //$img->save($this->destination);

        // return relative path
        return '/'.$this->config->get('cache.images.dir')

Are you sure $this->config->get('cache.images.dir') of type array|mixed|null can be used in concatenation?

            .'/'.(string) $this->config->get('cache.images.thumbs.dir')
            .'/'.$this->size
            .'/'.ltrim($this->path, '/');
    }

    /**
     * Resize with Intervention ImageManager.
     *
     * @return string
     */
    private function doResize(): string

The method doResize() is not used, and could be removed.

    {
        try {
            //
        } catch (\Exception $e) {

catch (\Exception $e) is not reachable.

            throw new \Exception(sprintf("Error during \"%s\" process.\n%s", get_class($this), $e->getMessage()));
        }
    }
}