WaterfallTrait::callOnce() - Code Metrics - Inspection of "Refactor route calling" - CapMousse/React-Restify - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

by Jérémy

created 2017-02-13 23:38 UTC

WaterfallTrait::callOnce() A

↳ Parent: WaterfallTrait

Complexity

Conditions	2
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	2
eloc	5
nc	1
nop	1

<?php

namespace CapMousse\ReactRestify\Traits;

trait WaterfallTrait {
    /**
     * Call callback one
     * @param  function $fn 
     * @return function
     */
    function callOnce ($fn) 

    {
        return function () use ($fn) {
            if ($fn === null) return;
            call_user_func($fn, func_get_args());
            $fn = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        };
    }

    /**
     * Run tasks in series
     * @param  array  $tasks 
     * @return void
     */
    function waterfall (array $tasks)

    {
        $index = 0;

        $next = function () use (&$index, &$tasks, &$next) {
            if ($index == count($tasks)) { 
                return;
            }
            
            $callback = $this->callOnce(function () use (&$next) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $next();
            });

            call_user_func($tasks[$index++], $callback);
        };

        $next();
    }
}

1			<?php
2
3			namespace CapMousse\ReactRestify\Traits;
4
5			trait WaterfallTrait {
6			/**
7			* Call callback one
8			* @param function $fn
9			* @return function
10			*/
11			function callOnce ($fn)
			0 ignored issues – show Best Practice introduced 2017-02-13 23:30 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
12			{
13			return function () use ($fn) {
14			if ($fn === null) return;
15			call_user_func($fn, func_get_args());
16			$fn = null;
			1 ignored issue – show Unused Code introduced 2017-02-13 23:30 UTC by Report Bug Copy Issue Report `$fn` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
17			};
18			}
19
20			/**
21			* Run tasks in series
22			* @param array $tasks
23			* @return void
24			*/
25			function waterfall (array $tasks)
			0 ignored issues – show Best Practice introduced 2017-02-13 23:30 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
26			{
27			$index = 0;
28
29			$next = function () use (&$index, &$tasks, &$next) {
30			if ($index == count($tasks)) {
31			return;
32			}
33
34			$callback = $this->callOnce(function () use (&$next) {
			0 ignored issues – show Documentation introduced 2017-02-13 23:30 UTC by Report Bug Copy Issue Report `function () use(&$next) { $next(); }` is of type `object<Closure>`, but the function expects a `object<CapMousse\ReactRestify\Traits\function>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35			$next();
36			});
37
38			call_user_func($tasks[$index++], $callback);
39			};
40
41			$next();
42			}
43			}

CapMousse / React-Restify

GitHub Access Token became invalid

Pull Request — master (#13)

WaterfallTrait::callOnce() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like