CapMousse\ReactRestify\Traits\WaterfallTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	callOnce()	0	8	2
A	waterfall()	0	18	2

<?php

namespace CapMousse\ReactRestify\Traits;

trait WaterfallTrait {
    /**
     * Call callback one
     * @param  function $fn 
     * @return function
     */
    function callOnce ($fn) 

It is generally recommended to explicitly declare the visibility for methods.

    {
        return function () use ($fn) {
            if ($fn === null) return;
            call_user_func($fn, func_get_args());
            $fn = null;

$fn is not used, you could remove the assignment.

        };
    }

    /**
     * Run tasks in series
     * @param  array  $tasks 
     * @return void
     */
    function waterfall (array $tasks)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $index = 0;

        $next = function () use (&$index, &$tasks, &$next) {
            if ($index == count($tasks)) { 
                return;
            }
            
            $callback = $this->callOnce(function () use (&$next) {

function () use(&$next) { $next(); } is of type object<Closure>, but the function expects a object<CapMousse\ReactRestify\Traits\function>.

                $next();
            });

            call_user_func($tasks[$index++], $callback);
        };

        $next();
    }
}