WaterfallTrait::callOnce() - Code Metrics - CapMousse/React-Restify - Measure and Improve Code Quality continuously with Scrutinizer

WaterfallTrait::callOnce() A
last analyzed 2017-09-06 07:50 UTC

↳ Parent: WaterfallTrait

Complexity

Conditions	2
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	2
eloc	5
nc	1
nop	1

<?php

namespace CapMousse\ReactRestify\Traits;

trait WaterfallTrait
{
    /**
     * Call callback one
     * @param  \Closure $fn 
     * @return \Closure
     */
    private function callOnce ($fn) 
    {
        return function (...$args) use ($fn) {
            if ($fn === null) return;
            $fn(...$args);
            $fn = null;
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
        };
    }

    /**
     * Run tasks in series
     * @param  \Closure[]  $tasks 
     * @param  array       $args
     * @return void
     */
    private function waterfall (array $tasks, array $args)
    {
        $index = 0;

        $next = function () use (&$index, &$tasks, &$next, &$args) {
            if ($index == count($tasks)) { 
                return;
            }
            
            $callback = $this->callOnce(function () use (&$next) {
                $next();
            });

            $tasks[$index++]($callback, ...$args);
        };

        $next();
    }
}

GitHub Access Token became invalid

WaterfallTrait::callOnce() A
last analyzed 2017-09-06 07:50 UTC

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

1			<?php
2
3			namespace CapMousse\ReactRestify\Traits;
4
5			trait WaterfallTrait
6			{
7			/**
8			* Call callback one
9			* @param \Closure $fn
10			* @return \Closure
11			*/
12			private function callOnce ($fn)
13			{
14			return function (...$args) use ($fn) {
15			if ($fn === null) return;
16			$fn(...$args);
17			$fn = null;
			0 ignored issues – show Bug introduced 2017-06-06 07:20 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$fn`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history... Unused Code introduced 2017-06-06 07:20 UTC by Report Bug Copy Issue Report `$fn` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
18			};
19			}
20
21			/**
22			* Run tasks in series
23			* @param \Closure[] $tasks
24			* @param array $args
25			* @return void
26			*/
27			private function waterfall (array $tasks, array $args)
28			{
29			$index = 0;
30
31			$next = function () use (&$index, &$tasks, &$next, &$args) {
32			if ($index == count($tasks)) {
33			return;
34			}
35
36			$callback = $this->callOnce(function () use (&$next) {
37			$next();
38			});
39
40			$tasks[$index++]($callback, ...$args);
41			};
42
43			$next();
44			}
45			}

CapMousse / React-Restify

GitHub Access Token became invalid

WaterfallTrait::callOnce() A last analyzed 2017-09-06 07:50 UTC

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like

WaterfallTrait::callOnce() A
last analyzed 2017-09-06 07:50 UTC