CapMousse\ReactRestify\Traits\WaterfallTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	callOnce()	0	8	2
A	waterfall()	0	18	2

<?php

namespace CapMousse\ReactRestify\Traits;

trait WaterfallTrait
{
    /**
     * Call callback one
     * @param  \Closure $fn 
     * @return \Closure
     */
    private function callOnce ($fn) 
    {
        return function (...$args) use ($fn) {
            if ($fn === null) return;
            $fn(...$args);
            $fn = null;

Consider using a different name than the imported variable $fn, or did you forget to import by reference?

$fn is not used, you could remove the assignment.

        };
    }

    /**
     * Run tasks in series
     * @param  \Closure[]  $tasks 
     * @param  array       $args
     * @return void
     */
    private function waterfall (array $tasks, array $args)
    {
        $index = 0;

        $next = function () use (&$index, &$tasks, &$next, &$args) {
            if ($index == count($tasks)) { 
                return;
            }
            
            $callback = $this->callOnce(function () use (&$next) {
                $next();
            });

            $tasks[$index++]($callback, ...$args);
        };

        $next();
    }
}