CakeDC / cakephp-api

src/Service/Action/Auth/RegisterAction.php

Unused Use Statements -2 removed lines

@@ -16,11 +16,9 @@
 use CakeDC\Users\Controller\Component\UsersAuthComponent;
 use CakeDC\Users\Controller\Traits\CustomUsersTableTrait;
 use CakeDC\Users\Controller\Traits\RegisterTrait;
-use CakeDC\Users\Exception\UserNotFoundException;
 use Cake\Core\Configure;
 use Cake\Datasource\EntityInterface;
 use Cake\Utility\Hash;
-use Cake\Validation\Validator;
 
 /**
  * Class RegisterAction

src/Service/Auth/Authorize/SimpleRbacAuthorize.php

Doc Comments +1 added lines, -1 removed lines

@@ -185,7 +185,7 @@
      * @param array $user current user
      * @param string $role effective user role
      * @param Request $request request
-     * @return bool if rule matched, null if rule not matched
+     * @return boolean|null if rule matched, null if rule not matched
      */
     protected function _matchRule($permission, $user, $role, $request)
     {

src/Service/Utility/ReverseRouting.php

Doc Comments +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
      *
      * @param Action $action An Action instance.
      * @param callable $beforeReverse Callback.
-     * @return array
+     * @return string|null
      */
     public function indexPath(Action $action, $beforeReverse = null)
     {
@@ -85,7 +85,7 @@ 
      * @param string $parentName Action name.
      * @param Action $action An Action instance.
      * @param string $type Type of action.
-     * @return array
+     * @return string
      */
     public function parentViewPath($parentName, $action, $type)
     {

src/TestSuite/IntegrationTestCase.php

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
      * Returns user token.
      *
      * @param string $userId User id.
-     * @return mixed|null
+     * @return string
      */
     protected function _userToken($userId = null)
     {

tests/TestCase/Auth/Authorize/SimpleRbacAuthorizeTest.php

Doc Comments +3 added lines

@@ -116,6 +116,9 @@
         $this->assertEquals($this->defaultPermissions, $this->simpleRbacAuthorize->config('permissions'));
     }
 
+    /**
+     * @param string $instance
+     */
     protected function assertConstructorPermissions($instance, $config, $permissions)
     {
         $reflectedClass = new ReflectionClass($instance);

tests/TestCase/Service/Action/CrudEditActionTest.php

Doc Comments +3 added lines

@@ -101,6 +101,9 @@
         $this->Action->execute();
     }
 
+    /**
+     * @param integer $id
+     */
     protected function _initializeAction($id, $post = [])
     {
         $this->_initializeController([

tests/TestCase/Service/Renderer/XmlRendererTest.php

Doc Comments +3 added lines

@@ -152,6 +152,9 @@
         $renderer->error($error);
     }
 
+    /**
+     * @param string $text
+     */
     protected function _xmlMessage($text)
     {
         return '<?xml version="1.0" encoding="UTF-8"?>' . "\n" . $text . "\n";

src/Middleware/ApiMiddleware.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Zend\Diactoros\Response\RedirectResponse;
 use Cake\Http\RequestTransformer;
 use Cake\Http\ResponseTransformer;
-
 use CakeDC\Api\Service\ConfigReader;
 use CakeDC\Api\Service\ServiceRegistry;
 

src/Service/Action/Auth/ResetPasswordAction.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     /**
      * Execute action.
      *
-     * @return mixed
+     * @return string
      * @throws Exception
      */
     public function execute()