Python.LocalDB.test_LocalDBQuery

Complexity

Total Complexity

25

Size/Duplication

Total Lines	209
Duplicated Lines	0 %

Importance

Changes

0

4 Functions

Rating	Name	Duplication	Size	Complexity
A	test_CreateSubject()	0	41	4
B	test_CheckSubjectExist()	0	47	5
B	test_CreateSubjectCheckExist()	0	49	8
B	test_SubjectUpdate()	0	54	8

import sqlite3

The name test_LocalDBQuery does not conform to the module naming conventions ((([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$).

This module should have a docstring.

from pathlib import Path
import logging
import os
import sys
from LocalDB.query import check_value, update_entry, create_entry

The name query does not seem to exist in module LocalDB.

Unable to import 'LocalDB.query'

from LocalDB.create_CNBP import create_localDB_CNBP

The name create_CNBP does not seem to exist in module LocalDB.

Unable to import 'LocalDB.create_CNBP'

logging.basicConfig(stream=sys.stdout, level=logging.INFO)

def test_CreateSubject():

The name test_CreateSubject does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    logger = logging.getLogger('UT_CreateSubject')
    PathString = "TestCNBPQuery.sqlite"

The name PathString does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # if SQL already exist, quit script.
    SQLPath = Path(PathString)

The name SQLPath does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # check if path is a file and exist.
    if SQLPath.is_file():
        logger.info('Test SQLite database file already exist. Gonna mess with it!')
        ''''Delete current database! During testing only'''

This string statement has no effect and could be removed.

        os.remove(PathString)

    # Create the database
    assert create_localDB_CNBP(PathString)
    logger.info('Test SQLite database successfully created. Gonna mess with it!')

    tableName = 'id_table'  # All CNBP database should have this table name.

The name tableName does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    MRNColumn = "MRN"

The name MRNColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    CNBPIDColumn = "CNBPID"

The name CNBPIDColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The variable CNBPIDColumn seems to be unused.

    create_entry(PathString, tableName, MRNColumn, 291033)
    logger.info('Test SQLite database successfully inserted with mock records. Gonna check!')

    # Populate the table with some fake records.
    ConnectedDatabase = sqlite3.connect(PathString)

The name ConnectedDatabase does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    c = ConnectedDatabase.cursor()

The name c does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    c.execute(
        'SELECT * FROM {tablename} WHERE {columnname}="{columnvalue}"'.
            format(tablename=tableName, columnname=MRNColumn,columnvalue=291033))

Wrong hanging indentation (remove 4 spaces).

Exactly one space required after comma

    ResultRows = c.fetchall()

The name ResultRows does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    assert len(ResultRows) > 0

Do not use len(SEQUENCE) as condition value

    # Closing the connection to the database file
    ConnectedDatabase.close()

    # Remove test data base created
    os.remove(PathString)

    return True

def test_CheckSubjectExist():

The name test_CheckSubjectExist does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    logger = logging.getLogger('UT_CheckSubjectExist')
    PathString = "TestCNBPQuery.sqlite"

The name PathString does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # if SQL already exist, quit script.
    SQLPath = Path(PathString)

The name SQLPath does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # check if path is a file and exist.
    if SQLPath.is_file():
        logger.info('Test SQLite database file already exist. Gonna mess with it!')
        ''''Delete current database! During testing only'''

This string statement has no effect and could be removed.

        os.remove(PathString)

    # Create the database
    assert create_localDB_CNBP(PathString)
    logger.info('Test SQLite database successfully created. Gonna mess with it!')

    tableName = 'id_table'  # All CNBP database should have this table name.

The name tableName does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    MRNColumn = "MRN"

The name MRNColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    CNBPIDColumn = "CNBPID"

The name CNBPIDColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # Populate the table with some fake records.
    ConnectedDatabase = sqlite3.connect(PathString)

The name ConnectedDatabase does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    c = ConnectedDatabase.cursor()

The name c does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (291010,'CNBP0010001')".
              format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
    c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (292010,'CNBP0020001')".
              format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
    c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (295010,'CNBP0010001')".
              format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
    c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (297120,'CNBP0030001')".
              format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
    c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (291310,'CNBP0510001')".
              format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
    ConnectedDatabase.commit()
    ConnectedDatabase.close()

    logger.info('Test SQLite database successfully inserted with mock records. Gonna mess with it!')

    # Create on Connecting to the database file
    assert(check_value(PathString, tableName, "MRN", 291010))

There is an unnecessary parenthesis after assert.

    assert(check_value(PathString, tableName, "CNBPID", "CNBP0010001"))

There is an unnecessary parenthesis after assert.

    # Remove test data base created
    os.remove(PathString)

    return True

def test_CreateSubjectCheckExist():

The name test_CreateSubjectCheckExist does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    logger = logging.getLogger('UT_CreateAndCheck')
    PathString = "TestCNBPQuery.sqlite"

The name PathString does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # if SQL already exist, quit script.
    SQLPath = Path(PathString)

The name SQLPath does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # check if path is a file and exist.
    if SQLPath.is_file():
        logger.info('Test SQLite database file already exist. Gonna mess with it!')
        ''''Delete current database! During testing only'''

This string statement has no effect and could be removed.

        os.remove(PathString)

    # Create the database
    assert create_localDB_CNBP(PathString)
    logger.info('Test SQLite database successfully created. Gonna mess with it!')

    tableName = 'id_table'  # All CNBP database should have this table name.

The name tableName does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    MRNColumn = "MRN"

The name MRNColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    CNBPIDColumn = "CNBPID"

The name CNBPIDColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The variable CNBPIDColumn seems to be unused.

    create_entry(PathString, tableName, MRNColumn, 2918210)
    create_entry(PathString, tableName, MRNColumn, 23452346)
    create_entry(PathString, tableName, MRNColumn, 2345234)
    create_entry(PathString, tableName, MRNColumn, 273411)
    create_entry(PathString, tableName, MRNColumn, 364573)
    create_entry(PathString, tableName, MRNColumn, 7424141)

    success, _ = check_value(PathString, tableName, MRNColumn, 7129112)
    assert not success

    success, _ = check_value(PathString, tableName, MRNColumn, 2918210)
    assert success

    success, _ = check_value(PathString, tableName, MRNColumn, 712921)
    assert not success

    success, _ = check_value(PathString, tableName, MRNColumn, 742)
    assert not success

    success, _ = check_value(PathString, tableName, MRNColumn, 364573)
    assert success

    logger.info('Tested SQLIte database entry. ')

    # Remove test data base created
    os.remove(PathString)

    return True

def test_SubjectUpdate():

The name test_SubjectUpdate does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    logger = logging.getLogger('UT_CreateAndCheck')
    PathString = "TestCNBPQuery.sqlite"

The name PathString does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # if SQL already exist, quit script.
    SQLPath = Path(PathString)

The name SQLPath does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # check if path is a file and exist.
    if SQLPath.is_file():
        logger.info('Test SQLite database file already exist. Gonna mess with it!')
        ''''Delete current database! During testing only'''

This string statement has no effect and could be removed.

        os.remove(PathString)

    # Create the database
    assert create_localDB_CNBP(PathString)
    logger.info('Test SQLite database successfully created. Gonna mess with it!')

    tableName = 'id_table'  # All CNBP database should have this table name.

The name tableName does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    MRNColumn = "MRN"

The name MRNColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    CNBPIDColumn = "CNBPID"

The name CNBPIDColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    create_entry(PathString, tableName, MRNColumn, 2918210)
    create_entry(PathString, tableName, MRNColumn, 23452346)
    create_entry(PathString, tableName, MRNColumn, 2345234)
    create_entry(PathString, tableName, MRNColumn, 273411)
    create_entry(PathString, tableName, MRNColumn, 364573)
    create_entry(PathString, tableName, MRNColumn, 7424141)

    update_entry(PathString, tableName, MRNColumn, 7424141, CNBPIDColumn, "CNBPID0010001")
    update_entry(PathString, tableName, MRNColumn, 2345234, CNBPIDColumn, "CNBPID0010002")
    update_entry(PathString, tableName, MRNColumn, 2918210, CNBPIDColumn, "CNBPID0010003")
    update_entry(PathString, tableName, MRNColumn, 273411, CNBPIDColumn, "CNBPID0010004")

    success, _ = check_value(PathString, tableName, CNBPIDColumn, 'CNBPID0010006')
    assert not success

    success, _ = check_value(PathString, tableName, CNBPIDColumn, 'CNBPID0010001')
    assert success

    success, _ = check_value(PathString, tableName, CNBPIDColumn, 55555)
    assert not success

    success, _ = check_value(PathString, tableName, CNBPIDColumn, 742)
    assert not success

    success, _ = check_value(PathString, tableName, CNBPIDColumn, 'CNBPID0010003')
    assert success

    logger.info('Tested SQLIte database entry. ')

    # Remove test data base created
    os.remove(PathString)

    return True

if __name__ == '__main__':
    test_SubjectUpdate()

Final newline missing