Python.LocalDB.test_LocalDBQuery.test_CreateSubject()

Complexity

Conditions

4

Size

Total Lines	41
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

import sqlite3
def test_CreateSubject():

The name test_CreateSubject does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    logger = logging.getLogger('UT_CreateSubject')
    PathString = "TestCNBPQuery.sqlite"

The name PathString does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # if SQL already exist, quit script.
    SQLPath = Path(PathString)

The name SQLPath does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # check if path is a file and exist.
    if SQLPath.is_file():
        logger.info('Test SQLite database file already exist. Gonna mess with it!')
        ''''Delete current database! During testing only'''

This string statement has no effect and could be removed.

        os.remove(PathString)

    # Create the database
    assert create_localDB_CNBP(PathString)
    logger.info('Test SQLite database successfully created. Gonna mess with it!')

    tableName = 'id_table'  # All CNBP database should have this table name.

The name tableName does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    MRNColumn = "MRN"

The name MRNColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    CNBPIDColumn = "CNBPID"

The name CNBPIDColumn does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The variable CNBPIDColumn seems to be unused.

    create_entry(PathString, tableName, MRNColumn, 291033)
    logger.info('Test SQLite database successfully inserted with mock records. Gonna check!')

    # Populate the table with some fake records.
    ConnectedDatabase = sqlite3.connect(PathString)

The name ConnectedDatabase does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    c = ConnectedDatabase.cursor()

The name c does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    c.execute(
        'SELECT * FROM {tablename} WHERE {columnname}="{columnvalue}"'.
            format(tablename=tableName, columnname=MRNColumn,columnvalue=291033))

Wrong hanging indentation (remove 4 spaces).

Exactly one space required after comma

    ResultRows = c.fetchall()

The name ResultRows does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    assert len(ResultRows) > 0

Do not use len(SEQUENCE) as condition value

    # Closing the connection to the database file
    ConnectedDatabase.close()

    # Remove test data base created
    os.remove(PathString)

    return True

    test_SubjectUpdate()

Final newline missing