ByTIC\Payments\Actions\GatewayNotifications\CreateorUpdateTokenFromResponse::handle()

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function handle($response, $model, $type)

The parameter $type is not used and could be removed.

    {
        if (!method_exists($response, 'getToken')) {
            return null;
        }
        $token = $response->getToken();
        if (!($token instanceof TokenInterface)) {
            return null;
        }
        return PaymentsModels::tokens()->findOrCreateForMethod($model->getPaymentMethod(), $token);

Are you sure the usage of $model->getPaymentMethod() targeting ByTIC\Payments\Models\Purchases\Purchase::getPaymentMethod() seems to always return null.

The expression return ByTIC\Payments\Utility\PaymentsModels::tokens()->findOrCreateForMethod($model->getPaymentMethod(), $token) also could return the type ByTIC\Payments\Models\Tokens\TokenTrait which is incompatible with the documented return type ByTIC\Payments\Models\Transactions\TransactionTrait|Nip\Records\AbstractModels\Record.

    }
}