ByTIC\Payments\Actions\GatewayNotifications\CreateorUpdateTokenFromResponse

Complexity

Total Complexity

3

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	10	3

<?php

namespace ByTIC\Payments\Actions\GatewayNotifications;

use ByTIC\Omnipay\Common\Models\TokenInterface;
use ByTIC\Payments\Models\Purchases\Purchase;
use ByTIC\Payments\Utility\PaymentsModels;

/**
 * Class CreateorUpdateTokenFromResponse
 * @package ByTIC\Payments\Actions\GatewayNotifications
 */
class CreateorUpdateTokenFromResponse
{
    /**
     * @param $response
     * @param Purchase $model
     * @param $type
     * @return \ByTIC\Payments\Models\Transactions\TransactionTrait|\Nip\Records\AbstractModels\Record
     */
    public static function handle($response, $model, $type)

The parameter $type is not used and could be removed.

    {
        if (!method_exists($response, 'getToken')) {
            return null;
        }
        $token = $response->getToken();
        if (!($token instanceof TokenInterface)) {
            return null;
        }
        return PaymentsModels::tokens()->findOrCreateForMethod($model->getPaymentMethod(), $token);

Are you sure the usage of $model->getPaymentMethod() targeting ByTIC\Payments\Models\Purchases\Purchase::getPaymentMethod() seems to always return null.

The expression return ByTIC\Payments\Utility\PaymentsModels::tokens()->findOrCreateForMethod($model->getPaymentMethod(), $token) also could return the type ByTIC\Payments\Models\Tokens\TokenTrait which is incompatible with the documented return type ByTIC\Payments\Models\Transactions\TransactionTrait|Nip\Records\AbstractModels\Record.

    }
}