DetectFromHttpRequestTrait::detectFromHttpRequestTrait()

Complexity

Conditions	7
Paths	20

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	7.1429

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function detectFromHttpRequestTrait($modelManager, $callback = null, $httpRequest = null)
    {
        $callback = $callback ? $callback : 'completePurchase';

$callback is of type null, thus it always evaluated to false.

        if ($httpRequest) {
            $this->setHttpRequest($httpRequest);

It seems like setHttpRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
        if (!method_exists($this, $callback)) {
            return false;
        }
        /** @var AbstractRequest $request */
        $request = $this->$callback(['modelManager' => $modelManager]);
        if (!is_object($request)) {
            return false;
        }
        if (!method_exists($request, 'isValidNotification')) {
            throw new \Exception("Request must have a isValidNotification public method");
        }
        if (!$request->isValidNotification()) {
            return false;
        }

        return $request;
    }