ByTIC\Payments\Gateways\Providers\AbstractGateway\Traits\DetectFromHttpRequestTrait

Complexity

Total Complexity

7

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Test Coverage

Coverage

85.71%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	detectFromHttpRequestTrait()	0	22	7

<?php

namespace ByTIC\Payments\Gateways\Providers\AbstractGateway\Traits;

use Omnipay\Common\Message\AbstractRequest;
use Symfony\Component\HttpFoundation\Request as HttpRequest;

/**
 * Trait DetectFromHttpRequestTrait
 * @package ByTIC\Payments\Gateways\Providers\AbstractGateway\Traits
 */
trait DetectFromHttpRequestTrait
{
    /**
     * @param $modelManager
     * @param null $callback

Are you sure the doc-type for parameter $callback is correct as it would always require null to be passed?

     * @param HttpRequest $httpRequest
     *
     * @return AbstractRequest|false
     * @throws \Exception
     */
    public function detectFromHttpRequestTrait($modelManager, $callback = null, $httpRequest = null)
    {
        $callback = $callback ? $callback : 'completePurchase';

$callback is of type null, thus it always evaluated to false.

        if ($httpRequest) {
            $this->setHttpRequest($httpRequest);

It seems like setHttpRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
        if (!method_exists($this, $callback)) {
            return false;
        }
        /** @var AbstractRequest $request */
        $request = $this->$callback(['modelManager' => $modelManager]);
        if (!is_object($request)) {
            return false;
        }
        if (!method_exists($request, 'isValidNotification')) {
            throw new \Exception("Request must have a isValidNotification public method");
        }
        if (!$request->isValidNotification()) {
            return false;
        }

        return $request;
    }
}