ByTIC\MediaLibraryModule\Controllers\Traits\Async\Logos::uploadLogo()

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function uploadLogo()
    {
        $item = $this->getModelFromRequest();

It seems like getModelFromRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $type = $_REQUEST['type'];
        if (in_array($type, $item->logoTypes)) {
            $image = $item->uploadLogo($type);

            if (is_object($image)) {
                $response['type'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

                $response['url'] = $image->getUrl();
                $response['path'] = $image->getPath();
                $response['imageType'] = $image->getImageType();
                $this->setResponseValues($response);
            } else {
                $this->sendError($item->errors['upload']);

It seems like sendError() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        } else {
            $this->sendError('bad logo type');
        }