ByTIC\MediaLibraryModule\Controllers\Traits\Async\Logos

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	uploadLogo()	0	19	3
A	removeLogo()	0	15	2

<?php

namespace ByTIC\MediaLibraryModule\Controllers\Traits\Async;

/**
 * Class Logos
 * @package ByTIC\MediaLibraryModule\Controllers\Traits\Async
 */
trait Logos
{
    public function uploadLogo()
    {
        $item = $this->getModelFromRequest();

It seems like getModelFromRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $type = $_REQUEST['type'];
        if (in_array($type, $item->logoTypes)) {
            $image = $item->uploadLogo($type);

            if (is_object($image)) {
                $response['type'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

                $response['url'] = $image->getUrl();
                $response['path'] = $image->getPath();
                $response['imageType'] = $image->getImageType();
                $this->setResponseValues($response);
            } else {
                $this->sendError($item->errors['upload']);

It seems like sendError() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        } else {
            $this->sendError('bad logo type');
        }
    }

    /**
     * @param $values
     * @return void
     */
    abstract public function setResponseValues($values);

    public function removeLogo()
    {
        $item = $this->getModelFromRequest();

        if ($item->removeLogo($_REQUEST)) {
            $response['message'] = 'Logo sters';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        } else {
            $response['message'] = 'Logo-ul convertit la default';
        }

        $image = $item->getLogo($_REQUEST['type']);
        $response['type'] = 'success';
        $response['url'] = $image->getUrl();
        $response['path'] = $image->getPath();
        $this->setResponseValues($response);
    }
}