ByTIC\MediaLibraryModule\Controllers\Traits\Async\Files::uploadAttachment()

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function uploadAttachment()
    {
        $item = $this->getModelFromRequest();

It seems like getModelFromRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $file = $item->uploadFile($_FILES['Filedata']);

        if ($file) {
            $response['type'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['url'] = $file->getURL();
            $response['name'] = $file->getName();
            $response['extension'] = $file->getExtension();
            $response['size'] = $file->formatSize();
            $response['time'] = date("d.m.Y H:i", $file->getTime());
        } else {
            $response['type'] = 'error';
        }
        $this->setResponseValues($response);
    }