ByTIC\MediaLibraryModule\Controllers\Traits\Async\Files

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	uploadAttachment()	0	17	2
A	removeFile()	0	8	2

<?php

namespace ByTIC\MediaLibraryModule\Controllers\Traits\Async;

/**
 * Class Files
 * @package ByTIC\MediaLibraryModule\Controllers\Traits\Async
 */
trait Files
{
    public function uploadAttachment()
    {
        $item = $this->getModelFromRequest();

It seems like getModelFromRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $file = $item->uploadFile($_FILES['Filedata']);

        if ($file) {
            $response['type'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['url'] = $file->getURL();
            $response['name'] = $file->getName();
            $response['extension'] = $file->getExtension();
            $response['size'] = $file->formatSize();
            $response['time'] = date("d.m.Y H:i", $file->getTime());
        } else {
            $response['type'] = 'error';
        }
        $this->setResponseValues($response);
    }

    /**
     * @param $values
     * @return void
     */
    abstract public function setResponseValues($values);

    public function removeFile()
    {
        $item = $this->getModelFromRequest();

        if ($item->removeFile($_POST)) {
            $response['type'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }
        $this->setResponseValues($response);

The variable $response does not seem to be defined for all execution paths leading up to this point.

    }
}