MessageFactory::constructPing() - Code Metrics - Buttress/IRC - Measure and Improve Code Quality continuously with Scrutinizer

MessageFactory::constructPing() A
last analyzed 2017-02-27 18:54 UTC

↳ Parent: MessageFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	4
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
namespace Buttress\IRC\Message;

use Buttress\IRC\Connection\ConnectionInterface;

class MessageFactory
{

    protected $constructors;

    public function register($command, callable $generator)
    {
        $this->constructors[$command] = $generator;
    }

    /**
     * @param string              $raw
     * @param ConnectionInterface $connection
     * @return MessageInterface
     */
    public function getMessageFromRaw($raw, ConnectionInterface $connection = null)
    {
        list($prefix, $command, $params) = $this->deconstructRaw($raw);
        $message = $this->make($command, $prefix, $params, $connection);

        return $message;
    }

    /**
     * @param string $raw_message
     */
    public function deconstructRaw($raw_message)
    {
        $prefix = "";

        if (substr($raw_message, 0, 1) == ':') {
            $prefix_end = strpos($raw_message, ' ');
            $prefix = substr($raw_message, 1, $prefix_end - 1);
            $raw = trim(substr($raw_message, $prefix_end + 1));
        } else {
            $raw = trim($raw_message);
        }

        $last_param = null;
        if ($last_param_pos = strpos($raw, ' :')) {
            $last_param = substr($raw, $last_param_pos + 2);
            $raw = substr($raw, 0, $last_param_pos);
        }

        $exploded = explode(' ', $raw);
        $command = array_shift($exploded);

        if ($last_param) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $exploded[] = $last_param;
        }

        return array($prefix, $command, $exploded);
    }

    /**
     * @param string              $command
     * @param string              $prefix
     * @param array               $params
     * @param ConnectionInterface $connection
     * @return GenericMessage
     */
    public function make($command, $prefix = "", array $params = array(), ConnectionInterface $connection = null)
    {
        $command = strtoupper($command);

        if (isset($this->constructors[$command])) {
            return $this->constructors[$command]($command, $prefix, $params, $connection);
        } else {
            $method = "construct" . substr($command, 0, 1) . substr($command, 1);
            if (method_exists($this, $method)) {
                return $this->{$method}($command, $prefix, $params, $connection);
            }
        }

        return new GenericMessage($command, $prefix, $params, $connection);
    }

    protected function constructPrivmsg($command, $prefix, $params, $connection)

    {
        return new PrivmsgMessage($prefix, $params, $connection);
    }

    protected function constructPing($command, $prefix, $params, $connection)
    {
        return new PingMessage($command, $prefix, $params, $connection);
    }

}


1			<?php
2			namespace Buttress\IRC\Message;
3
4			use Buttress\IRC\Connection\ConnectionInterface;
5
6			class MessageFactory
7			{
8
9			protected $constructors;
10
11			public function register($command, callable $generator)
12			{
13			$this->constructors[$command] = $generator;
14			}
15
16			/**
17			* @param string $raw
18			* @param ConnectionInterface $connection
19			* @return MessageInterface
20			*/
21			public function getMessageFromRaw($raw, ConnectionInterface $connection = null)
22			{
23			list($prefix, $command, $params) = $this->deconstructRaw($raw);
24			$message = $this->make($command, $prefix, $params, $connection);
25
26			return $message;
27			}
28
29			/**
30			* @param string $raw_message
31			*/
32			public function deconstructRaw($raw_message)
33			{
34			$prefix = "";
35
36			if (substr($raw_message, 0, 1) == ':') {
37			$prefix_end = strpos($raw_message, ' ');
38			$prefix = substr($raw_message, 1, $prefix_end - 1);
39			$raw = trim(substr($raw_message, $prefix_end + 1));
40			} else {
41			$raw = trim($raw_message);
42			}
43
44			$last_param = null;
45			if ($last_param_pos = strpos($raw, ' :')) {
46			$last_param = substr($raw, $last_param_pos + 2);
47			$raw = substr($raw, 0, $last_param_pos);
48			}
49
50			$exploded = explode(' ', $raw);
51			$command = array_shift($exploded);
52
53			if ($last_param) {
			0 ignored issues – show Bug Best Practice introduced 2017-02-22 21:07 UTC by Report Bug Copy Issue Report The expression `$last_param` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
54			$exploded[] = $last_param;
55			}
56
57			return array($prefix, $command, $exploded);
58			}
59
60			/**
61			* @param string $command
62			* @param string $prefix
63			* @param array $params
64			* @param ConnectionInterface $connection
65			* @return GenericMessage
66			*/
67			public function make($command, $prefix = "", array $params = array(), ConnectionInterface $connection = null)
68			{
69			$command = strtoupper($command);
70
71			if (isset($this->constructors[$command])) {
72			return $this->constructors[$command]($command, $prefix, $params, $connection);
73			} else {
74			$method = "construct" . substr($command, 0, 1) . substr($command, 1);
75			if (method_exists($this, $method)) {
76			return $this->{$method}($command, $prefix, $params, $connection);
77			}
78			}
79
80			return new GenericMessage($command, $prefix, $params, $connection);
81			}
82
83			protected function constructPrivmsg($command, $prefix, $params, $connection)
			0 ignored issues – show Unused Code introduced 2017-02-22 21:07 UTC by Report Bug Copy Issue Report The parameter `$command` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
84			{
85			return new PrivmsgMessage($prefix, $params, $connection);
86			}
87
88			protected function constructPing($command, $prefix, $params, $connection)
89			{
90			return new PingMessage($command, $prefix, $params, $connection);
91			}
92
93			}
94

Buttress / IRC

MessageFactory::constructPing() A last analyzed 2017-02-27 18:54 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MessageFactory::constructPing() A
last analyzed 2017-02-27 18:54 UTC