Buttress\IRC\Message\MessageFactory

Complexity

Total Complexity

11

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	4	1
A	getMessageFromRaw()	0	7	1
B	deconstructRaw()	0	27	4
A	make()	0	15	3
A	constructPrivmsg()	0	4	1
A	constructPing()	0	4	1

<?php
namespace Buttress\IRC\Message;

use Buttress\IRC\Connection\ConnectionInterface;

class MessageFactory
{

    protected $constructors;

    public function register($command, callable $generator)
    {
        $this->constructors[$command] = $generator;
    }

    /**
     * @param string              $raw
     * @param ConnectionInterface $connection
     * @return MessageInterface
     */
    public function getMessageFromRaw($raw, ConnectionInterface $connection = null)
    {
        list($prefix, $command, $params) = $this->deconstructRaw($raw);
        $message = $this->make($command, $prefix, $params, $connection);

        return $message;
    }

    /**
     * @param string $raw_message
     */
    public function deconstructRaw($raw_message)
    {
        $prefix = "";

        if (substr($raw_message, 0, 1) == ':') {
            $prefix_end = strpos($raw_message, ' ');
            $prefix = substr($raw_message, 1, $prefix_end - 1);
            $raw = trim(substr($raw_message, $prefix_end + 1));
        } else {
            $raw = trim($raw_message);
        }

        $last_param = null;
        if ($last_param_pos = strpos($raw, ' :')) {
            $last_param = substr($raw, $last_param_pos + 2);
            $raw = substr($raw, 0, $last_param_pos);
        }

        $exploded = explode(' ', $raw);
        $command = array_shift($exploded);

        if ($last_param) {

The expression $last_param of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $exploded[] = $last_param;
        }

        return array($prefix, $command, $exploded);
    }

    /**
     * @param string              $command
     * @param string              $prefix
     * @param array               $params
     * @param ConnectionInterface $connection
     * @return GenericMessage
     */
    public function make($command, $prefix = "", array $params = array(), ConnectionInterface $connection = null)
    {
        $command = strtoupper($command);

        if (isset($this->constructors[$command])) {
            return $this->constructors[$command]($command, $prefix, $params, $connection);
        } else {
            $method = "construct" . substr($command, 0, 1) . substr($command, 1);
            if (method_exists($this, $method)) {
                return $this->{$method}($command, $prefix, $params, $connection);
            }
        }

        return new GenericMessage($command, $prefix, $params, $connection);
    }

    protected function constructPrivmsg($command, $prefix, $params, $connection)

The parameter $command is not used and could be removed.

    {
        return new PrivmsgMessage($prefix, $params, $connection);
    }

    protected function constructPing($command, $prefix, $params, $connection)
    {
        return new PingMessage($command, $prefix, $params, $connection);
    }

}