BurningFlipside / VolunteerSystem

api/v1/class.ShiftAPI.php

Braces +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
     protected function canUpdate($request, $entity)
     {
  	if($this->isVolunteerAdmin($request))
-        {
+ 	{
             return true;
         }
         return $this->isUserDepartmentLead($entity['departmentID'], $this->user);

Indentation +5 added lines, -5 removed lines

@@ -31,7 +31,7 @@ 
 
     protected function canUpdate($request, $entity)
     {
- 	if($this->isVolunteerAdmin($request))
+        if($this->isVolunteerAdmin($request))
         {
             return true;
         }
@@ -51,7 +51,7 @@ 
         }
         if(!isset($obj['departmentID']))
         {
-             return false;
+                return false;
         }
         return $this->isUserDepartmentLead($obj['departmentID'], $this->user);
     }
@@ -117,8 +117,8 @@ 
             $ret = $dataTable->update($filter, $entArray[$i]);
             if($ret === false)
             {
-               $myRet = false;
-               array_push($errors, $array[$i]);
+                $myRet = false;
+                array_push($errors, $array[$i]);
             }
         }
         if($myRet)
@@ -206,7 +206,7 @@ 
         $entity = $this->processShift($entity, $request);
         if(isset($entity['minShifts']) && $entity['minShifts'] > 0)
         {
-          $shift->makeCopy($dataTable);
+            $shift->makeCopy($dataTable);
         }
         if(isset($entity['overlap']) && $entity['overlap'])
         {

api/v1/class.ParticipantAPI.php

Indentation +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
 
     protected function canUpdate($request, $entity)
     {
- 	if($this->isVolunteerAdmin($request))
+        if($this->isVolunteerAdmin($request))
         {
             return true;
         }       
@@ -83,7 +83,7 @@ 
         $odata = $request->getAttribute('odata', new \ODataParams(array()));
         $filter = $this->getFilterForPrimaryKey($uid);
         $areas = $dataTable->read($filter, $odata->select, $odata->top,
-                                  $odata->skip, $odata->orderby);
+                                    $odata->skip, $odata->orderby);
         if(empty($areas))
         {
             return $response->withStatus(404);

Braces +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     protected function canUpdate($request, $entity)
     {
  	if($this->isVolunteerAdmin($request))
-        {
+ 	{
             return true;
         }       
         //TODO give access to department lead

Spacing +10 added lines, -10 removed lines

@@ -106,24 +106,24 @@
         if($format === false || $format === 'text/calendar')
         {
             $text = "BEGIN:VCALENDAR\r\n";
-            $text.= "VERSION:2.0\r\n";
-            $text.= "PRODID:-//hacksw/handcal//NONSGML v1.0//EN\r\n";
+            $text .= "VERSION:2.0\r\n";
+            $text .= "PRODID:-//hacksw/handcal//NONSGML v1.0//EN\r\n";
             $count = count($shifts);
             for($i = 0; $i < $count; $i++)
             {
-                $text.= "BEGIN:VEVENT\r\n";
-                $text.= "UID:".$this->user->mail."\r\n";
+                $text .= "BEGIN:VEVENT\r\n";
+                $text .= "UID:".$this->user->mail."\r\n";
                 $d = new DateTime($shifts[$i]['startTime']);
                 $d->setTimezone(new \DateTimeZone('UTC'));
-                $text.= "DTSTAMP:".$d->format('Ymd\THis\Z')."\r\n";
-                $text.= "DTSTART:".$d->format('Ymd\THis\Z')."\r\n";
+                $text .= "DTSTAMP:".$d->format('Ymd\THis\Z')."\r\n";
+                $text .= "DTSTART:".$d->format('Ymd\THis\Z')."\r\n";
                 $d = new DateTime($shifts[$i]['endTime']);
                 $d->setTimezone(new \DateTimeZone('UTC'));
-                $text.= "DTEND:".$d->format('Ymd\THis\Z')."\r\n";
-                $text.= "SUMMARY:".$shifts[$i]['roleID'].' '.$shifts[$i]['name']."\r\n";
-                $text.= "END:VEVENT\r\n";
+                $text .= "DTEND:".$d->format('Ymd\THis\Z')."\r\n";
+                $text .= "SUMMARY:".$shifts[$i]['roleID'].' '.$shifts[$i]['name']."\r\n";
+                $text .= "END:VEVENT\r\n";
             }
-            $text.= "END:VCALENDAR\r\n";
+            $text .= "END:VCALENDAR\r\n";
             $response = $response->withHeader('Content-type', 'text/calendar');
             $response = $response->withHeader('Content-Disposition', 'attachment; filename="MyShifts.ics"');
             $body = $response->getBody();

api/v1/class.EventAPI.php

Indentation +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
 
     protected function canUpdate($request, $entity)
     {
- 	if($this->isVolunteerAdmin($request))
+        if($this->isVolunteerAdmin($request))
         {
             return true;
         }       
@@ -96,7 +96,7 @@ 
             }
         }
         $shifts = $dataTable->read($filter, $odata->select, $odata->top,
-                                  $odata->skip, $odata->orderby);
+                                    $odata->skip, $odata->orderby);
         if($shifts === false)
         {
             $shifts = array();

Braces +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     protected function canUpdate($request, $entity)
     {
  	if($this->isVolunteerAdmin($request))
-        {
+ 	{
             return true;
         }       
         return false;

app/VolunteerAutoload.php

Braces +11 added lines, -11 removed lines

@@ -1,29 +1,29 @@
 <?php

-function VolunteerAutoload($classname)

-{

+function VolunteerAutoload($classname)
+{
     $classname = str_replace('/', '\\', $classname);

     $classname = ltrim($classname, '\\');

     $filename  = '';

     $namespace = '';

-    if($lastNsPos = strrpos($classname, '\\'))

-    {

+    if($lastNsPos = strrpos($classname, '\\'))
+    {
         $namespace = substr($classname, 0, $lastNsPos);

         $classname = substr($classname, $lastNsPos + 1);

         $filename  = str_replace('\\', DIRECTORY_SEPARATOR, $namespace).DIRECTORY_SEPARATOR;

     }

     $filename = __DIR__.DIRECTORY_SEPARATOR.$filename.'class.'.$classname.'.php';

-    if(is_readable($filename))

-    {

+    if(is_readable($filename))
+    {
         require $filename;

     }

 }

 

-if(version_compare(PHP_VERSION, '5.3.0', '>='))

-{

+if(version_compare(PHP_VERSION, '5.3.0', '>='))
+{
     spl_autoload_register('VolunteerAutoload', true, true);

-}

-else

-{

+}
+else
+{
     spl_autoload_register('VolunteerAutoload');

 }

 /* vim: set tabstop=4 shiftwidth=4 expandtab: */

app/Schedules/class.GridSchedule.php

Indentation +17 added lines, -17 removed lines

@@ -46,17 +46,17 @@ 
         {
             for($j = 0; $j < $rowCount; $j++)
             {
-                 $cell = $sheat->getCellByColumnAndRow($i+2, $j+4);
-                 if($cell->isInMergeRange())
-                 {
-                      continue;
-                 }
-                 else
-                 {
-                     $style = $cell->getStyle();
-                     $style->getBorders()->getAllBorders()->setBorderStyle(false);
-                     $style->getFill()->setFillType(\PhpOffice\PhpSpreadsheet\Style\Fill::FILL_PATTERN_LIGHTGRAY);
-                 }
+                    $cell = $sheat->getCellByColumnAndRow($i+2, $j+4);
+                    if($cell->isInMergeRange())
+                    {
+                        continue;
+                    }
+                    else
+                    {
+                        $style = $cell->getStyle();
+                        $style->getBorders()->getAllBorders()->setBorderStyle(false);
+                        $style->getFill()->setFillType(\PhpOffice\PhpSpreadsheet\Style\Fill::FILL_PATTERN_LIGHTGRAY);
+                    }
             }
         }
     }
@@ -86,15 +86,15 @@ 
             $shifts[$i]['length'] = $diff->h;
             if(!isset($roles[$shifts[$i]['roleID']]))
             {
-                 $roles[$shifts[$i]['roleID']] = $shifts[$i]['length'];
-                 $roles2[$shifts[$i]['roleID']] = array();
+                    $roles[$shifts[$i]['roleID']] = $shifts[$i]['length'];
+                    $roles2[$shifts[$i]['roleID']] = array();
             }
             else
             {
-                 if($roles[$shifts[$i]['roleID']] < $shifts[$i]['length'])
-                 {
-                     $roles[$shifts[$i]['roleID']] = $shifts[$i]['length'];
-                 }
+                    if($roles[$shifts[$i]['roleID']] < $shifts[$i]['length'])
+                    {
+                        $roles[$shifts[$i]['roleID']] = $shifts[$i]['length'];
+                    }
             }
             array_push($roles2[$shifts[$i]['roleID']], array('start'=>$start, 'end'=>$end));
         }

Spacing +12 added lines, -12 removed lines

@@ -51,7 +51,7 @@ 
         {
             for($j = 0; $j < $rowCount; $j++)
             {
-                 $cell = $sheat->getCellByColumnAndRow($i+2, $j+4);
+                 $cell = $sheat->getCellByColumnAndRow($i + 2, $j + 4);
                  if($cell->isInMergeRange())
                  {
                       continue;
@@ -93,7 +93,7 @@ 
 
     protected function createShiftCell($sheat, $col, $row, $shift)
     {
-        $sheat->mergeCellsByColumnAndRow($col, $row, $col+$shift['length']-1, $row);
+        $sheat->mergeCellsByColumnAndRow($col, $row, $col + $shift['length'] - 1, $row);
         $this->setShiftNameInCell($sheat, $col, $row, $shift);
     }
 
@@ -101,21 +101,21 @@ 
     {
         $i = 1;
         $firstRow = array_search($roleID, $rows);
-        $cell = $sheat->getCellByColumnAndRow($col, $firstRow+4);
+        $cell = $sheat->getCellByColumnAndRow($col, $firstRow + 4);
         if($cell->isInMergeRange())
         {
-            while($rows[$firstRow+$i] === $roleID)
+            while($rows[$firstRow + $i] === $roleID)
             {
-                $cell = $sheat->getCellByColumnAndRow($col, $firstRow+4+$i);
+                $cell = $sheat->getCellByColumnAndRow($col, $firstRow + 4 + $i);
                 if(!$cell->isInMergeRange())
                 {
                     break;
                 }
                 $i++;
             }
-            return $firstRow+4+$i;
+            return $firstRow + 4 + $i;
         }
-        return $firstRow+4;
+        return $firstRow + 4;
     }
 
     protected function createSpreadSheet()
@@ -162,7 +162,7 @@ 
         $start = date_parse($str);
         $lastShift = $shifts[$count - 1];
         $interval = $lastShift['endTime']->diff($shifts[0]['startTime']);
-        $hourCount = ($interval->d*24) + $interval->h;
+        $hourCount = ($interval->d * 24) + $interval->h;
         $tmp = $this->getHoursArrays($start['hour'], $hourCount);
         $simpleHours = $tmp[0];
         $militaryHours = $tmp[1];
@@ -232,13 +232,13 @@ 
         while($shift)
         {
             $timeDiff = $originalStartTime->diff($shift['startTime']);
-            $hoursFromStart = ($timeDiff->d*24)+$timeDiff->h;
-            $rowForShift = $this->getRowForShift($shift['roleID'], $rows, $hoursFromStart+2, $sheat);
-            $this->createShiftCell($sheat, $hoursFromStart+2, $rowForShift, $shift);
+            $hoursFromStart = ($timeDiff->d * 24) + $timeDiff->h;
+            $rowForShift = $this->getRowForShift($shift['roleID'], $rows, $hoursFromStart + 2, $sheat);
+            $this->createShiftCell($sheat, $hoursFromStart + 2, $rowForShift, $shift);
             $shift = array_shift($shifts);
         }
         $rowCount = count($rows);
-        $style = $sheat->getStyleByColumnAndRow(2, 4, 1+count($simpleHours), 3 + $rowCount);
+        $style = $sheat->getStyleByColumnAndRow(2, 4, 1 + count($simpleHours), 3 + $rowCount);
         $style->getBorders()->getAllBorders()->setBorderStyle(\PhpOffice\PhpSpreadsheet\Style\Border::BORDER_THIN);
         $hourCount = count($simpleHours);
         $this->grayOutUnused($hourCount, $rowCount, $sheat);

api/v1/class.Processor.php

Doc Comments +6 added lines

@@ -12,6 +12,9 @@ 
 
     protected abstract function isVolunteerAdmin($request);
 
+    /**
+     * @param VolunteerProfile|null $user
+     */
     public function canUserDoRole($user, $role)
     {
         static $certs = null;
@@ -155,6 +158,9 @@ 
         return !in_array($deptId, $privateDepts);
     }
 
+    /**
+     * @param VolunteerShift $shift
+     */
     protected function doShiftTimeChecks($shift, $entry)
     {
         $now = new DateTime();

Indentation +5 added lines, -5 removed lines

@@ -47,10 +47,10 @@ 
         }
         for($i = 0; $i < $certCount; $i++)
         {
-             if($this->certCheck($requirements, $userCerts, $certs[$i]['certID']))
-             {
-                 return array('whyClass' => 'CERT', 'whyMsg' => 'Shift requires '.$certs[$i]['name'].' and you do not have that certification');
-             }
+                if($this->certCheck($requirements, $userCerts, $certs[$i]['certID']))
+                {
+                    return array('whyClass' => 'CERT', 'whyMsg' => 'Shift requires '.$certs[$i]['name'].' and you do not have that certification');
+                }
         }
         return true;
     }
@@ -188,7 +188,7 @@ 
             $tmp = $dataTable->read();
             foreach($tmp as $role)
             {
-               $roles[$role['short_name']] = $role;
+                $roles[$role['short_name']] = $role;
             }
         }
         $shift = new \VolunteerShift(false, $entry);

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
             try {
                 $profile = new \VolunteerProfile($uid);
                 $uids[$uid] = $profile->getDisplayName();
-            } catch (Exception $e) {
+            } catch(Exception $e) {
                 $uids[$uid] = $uid;
             }
         }

Braces +5 added lines, -2 removed lines

@@ -60,10 +60,13 @@
         static $uids = array();
         if(!isset($uids[$uid]))
         {
-            try {
+            try
+            {
                 $profile = new \VolunteerProfile($uid);
                 $uids[$uid] = $profile->getDisplayName();
-            } catch (Exception $e) {
+            }
+            catch (Exception $e)
+            {
                 $uids[$uid] = $uid;
             }
         }

app/Emails/class.PendingRejectedEmail.php

Doc Comments +3 added lines

@@ -3,6 +3,9 @@
 
 class PendingRejectedEmail extends VolunteerEmail
 {
+    /**
+     * @param \VolunteerProfile $userProfile
+     */
     public function __construct($userProfile)
     {
         parent::__construct($userProfile);

api/v1/class.DepartmentAPI.php

Indentation +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
         $filter = new \Data\Filter("departmentID eq '$deptId'");
         $odata = $request->getAttribute('odata', new \ODataParams(array()));
         $roles = $dataTable->read($filter, $odata->select, $odata->top,
-                                  $odata->skip, $odata->orderby);
+                                    $odata->skip, $odata->orderby);
         if($roles === false)
         {
             $roles = array();
@@ -114,7 +114,7 @@ 
             }
         }
         $shifts = $dataTable->read($filter, $odata->select, $odata->top,
-                                  $odata->skip, $odata->orderby);
+                                    $odata->skip, $odata->orderby);
         if($shifts === false)
         {
             $shifts = array();

signup.php

Indentation +55 added lines, -55 removed lines

@@ -5,19 +5,19 @@ 
 
 class ProcessorUser
 {
-  use Processor;
+    use Processor;
 
-  protected $isAdmin;
+    protected $isAdmin;
 
-  public function __construct($isAdmin)
-  {
-      $this->isAdmin = $isAdmin;
-  }
+    public function __construct($isAdmin)
+    {
+        $this->isAdmin = $isAdmin;
+    }
 
-  protected function isVolunteerAdmin()
-  {
-      return $this->isAdmin;
-  }
+    protected function isVolunteerAdmin()
+    {
+        return $this->isAdmin;
+    }
 }
 
 $page = new VolunteerPage('Burning Flipside - Flipside Volunteer System');
@@ -28,9 +28,9 @@ 
 
 if(!isset($_GET['shiftID']))
 {
-  $page->body .= 'Error! Missing Shift ID. You must have followed a bad link!';
-  $page->printPage();
-  return;
+    $page->body .= 'Error! Missing Shift ID. You must have followed a bad link!';
+    $page->printPage();
+    return;
 }
 
 $shiftID = $_GET['shiftID'];
@@ -39,9 +39,9 @@ 
 $shifts = $dataTable->read($filter);
 if(empty($shifts))
 {
-  $page->body .= 'Error! Could not locate shift. You must have followed an old link!';
-  $page->printPage();
-  return;
+    $page->body .= 'Error! Could not locate shift. You must have followed an old link!';
+    $page->printPage();
+    return;
 }
 $shift = $shifts[0];
 $myShift = new \VolunteerShift(false, $shift);
@@ -50,38 +50,38 @@ 
 
 if($processor->isAdminForShift($shift, $page->user))
 {
-  if(isset($shift['groupID']) && strlen($shift['groupID'] > 0))
-  {
+    if(isset($shift['groupID']) && strlen($shift['groupID'] > 0))
+    {
     $page->body .= '
     <div class="alert alert-info" role="alert">
       You are an administrator for this shift. You can edit the shift <a href="_admin/shifts.php?shiftID='.$shiftID.'" class="alert-link">here</a>.
       Or you can edit the shift group <a href="_admin/shifts.php?groupID='.$shift['groupID'].'" class="alert-link">here</a>.
     </div>
     ';
-  }
-  else
-  {
+    }
+    else
+    {
     $page->body .= '
     <div class="alert alert-info" role="alert">
       You are an administrator for this shift. You can edit the shift <a href="_admin/shifts.php?shiftID='.$shiftID.'" class="alert-link">here</a>.
     </div>
     ';
-  }
-  if(!isset($shift['participant']) || strlen($shift['participant']) === 0)
-  {
+    }
+    if(!isset($shift['participant']) || strlen($shift['participant']) === 0)
+    {
     $page->body .= '
     <div class="alert alert-info" role="alert">
       You are an administrator for this shift. You can assign someone to the shift, but it is highly recommended to let the users sign up. But if you are sure click <a href="#" onClick="showAdminSignup()" class="alert-link">here</a>.
     </div>
     ';
-  }
+    }
 }
 
 //Is shift already taken?
 if(isset($entry['status']) && ($entry['status'] === 'pending' || $entry['status'] === 'filled'))
 {
-  if(isset($shift['participant']) && $shift['participant'] === $page->user->uid)
-  {
+    if(isset($shift['participant']) && $shift['participant'] === $page->user->uid)
+    {
     $page->body .= '<div class="alert alert-success" role="alert">
       You already have this shift!
     </div>
@@ -89,15 +89,15 @@ 
       <button type="button" class="btn btn-secondary mr-auto" onClick="window.history.back();">Cancel</button>
       <button type="button" class="btn btn-primary" onclick="abandon();">Abandon Shift</button>
     </div>';
-  }
-  else
-  {
+    }
+    else
+    {
     $page->body .= '<div class="alert alert-danger" role="alert">
       Someone else took this shift!
     </div>';
-  }
-  $page->printPage();
-  return;
+    }
+    $page->printPage();
+    return;
 }
 
 $overlap = false;
@@ -122,46 +122,46 @@ 
 $depts = $dataTable->read(new \Data\Filter('departmentID eq '.$shift['departmentID']));
 if(!empty($depts))
 {
-  $deptName = $depts[0]['departmentName'];
+    $deptName = $depts[0]['departmentName'];
 }
 
 $dataTable = DataSetFactory::getDataTableByNames('fvs', 'events');
 $events = $dataTable->read(new \Data\Filter('_id eq '.$shift['eventID']));
 if(!empty($events))
 {
-  if($events[0]['tickets'])
-  {
+    if($events[0]['tickets'])
+    {
     //TODO... Event requires tickets. Does this account have tickets?
-  }
+    }
 }
 
 $dataTable = DataSetFactory::getDataTableByNames('fvs', 'roles');
 $roles = $dataTable->read(new \Data\Filter('short_name eq '.$shift['roleID']));
 if(!empty($roles))
 {
-  $roleName = $roles[0]['display_name'];
+    $roleName = $roles[0]['display_name'];
 }
 
 //Is user eligible for shift?
 $canDo = $processor->canUserDoRole($profile, $roles[0]);
 if($canDo !== true)
 {
-  $page->body .= '<div class="alert alert-danger" role="alert">';
-  switch($canDo['whyClass'])
-  {
+    $page->body .= '<div class="alert alert-danger" role="alert">';
+    switch($canDo['whyClass'])
+    {
     case 'INVITE':
       $page->body .= 'This shift requires an invite from the department lead. If you think you should have recieved such an invite please <a href="https://www.burningflipside.com/contact" class="alert-link">contact the lead</a>.';
-      break;
+        break;
     case 'CERT':
        $page->body .= $canDo['whyMsg'].' If you have this certification it is not recorded in your profile. You can <a href="certiciation.php" class="alert-link">record that certification</a> to sign up.';
-       break;
+        break;
     default:
       $page->body .= 'You are not eligible for this shift because: '.$canDo['whyMsg'];
-      break;
-  }
-  $page->body .= '</div>';
-  $page->printPage();
-  return;  
+        break;
+    }
+    $page->body .= '</div>';
+    $page->printPage();
+    return;  
 }
 
 $start = new \DateTime($shift['startTime']);
@@ -172,7 +172,7 @@ 
 $page->body .= '<div id="signupContent" ';
 if($overlap)
 {
-  $page->body .= 'class="d-none" ';
+    $page->body .= 'class="d-none" ';
 }
 $page->body .= '/>';
 $page->body .= '
@@ -212,7 +212,7 @@ 
 
 if($processor->isAdminForShift($shift, $page->user) && (!isset($shift['participant']) || strlen($shift['participant']) === 0))
 {
-  $page->body .= '
+    $page->body .= '
   <div class="row d-none" id="adminSignup">
     <div class="alert alert-danger" role="alert">
       First off, make sure you understand what this will do. While it will let you fill out the details for a shift, it will prevent the user from seeing the shift on their list when the log it, it will not be correctly reported for t-shirts or for rock star volunteers, their camp will not be listed on the shift schedule, and the ability to contact past volunteers will not work for anyone signed up in this manner. Basically, doing this removes about 90% of the advantage of using this system. So please only do this if participant in question is unable to sign up on their own.
@@ -229,12 +229,12 @@ 
 //Is group eligible?
 if(isset($shift['groupID']) && isset($roles[0]['groups_allowed']) && $roles[0]['groups_allowed'])
 {
-  $page->body .= '<div id="groupContent" ';
-  if($overlap)
-  {
+    $page->body .= '<div id="groupContent" ';
+    if($overlap)
+    {
     $page->body .= 'class="d-none" ';
-  }
-  $page->body .= '>
+    }
+    $page->body .= '>
   <div class="row">
     <div class="alert alert-primary" role="alert">
       You have selected a group eligible shift. This means you can generate a link for your friends to sign up on the shift with you. Would you like to sign up for the shift and generate that link now?