Completed
Branch fix/scruitinizer (9076a5)
by Patrick
04:36 queued 01:56
created
api/v1/class.GroupsAPI.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -49,6 +49,9 @@
 block discarded – undo
49 49
         return $response->withJson($groups);
50 50
     }
51 51
 
52
+    /**
53
+     * @param boolean $directOnly
54
+     */
52 55
     private function expandGroupMembers($group, $odata, $directOnly)
53 56
     {
54 57
         if($odata->expand !== false && in_array('member', $odata->expand))
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         $auth = AuthProvider::getInstance();
46 46
         $odata = $request->getAttribute('odata', new \ODataParams(array()));
47 47
         $groups = $auth->getGroupsByFilter($odata->filter, $odata->select, $odata->top, $odata->skip, 
48
-                                           $odata->orderby);
48
+                                            $odata->orderby);
49 49
         return $response->withJson($groups);
50 50
     }
51 51
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@
 block discarded – undo
104 104
         return $response->withJson($group);
105 105
     }
106 106
 
107
-    protected function serializeArray(&$res, $array, $keys, $type=false)
107
+    protected function serializeArray(&$res, $array, $keys, $type = false)
108 108
     {
109 109
         $count = count($array);
110 110
         for($i = 0; $i < $count; $i++)
Please login to merge, or discard this patch.
api/v1/class.UsersAPI.php 2 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -52,6 +52,9 @@  discard block
 block discarded – undo
52 52
         return $response->withJson($users);
53 53
     }
54 54
 
55
+    /**
56
+     * @param boolean $message
57
+     */
55 58
     protected function validateCanCreateUser($proposedUser, $auth, &$message)
56 59
     {
57 60
         $user = $auth->getUsersByFilter(new \Data\Filter('mail eq '.$proposedUser->mail));
@@ -367,6 +370,10 @@  discard block
 block discarded – undo
367 370
         return $response->withJson(array('success'=>true));
368 371
     }
369 372
 
373
+    /**
374
+     * @param Data\Filter $filter
375
+     * @param boolean $pending
376
+     */
370 377
     protected function getAllUsersByFilter($filter, &$pending)
371 378
     {
372 379
         $auth = AuthProvider::getInstance();
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
         {
48 48
             $auth = AuthProvider::getInstance();
49 49
             $users = $auth->getUsersByFilter($odata->filter, $odata->select, $odata->top, $odata->skip, 
50
-                                             $odata->orderby);
50
+                                                $odata->orderby);
51 51
         }
52 52
         return $response->withJson($users);
53 53
     }
Please login to merge, or discard this patch.
api/v1/class.AreasAPI.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
         $dataTable = DataSetFactory::getDataTableByNames('profiles', 'position');
44 44
         $odata = $request->getAttribute('odata', new \ODataParams(array()));
45 45
         $leads = $dataTable->read(new \Data\Filter("area eq '".$args['name']."'"), $odata->select, $odata->top,
46
-                                  $odata->skip, $odata->orderby);
46
+                                    $odata->skip, $odata->orderby);
47 47
         if(empty($leads))
48 48
         {
49 49
             return $response->withStatus(404);
Please login to merge, or discard this patch.
oauth2callback.php 1 patch
Switch Indentation   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -51,21 +51,21 @@  discard block
 block discarded – undo
51 51
 
52 52
 switch($src)
53 53
 {
54
-    case 'google':
55
-        doAuthByType('Auth\GoogleAuthenticator', $src);
56
-        break;
57
-    case 'twitter':
58
-        $twitter = $auth->getMethodByName('Auth\TwitterAuthenticator');
59
-        if(!isset($_GET['oauth_token']) || !isset($_GET['oauth_verifier']))
60
-        {
61
-            $twitter->redirect();
62
-            die();
63
-        }
64
-        else
65
-        {
66
-            $twitter->authenticate($_GET['oauth_token'], $_GET['oauth_verifier'], $current_user);
67
-            switch($res)
54
+        case 'google':
55
+            doAuthByType('Auth\GoogleAuthenticator', $src);
56
+            break;
57
+        case 'twitter':
58
+            $twitter = $auth->getMethodByName('Auth\TwitterAuthenticator');
59
+            if(!isset($_GET['oauth_token']) || !isset($_GET['oauth_verifier']))
60
+            {
61
+                $twitter->redirect();
62
+                die();
63
+            }
64
+            else
68 65
             {
66
+                $twitter->authenticate($_GET['oauth_token'], $_GET['oauth_verifier'], $current_user);
67
+                switch($res)
68
+                {
69 69
                 case \Auth\Authenticator::SUCCESS:
70 70
                     header('Location: '.$ref);
71 71
                     die();
@@ -76,15 +76,15 @@  discard block
 block discarded – undo
76 76
                 case \Auth\Authenticator::ALREADY_PRESENT:
77 77
                     header('Location: user_exists.php?src=twitter&uid='.$current_user->uid);
78 78
                     die();
79
-            }
79
+                }
80 80
         }
81 81
         break;
82
-    case 'gitlab':
83
-        doAuthByType('Auth\OAuth2\GitLabAuthenticator', $src);
84
-        break;
85
-        //Generic OAuth...
86
-    default:
87
-        print_r($_SERVER);
88
-        break;
82
+        case 'gitlab':
83
+            doAuthByType('Auth\OAuth2\GitLabAuthenticator', $src);
84
+            break;
85
+            //Generic OAuth...
86
+        default:
87
+            print_r($_SERVER);
88
+            break;
89 89
 }
90 90
 /* vim: set tabstop=4 shiftwidth=4 expandtab: */
Please login to merge, or discard this patch.