Process::__construct() - Code Metrics - Inspection of "Bump2" - Bit-Wasp/pinentry - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by thomas

created 2018-12-22 15:55 UTC

Process::__construct() A

↳ Parent: Process

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	2
nop	2
dl	0
loc	10
ccs	0
cts	0
cp	0
crap	12
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace BitWasp\PinEntry\Process;

use BitWasp\PinEntry\Exception;

class Process implements ProcessInterface
{
    /**
     * @var resource A 'process' resource
     */
    private $process;

    /**
     * @var IPC -
     */
    private $ipc;

    /**
     * @var bool
     */
    private $running = true;

    public function __construct(string $executable, array $overrideDescriptors = [])
    {
        $pipes = [];
        $process = proc_open($executable, IPC::buildDescriptors($overrideDescriptors), $pipes);
        if (!(is_resource($process) && get_resource_type($process) === "process")) {
            throw new Exception\PinEntryException("Failed to start process");
        }

        $this->ipc = new IPC($pipes);
        $this->process = $process;
    }

    public function __destruct()
    {
        $this->close();
    }

    public function close(): bool
    {
        if ($this->running) {
            $this->stopRunning();
        }
        return true;
    }

    /**
     * Called during shutdown routine. Per documentation,
     * file handles should be closed before we call proc_close
     */
    private function stopRunning()
    {
        $this->ipc->close();
        proc_close($this->process);
        $this->running = false;
    }

    public function getStatus(): array
    {
        return proc_get_status($this->process);

    }

    public function send(string $data)
    {
        $this->ipc->send($data);
    }

    public function recv(): string
    {
        return $this->ipc->readStdOut();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace BitWasp\PinEntry\Process;
6
7			use BitWasp\PinEntry\Exception;
8
9			class Process implements ProcessInterface
10			{
11			/**
12			* @var resource A 'process' resource
13			*/
14			private $process;
15
16			/**
17			* @var IPC -
18			*/
19			private $ipc;
20
21			/**
22			* @var bool
23			*/
24			private $running = true;
25
26			public function __construct(string $executable, array $overrideDescriptors = [])
27			{
28			$pipes = [];
29			$process = proc_open($executable, IPC::buildDescriptors($overrideDescriptors), $pipes);
30			if (!(is_resource($process) && get_resource_type($process) === "process")) {
31			throw new Exception\PinEntryException("Failed to start process");
32			}
33
34			$this->ipc = new IPC($pipes);
35			$this->process = $process;
36			}
37
38			public function __destruct()
39			{
40			$this->close();
41			}
42
43			public function close(): bool
44			{
45			if ($this->running) {
46			$this->stopRunning();
47			}
48			return true;
49			}
50
51			/**
52			* Called during shutdown routine. Per documentation,
53			* file handles should be closed before we call proc_close
54			*/
55			private function stopRunning()
56			{
57			$this->ipc->close();
58			proc_close($this->process);
59			$this->running = false;
60			}
61
62			public function getStatus(): array
63			{
64			return proc_get_status($this->process);
			0 ignored issues – show Bug Best Practice introduced 2018-12-22 15:53 UTC by Report Bug Copy Issue Report The expression `return proc_get_status($this->process)` could return the type `false` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
65			}
66
67			public function send(string $data)
68			{
69			$this->ipc->send($data);
70			}
71
72			public function recv(): string
73			{
74			return $this->ipc->readStdOut();
75			}
76			}
77

Bit-Wasp / pinentry

Pull Request — master (#3)

Process::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like