BitWasp\PinEntry\Process\Process

Complexity

Total Complexity

10

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getStatus()	0	3	1
A	recv()	0	3	1
A	stopRunning()	0	5	1
A	close()	0	6	2
A	send()	0	3	1
A	__destruct()	0	3	1
A	__construct()	0	10	3

<?php

declare(strict_types=1);

namespace BitWasp\PinEntry\Process;

use BitWasp\PinEntry\Exception;

class Process implements ProcessInterface
{
    /**
     * @var resource A 'process' resource
     */
    private $process;

    /**
     * @var IPC -
     */
    private $ipc;

    /**
     * @var bool
     */
    private $running = true;

    public function __construct(string $executable, array $overrideDescriptors = [])
    {
        $pipes = [];
        $process = proc_open($executable, IPC::buildDescriptors($overrideDescriptors), $pipes);
        if (!(is_resource($process) && get_resource_type($process) === "process")) {
            throw new Exception\PinEntryException("Failed to start process");
        }

        $this->ipc = new IPC($pipes);
        $this->process = $process;
    }

    public function __destruct()
    {
        $this->close();
    }

    public function close(): bool
    {
        if ($this->running) {
            $this->stopRunning();
        }
        return true;
    }

    /**
     * Called during shutdown routine. Per documentation,
     * file handles should be closed before we call proc_close
     */
    private function stopRunning()
    {
        $this->ipc->close();
        proc_close($this->process);
        $this->running = false;
    }

    public function getStatus(): array
    {
        return proc_get_status($this->process);

The expression return proc_get_status($this->process) could return the type false which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    public function send(string $data)
    {
        $this->ipc->send($data);
    }

    public function recv(): string
    {
        return $this->ipc->readStdOut();
    }
}