Completed
Pull Request — master (#258)
by thomas
39:16 queued 35:48
created
src/Crypto/EcAdapter/Impl/PhpEcc/Adapter/EcAdapter.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -279,8 +279,8 @@  discard block
 block discarded – undo
279 279
     /**
280 280
      * Attempt to calculate the public key recovery param by trial and error
281 281
      *
282
-     * @param int|string     $r
283
-     * @param int|string     $s
282
+     * @param integer     $r
283
+     * @param integer     $s
284 284
      * @param Buffer $messageHash
285 285
      * @param PublicKey $publicKey
286 286
      * @return int
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
     }
350 350
 
351 351
     /**
352
-     * @param int|string $element
352
+     * @param string $element
353 353
      * @param bool $half
354 354
      * @return bool
355 355
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 use \BitWasp\Bitcoin\Crypto\EcAdapter\Impl\Secp256k1\Adapter\EcAdapter as Secp256k1Adapter;
15 15
 use BitWasp\Bitcoin\Transaction\SignatureHash\SignatureHashInterface;
16 16
 use BitWasp\Bitcoin\Transaction\TransactionInterface;
17
-use BitWasp\Buffertools\Buffer;
18 17
 use BitWasp\Buffertools\BufferInterface;
19 18
 
20 19
 class TxSigner
Please login to merge, or discard this patch.
src/Crypto/Hash.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
      * @param string $algo
116 116
      * @param BufferInterface $data
117 117
      * @param BufferInterface $salt
118
-     * @return BufferInterface
118
+     * @return EcAdapter\Adapter\EcAdapterInterface
119 119
      */
120 120
     public static function hmac($algo, BufferInterface $data, BufferInterface $salt)
121 121
     {
Please login to merge, or discard this patch.
src/Transaction/Factory/TxBuilder.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     }
102 102
 
103 103
     /**
104
-     * @param BufferInterface|string $hashPrevOut
104
+     * @param BufferInterface $hashPrevOut
105 105
      * @param int $nPrevOut
106 106
      * @param Script|null $script
107 107
      * @param int $nSequence
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     }
136 136
 
137 137
     /**
138
-     * @param int|string $value
138
+     * @param integer $value
139 139
      * @param ScriptInterface $script
140 140
      * @return $this
141 141
      */
Please login to merge, or discard this patch.
src/Script/Interpreter/Stack.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
     }
18 18
 
19 19
     /**
20
-     * @param mixed $value
20
+     * @param BufferInterface $value
21 21
      * @throws \InvalidArgumentException
22 22
      */
23 23
     private function typeCheck($value)
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
     }
128 128
 
129 129
     /**
130
-     * @param $length
130
+     * @param integer $length
131 131
      * @return $this
132 132
      */
133 133
     public function resize($length)
Please login to merge, or discard this patch.
src/Transaction/Factory/InputSigner.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      * @param ScriptInterface $scriptCode
101 101
      * @param BufferInterface[] $stack
102 102
      * @param int $sigVersion
103
-     * @return mixed
103
+     * @return string
104 104
      */
105 105
     public function extractFromValues($type, ScriptInterface $scriptCode, array $stack, $sigVersion)
106 106
     {
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
     }
259 259
 
260 260
     /**
261
-     * @return int
261
+     * @return boolean
262 262
      */
263 263
     public function isFullySigned()
264 264
     {
@@ -428,7 +428,7 @@  discard block
 block discarded – undo
428 428
     }
429 429
 
430 430
     /**
431
-     * @param $outputType
431
+     * @param string $outputType
432 432
      * @param $answer
433 433
      * @return bool
434 434
      */
Please login to merge, or discard this patch.
src/Transaction/Mutator/WitnessCollectionMutator.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,8 +60,8 @@
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param int|string $start
64
-     * @param int|string $length
63
+     * @param integer $start
64
+     * @param integer $length
65 65
      * @return $this
66 66
      */
67 67
     public function slice($start, $length)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace BitWasp\Bitcoin\Transaction\Mutator;
4 4
 
5 5
 use BitWasp\Bitcoin\Collection\MutableCollection;
6
-use BitWasp\Bitcoin\Collection\Transaction\TransactionInputCollection;
7 6
 use BitWasp\Bitcoin\Collection\Transaction\TransactionWitnessCollection;
8 7
 use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
9
-use BitWasp\Bitcoin\Transaction\TransactionInputInterface;
10 8
 
11 9
 class WitnessCollectionMutator extends MutableCollection
12 10
 {
Please login to merge, or discard this patch.