Completed
Pull Request — master (#403)
by thomas
23:44
created

5,350 +96 Covered Lines

6,462 +24 Total Lines

82.8 % +1.2% Code Coverage

PHP Classes Changes

18.75%
100%
SignatureSort improved
18.18%
81.82%
ScriptWitness improved
51.85%
100%
SignData improved
67.44%
100%
PublicKeySerializer improved
86.69%
96.79%
InputSigner improved
77.22%
69.62%
TxBuilder got worse
96.97%
89.66%
Signer got worse
81.72%
84.62%
Transaction improved
91.67%
88.89%
InputCollectionMutator got worse
72.72%
70%
BitcoinConsensus got worse
view more  
46.67%
 
Validator removed

CRAP Changes

 
6
InputSigner::verify() added
 
3.1406
Signer::input() added
 
3.0175
InputSigner::calculateSigHashUnsafe() added
 
1
InputSigner::getSigHash() added
 
1
Script::getWitnessScriptHash() added
3.0017
3
InputSigner::__construct() improved
1.0156
1
PublicKeySerializer::__construct() improved
10.0203
10
InputSigner::extractSignatures() improved
2
2.0625
InputCollectionMutator::offsetGet() got worse
2.0625
2
SignData::getRedeemScript() improved
2.0625
2
SignData::getWitnessScript() improved
2.0758
2
PublicKeySerializer::doSerialize() improved
12.1081
12.032
Interpreter::verifyWitnessProgram() improved
7.0957
7.0119
Script::countP2shSigOps() improved
1.125
1
PublicKeySerializer::serialize() improved
view more  
20
 
Validator::checkSignatures() removed
3.0175
 
InputSigner::calculateSigHash() removed
2
 
Signer::signer() removed
2
 
Validator::checkSignature() removed
1
 
Transaction::validator() removed
1
 
Validator::__construct() removed