Completed
Pull Request — master (#403)
by thomas
31:50
created

5,355 +101 Covered Lines

6,469 +31 Total Lines

82.8 % +1.2% Code Coverage

PHP Classes Changes

18.75%
100%
SignatureSort improved
18.18%
81.82%
ScriptWitness improved
51.85%
100%
SignData improved
86.69%
96.79%
InputSigner improved
96.97%
89.66%
Signer got worse
81.72%
84.62%
Transaction improved
72.72%
70%
BitcoinConsensus got worse
68%
69.61%
Script improved
88.31%
89.61%
Number improved
75.64%
75.94%
Checker improved
view more  
46.67%
 
Validator removed

CRAP Changes

 
6
InputSigner::verify() added
 
3.1406
Signer::input() added
 
3.0175
InputSigner::calculateSigHashUnsafe() added
 
1
Script::getWitnessScriptHash() added
 
1
InputSigner::getSigHash() added
3.0017
3
InputSigner::__construct() improved
10.0203
10
InputSigner::extractSignatures() improved
2.0625
2
SignData::getRedeemScript() improved
2.0625
2
SignData::getWitnessScript() improved
12.1081
12.032
Interpreter::verifyWitnessProgram() improved
7.0957
7.0119
Script::countP2shSigOps() improved
8.1515
8.0189
Number::buffer() improved
10.9037
10
InputSigner::solve() improved
2
1
SignData::hasRedeemScript() improved
2
1
SignData::hasWitnessScript() improved
view more  
20
 
Validator::checkSignatures() removed
3.0175
 
InputSigner::calculateSigHash() removed
2
 
Validator::checkSignature() removed
2
 
Signer::signer() removed
1
 
Validator::__construct() removed
1
 
Transaction::validator() removed