Completed
Pull Request — master (#593)
by thomas
15:02
created

5,204 -585 Covered Lines

6,677 +25 Total Lines

77.9 % -9.1% Code Coverage

PHP Classes Changes

 
72.29%
CheckerBase added
100%
0%
SigValues got worse
90%
0%
TimeLock got worse
100%
11.54%
Signer got worse
82.61%
0%
Conditional got worse
64.29%
0%
BitcoinCashChecker got worse
60%
0%
ScriptWitness got worse
80%
20%
CheckLocktimeVerify got worse
94.84%
36.21%
InputSigner got worse
88.66%
35.05%
Checksig got worse
57.14%
17.86%
CheckSequenceVerify got worse
view more  

CRAP Changes

 
56
CheckerBase::checkLockTime() added
 
33.2361
CheckerBase::checkSequence() added
 
8
CheckerBase::checkSignatureEncoding() added
 
6
Signer::setCheckerCreator() added
 
3
CheckerBase::checkPublicKeyEncoding() added
 
3
CheckerBase::checkSig() added
 
3
CheckerBase::__construct() added
 
2.5
InputSigner::checkSignature() added
 
2
CheckerBase::isDefinedHashtype() added
 
2
CheckerBase::isDefinedHashtypeSignature() added
view more  
3
3.0017
DerSignatureSerializer::serialize() got worse
6
6.0106
InputSigner::ensureAcceptableScripts() got worse
2
2.0116
Signer::__construct() got worse
3
3.0261
TxSigHashSerializer::serializeOutput() got worse
3
3.0261
V1Hasher::hashPrevOuts() got worse
6
6.0359
InputSigner::classifySignStep() got worse
5
5.0488
PayToPubkeyHash::fromDecodedScript() got worse
5
5.0729
V1Hasher::hashSequences() got worse
5
5.1158
InputSigner::sortMultisigs() got worse
6
6.1308
TxSigHashSerializer::serializeInput() got worse
view more  
8.0189
 
Checker::checkSequence() removed
8
 
Checker::checkSignatureEncoding() removed
7
 
Checker::checkLockTime() removed
3
 
Checker::checkPublicKeyEncoding() removed
3
 
Checker::checkSig() removed
3
 
Checker::__construct() removed
2
 
Checker::isDefinedHashtype() removed
2
 
Checker::isDefinedHashtypeSignature() removed
2
 
Checker::isValidSignatureEncoding() removed
2
 
Checker::isLowDerSignature() removed
view more