Complex classes like HierarchicalKey often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HierarchicalKey, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
20 | class HierarchicalKey |
||
21 | { |
||
22 | /** |
||
23 | * @var EcAdapterInterface |
||
24 | */ |
||
25 | private $ecAdapter; |
||
26 | |||
27 | /** |
||
28 | * @var int |
||
29 | */ |
||
30 | private $depth; |
||
31 | |||
32 | /** |
||
33 | * @var int |
||
34 | */ |
||
35 | private $parentFingerprint; |
||
36 | |||
37 | /** |
||
38 | * @var int |
||
39 | */ |
||
40 | private $sequence; |
||
41 | |||
42 | /** |
||
43 | * @var BufferInterface |
||
44 | */ |
||
45 | private $chainCode; |
||
46 | |||
47 | /** |
||
48 | * @var PublicKeyInterface|PrivateKeyInterface |
||
49 | */ |
||
50 | private $key; |
||
51 | |||
52 | /** |
||
53 | * @param EcAdapterInterface $ecAdapter |
||
54 | * @param int $depth |
||
55 | * @param int $parentFingerprint |
||
56 | * @param int $sequence |
||
57 | * @param BufferInterface $chainCode |
||
58 | * @param KeyInterface $key |
||
59 | * @throws \Exception |
||
60 | */ |
||
61 | 52 | public function __construct(EcAdapterInterface $ecAdapter, int $depth, int $parentFingerprint, int $sequence, BufferInterface $chainCode, KeyInterface $key) |
|
62 | { |
||
63 | 52 | if ($depth < 0 || $depth > IntRange::U8_MAX) { |
|
64 | throw new \InvalidArgumentException('Invalid depth for BIP32 key, must be in range [0 - 255] inclusive'); |
||
65 | } |
||
66 | |||
67 | 52 | if ($parentFingerprint < 0 || $parentFingerprint > IntRange::U32_MAX) { |
|
68 | throw new \InvalidArgumentException('Invalid fingerprint for BIP32 key, must be in range [0 - (2^31)-1] inclusive'); |
||
69 | } |
||
70 | |||
71 | 52 | if ($sequence < 0 || $sequence > IntRange::U32_MAX) { |
|
72 | throw new \InvalidArgumentException('Invalid sequence for BIP32 key, must be in range [0 - (2^31)-1] inclusive'); |
||
73 | } |
||
74 | |||
75 | 52 | if ($chainCode->getSize() !== 32) { |
|
76 | throw new \RuntimeException('Chaincode should be 32 bytes'); |
||
77 | } |
||
78 | |||
79 | 52 | if (!$key->isCompressed()) { |
|
80 | 1 | throw new \InvalidArgumentException('A HierarchicalKey must always be compressed'); |
|
81 | } |
||
82 | |||
83 | 51 | $this->ecAdapter = $ecAdapter; |
|
84 | 51 | $this->depth = $depth; |
|
85 | 51 | $this->sequence = $sequence; |
|
86 | 51 | $this->parentFingerprint = $parentFingerprint; |
|
87 | 51 | $this->chainCode = $chainCode; |
|
88 | 51 | $this->key = $key; |
|
|
|||
89 | 51 | } |
|
90 | |||
91 | /** |
||
92 | * Return the depth of this key. This is limited to 256 sequential derivations. |
||
93 | * |
||
94 | * @return int |
||
95 | */ |
||
96 | 17 | public function getDepth(): int |
|
97 | { |
||
98 | 17 | return $this->depth; |
|
99 | } |
||
100 | |||
101 | /** |
||
102 | * Get the sequence number for this address. Hardened keys are |
||
103 | * created with sequence > 0x80000000. a sequence number lower |
||
104 | * than this can be derived with the public key. |
||
105 | * |
||
106 | * @return int |
||
107 | */ |
||
108 | 12 | public function getSequence(): int |
|
112 | |||
113 | /** |
||
114 | * Get the fingerprint of the parent key. For master keys, this is 00000000. |
||
115 | * |
||
116 | * @return int |
||
117 | */ |
||
118 | 13 | public function getFingerprint(): int |
|
126 | |||
127 | /** |
||
128 | * Return the fingerprint to be used for child keys. |
||
129 | * @return int |
||
130 | */ |
||
131 | 14 | public function getChildFingerprint(): int |
|
136 | |||
137 | /** |
||
138 | * Return the chain code - a deterministic 'salt' for HMAC-SHA512 |
||
139 | * in child derivations |
||
140 | * |
||
141 | * @return BufferInterface |
||
142 | */ |
||
143 | 11 | public function getChainCode(): BufferInterface |
|
147 | |||
148 | /** |
||
149 | * @return PrivateKeyInterface |
||
150 | */ |
||
151 | 23 | public function getPrivateKey(): PrivateKeyInterface |
|
159 | |||
160 | /** |
||
161 | * Get the public key the private key or public key. |
||
162 | * |
||
163 | * @return PublicKeyInterface |
||
164 | */ |
||
165 | 25 | public function getPublicKey(): PublicKeyInterface |
|
173 | |||
174 | /** |
||
175 | * @return HierarchicalKey |
||
176 | */ |
||
177 | 9 | public function withoutPrivateKey(): HierarchicalKey |
|
183 | |||
184 | /** |
||
185 | * Return whether this is a private key |
||
186 | * |
||
187 | * @return bool |
||
188 | */ |
||
189 | 29 | public function isPrivate(): bool |
|
193 | |||
194 | /** |
||
195 | * Return whether the key is hardened |
||
196 | * |
||
197 | * @return bool |
||
198 | */ |
||
199 | 2 | public function isHardened(): bool |
|
203 | |||
204 | /** |
||
205 | * Create a buffer containing data to be hashed hashed to yield the child offset |
||
206 | * |
||
207 | * @param int $sequence |
||
208 | * @return BufferInterface |
||
209 | * @throws \Exception |
||
210 | */ |
||
211 | 20 | public function getHmacSeed(int $sequence): BufferInterface |
|
229 | |||
230 | /** |
||
231 | * Derive a child key |
||
232 | * |
||
233 | * @param int $sequence |
||
234 | * @return HierarchicalKey |
||
235 | * @throws \Exception |
||
236 | */ |
||
237 | 17 | public function deriveChild(int $sequence): HierarchicalKey |
|
264 | |||
265 | /** |
||
266 | * @param array|\stdClass|\Traversable $list |
||
267 | * @return HierarchicalKey |
||
268 | */ |
||
269 | 7 | public function deriveFromList($list): HierarchicalKey |
|
282 | |||
283 | /** |
||
284 | * Decodes a BIP32 path into actual 32bit sequence numbers and derives the child key |
||
285 | * |
||
286 | * @param string $path |
||
287 | * @return HierarchicalKey |
||
288 | * @throws \Exception |
||
289 | */ |
||
290 | 7 | public function derivePath(string $path): HierarchicalKey |
|
295 | |||
296 | /** |
||
297 | * Serializes the instance according to whether it wraps a private or public key. |
||
298 | * @param NetworkInterface $network |
||
299 | * @return string |
||
300 | */ |
||
301 | 11 | public function toExtendedKey(NetworkInterface $network = null): string |
|
309 | |||
310 | /** |
||
311 | * Explicitly serialize as a private key. Throws an exception if |
||
312 | * the key isn't private. |
||
313 | * |
||
314 | * @param NetworkInterface $network |
||
315 | * @return string |
||
316 | */ |
||
317 | 11 | public function toExtendedPrivateKey(NetworkInterface $network = null): string |
|
325 | |||
326 | /** |
||
327 | * Explicitly serialize as a public key. This will always work. |
||
328 | * |
||
329 | * @param NetworkInterface $network |
||
330 | * @return string |
||
331 | */ |
||
332 | 9 | public function toExtendedPublicKey(NetworkInterface $network = null): string |
|
339 | } |
||
340 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..