Completed
Pull Request — master (#239)
by thomas
31:39 queued 14:06
created

5,769 +572 Covered Lines

6,830 +796 Total Lines

84.5 % -1.7% Code Coverage

PHP Classes Changes

 
0%
WitnessPubKeyHashAddress added
 
0%
WitnessScriptHash added
 
0%
WitnessCollectionMutator added
 
52.94%
ScriptWitnessSerializer added
 
57.14%
TransactionWitnessCollection added
 
57.58%
OldTransactionSerializer added
 
60.76%
Checker added
 
61.29%
ScriptWitness added
 
61.53%
WitnessProgram added
 
94.2%
InputSigner added
view more  
0%
46.67%
Validator improved
100%
75.31%
TransactionSerializer got worse
100%
75.51%
Script got worse
100%
84.62%
Network got worse
75.38%
84.49%
Interpreter improved
55.56%
50%
P2shScriptFactory got worse
97.06%
91.67%
OutputClassifier got worse
84.21%
79.07%
NetworkFactory got worse
69.23%
72.72%
ScriptCreator improved
91.78%
94.94%
TxBuilder improved
view more  
96.36%
 
InputClassifier removed
100%
 
Flags removed
100%
 
InputScriptFactory removed

CRAP Changes

 
30
Script::witnessSigOps() added
 
30
Script::countWitnessSigOps() added
 
30
Checker::verifyLockTime() added
 
20.432
InputSigner::sign() added
 
14.9202
Interpreter::verifyWitnessProgram() added
 
14.1683
InputSigner::extractFromValues() added
 
14.0301
InputSigner::doSignature() added
 
14
InputSigner::extractSignatures() added
 
12
WitnessPubKeyHashAddress::__construct() added
 
12
WitnessCollectionMutator::slice() added
view more  
2
2
Validator::checkSignature() improved
7.049
7.0368
OutputClassifier::isPayToPublicKey() improved
2
1
Transaction::validator() improved
2
1
Validator::__construct() improved
1
2
BloomFilter::checkFlag() got worse
9
10.0125
OutputClassifier::isPayToPublicKeyHash() got worse
10.0203
11.0908
OutputClassifier::isMultisig() got worse
7
8.6298
OutputClassifier::isPayToScriptHash() got worse
2
5.025
Interpreter::castToBool() got worse
2
6
Interpreter::isValidSignatureEncoding() got worse
view more  
30
 
Interpreter::verifyLockTime() removed
12
 
Interpreter::checkSequence() removed
10.0862
 
InputClassifier::isMultisig() removed
8
 
Interpreter::checkSignatureEncoding() removed
6
 
Interpreter::checkLockTime() removed
5
 
InputClassifier::isPayToPublicKeyHash() removed
5
 
InputClassifier::classify() removed
4
 
InputClassifier::isPayToScriptHash() removed
3
 
Interpreter::isDefinedHashtypeSignature() removed
3
 
Interpreter::checkPublicKeyEncoding() removed
view more