Completed
Pull Request — master (#286)
by thomas
23:49
created
src/Address/AddressFactory.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 use BitWasp\Bitcoin\Network\NetworkInterface;
9 9
 use BitWasp\Bitcoin\Script\Classifier\OutputClassifier;
10 10
 use BitWasp\Bitcoin\Script\ScriptInterface;
11
-
12 11
 use BitWasp\Bitcoin\Key\PublicKeyFactory;
13 12
 use BitWasp\Buffertools\Buffer;
14 13
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
     /**
84 84
      * @param string $address
85 85
      * @param NetworkInterface $network
86
-     * @return AddressInterface
86
+     * @return boolean
87 87
      * @throws \BitWasp\Bitcoin\Exceptions\Base58ChecksumFailure
88 88
      */
89 89
     public static function isValidAddress($address, NetworkInterface $network = null)
Please login to merge, or discard this patch.
src/Crypto/Hash.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
      * @param string $algo
116 116
      * @param BufferInterface $data
117 117
      * @param BufferInterface $salt
118
-     * @return BufferInterface
118
+     * @return EcAdapter\Adapter\EcAdapterInterface
119 119
      */
120 120
     public static function hmac($algo, BufferInterface $data, BufferInterface $salt)
121 121
     {
Please login to merge, or discard this patch.
src/Crypto/EcAdapter/Impl/PhpEcc/Adapter/EcAdapter.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -253,8 +253,8 @@  discard block
 block discarded – undo
253 253
     /**
254 254
      * Attempt to calculate the public key recovery param by trial and error
255 255
      *
256
-     * @param integer|string $r
257
-     * @param integer|string $s
256
+     * @param integer $r
257
+     * @param integer $s
258 258
      * @param BufferInterface $messageHash
259 259
      * @param PublicKey $publicKey
260 260
      * @return int
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
     }
324 324
 
325 325
     /**
326
-     * @param int|string $element
326
+     * @param string $element
327 327
      * @param bool $half
328 328
      * @return bool
329 329
      */
Please login to merge, or discard this patch.
src/Transaction/Factory/TxBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@
 block discarded – undo
111 111
     }
112 112
 
113 113
     /**
114
-     * @param BufferInterface|string $hashPrevOut - hex or BufferInterface
114
+     * @param BufferInterface $hashPrevOut - hex or BufferInterface
115 115
      * @param int $nPrevOut
116 116
      * @param Script|null $script
117 117
      * @param int $nSequence
Please login to merge, or discard this patch.
src/Script/Classifier/OutputClassifier.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 
46 46
     /**
47 47
      * @param ScriptInterface $script
48
-     * @param null $pubKeyHash
48
+     * @param BufferInterface|null $pubKeyHash
49 49
      * @return bool
50 50
      */
51 51
     public function isPayToPublicKeyHash(ScriptInterface $script, & $pubKeyHash = null)
Please login to merge, or discard this patch.