BigBad / golfleague

app/controllers/HolesController.php

Doc Comments -1 removed lines

@@ -41,7 +41,6 @@
 	/**
 	 * Display the specified resource.
 	 *
-	 * @param  int  $course_id
 	 * @return Response
 	 */
 	public function show()

Indentation +3 added lines, -3 removed lines

@@ -3,10 +3,10 @@ 
 class HolesController extends \BaseController {
 
 	public function __construct(Course $course, Hole $hole)
-    {
+	{
 		$this->course = $course;
 		$this->hole = $hole;
-    }
+	}
 	/**
 	 * Display a listing of the resource.
 	 *
@@ -15,7 +15,7 @@ 
 	public function index()
 	{
 		$data = $this->hole->all();
-        return $data;
+		return $data;
 	}
 
 	/**

Braces +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
 class LiveLeaderboardController extends \BaseController {
 
 	public function __construct(LeaderboardService $leaderboard)
-    {
+	{
         $this->leaderboard = $leaderboard;
     }
 

app/controllers/LiveLeaderboardController.php

Doc Comments +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     /**
 	 * Display a listing of the resource.
 	 *
-	 * @return Response
+	 * @return string
 	 */
 	public function index()
 	{

Indentation +8 added lines, -8 removed lines

@@ -6,11 +6,11 @@ 
 class LiveLeaderboardController extends \BaseController {
 
 	public function __construct(LeaderboardService $leaderboard)
-    {
-        $this->leaderboard = $leaderboard;
-    }
+	{
+		$this->leaderboard = $leaderboard;
+	}
 
-    /**
+	/**
 	 * Display a listing of the resource.
 	 *
 	 * @return Response
@@ -51,12 +51,12 @@ 
 	 */
 	public function show($id)
 	{
-        $match = Input::get('match');
-        $type = $id;
+		$match = Input::get('match');
+		$type = $id;
 
-        //return net or gross leaderboard for live scoring
+		//return net or gross leaderboard for live scoring
 		$data['data'] = $this->leaderboard->calculate($match,$type);
-        return $data;
+		return $data;
 
 	}
 

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
         $type = $id;
 
         //return net or gross leaderboard for live scoring
-		$data['data'] = $this->leaderboard->calculate($match,$type);
+		$data['data'] = $this->leaderboard->calculate($match, $type);
         return $data;
 
 	}

Braces +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
 class LiveLeaderboardController extends \BaseController {
 
 	public function __construct(LeaderboardService $leaderboard)
-    {
+	{
         $this->leaderboard = $leaderboard;
     }
 

app/controllers/PlayersController.php

Doc Comments -1 removed lines

@@ -43,7 +43,6 @@
     /**
      * Show the form for editing the specified resource.
      *
-     * @param  int  $id
      * @return Response
      */
     public function edit()

Indentation +51 added lines, -51 removed lines

@@ -4,10 +4,10 @@ 
 
 class PlayersController extends \BaseController {
 
-    public function __construct(PlayerRepo $player)
-    {
-        $this->player = $player;
-    }
+	public function __construct(PlayerRepo $player)
+	{
+		$this->player = $player;
+	}
 
 	/**
 	 * Get Data for all players
@@ -19,58 +19,58 @@ 
 		return $this->player->all();
 	}
 
-    /**
-     * Store a newly created resource in storage.
-     *
-     * @return Response
-     */
-    public function store()
-    {
+	/**
+	 * Store a newly created resource in storage.
+	 *
+	 * @return Response
+	 */
+	public function store()
+	{
 		$this->player->create(Input::get('name'), Input::get('handicap'));
-    }
+	}
 
-    /**
-     * Display the specified resource.
-     *
-     * @param  int  $id
-     * @return Response
-     */
-    public function show($id)
-    {
-        return $this->player->find($id);
-    }
+	/**
+	 * Display the specified resource.
+	 *
+	 * @param  int  $id
+	 * @return Response
+	 */
+	public function show($id)
+	{
+		return $this->player->find($id);
+	}
 
-    /**
-     * Show the form for editing the specified resource.
-     *
-     * @param  int  $id
-     * @return Response
-     */
-    public function edit()
-    {
+	/**
+	 * Show the form for editing the specified resource.
+	 *
+	 * @param  int  $id
+	 * @return Response
+	 */
+	public function edit()
+	{
 
-    }
+	}
 
-    /**
-     * Update the specified resource in storage.
-     *
-     * @param  int  $id
-     * @return Response
-     */
-    public function update($id)
-    {
-        //
-    }
+	/**
+	 * Update the specified resource in storage.
+	 *
+	 * @param  int  $id
+	 * @return Response
+	 */
+	public function update($id)
+	{
+		//
+	}
 
-    /**
-     * Remove the specified resource from storage.
-     *
-     * @param  int  $id
-     * @return Response
-     */
-    public function destroy($id)
-    {
-        //
-    }
+	/**
+	 * Remove the specified resource from storage.
+	 *
+	 * @param  int  $id
+	 * @return Response
+	 */
+	public function destroy($id)
+	{
+		//
+	}
 
 }
\ No newline at end of file

app/library/Handlers/MatchHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     /**
      * Create a new instance of the MatchHandler
      *
-     * @param  GolfLeague\Storage\Round\RoundRepository $roundRepo
+     * @param  RoundRepository $roundRepo
      * @return void
      */
     public function __construct(RoundRepository $roundRepo)

Indentation +42 added lines, -42 removed lines

@@ -14,51 +14,51 @@
  */
 class MatchHandler
 {
-    /**
-     * Create a new instance of the MatchHandler
-     *
-     * @param  GolfLeague\Storage\Round\RoundRepository $roundRepo
-     * @return void
-     */
-    public function __construct(RoundRepository $roundRepo)
-    {
-        $this->roundRepo= $roundRepo;
-    } // End of __construct
+	/**
+	 * Create a new instance of the MatchHandler
+	 *
+	 * @param  GolfLeague\Storage\Round\RoundRepository $roundRepo
+	 * @return void
+	 */
+	public function __construct(RoundRepository $roundRepo)
+	{
+		$this->roundRepo= $roundRepo;
+	} // End of __construct
 
-    /**
-     * Create an initial round for each player after a new match is created
-     *
-     * @param  Match $match
-     * @return void
-     */
-    public function handle($match)
-    {
-        //for each player create an initial round
-        //var_dump($holescore);
-        $input = array(
-        'date' => $match['date'],
-        // use holescore->round_id to get all holescores for that round
-         'course_id' => $match['course'],
+	/**
+	 * Create an initial round for each player after a new match is created
+	 *
+	 * @param  Match $match
+	 * @return void
+	 */
+	public function handle($match)
+	{
+		//for each player create an initial round
+		//var_dump($holescore);
+		$input = array(
+		'date' => $match['date'],
+		// use holescore->round_id to get all holescores for that round
+		 'course_id' => $match['course'],
 
-         'match_id' => $match['match_id'],
-         'score' => 0,
-         'esc' =>0
-         );
-         foreach($match['player'] as $player){
-         $input['player_id'] = $player['player_id'];
-         $this->roundRepo->create($input);
+		 'match_id' => $match['match_id'],
+		 'score' => 0,
+		 'esc' =>0
+		 );
+		 foreach($match['player'] as $player){
+		 $input['player_id'] = $player['player_id'];
+		 $this->roundRepo->create($input);
  }
 
-    }
+	}
 
-    /**
-     * Register the listeners for the subscriber.
-     *
-     * @param  Illuminate\Events\Dispatcher $events
-     * @return array
-     */
-    public function subscribe($events)
-    {
-        $events->listen('match.create', 'GolfLeague\Handlers\MatchHandler');
-    }
+	/**
+	 * Register the listeners for the subscriber.
+	 *
+	 * @param  Illuminate\Events\Dispatcher $events
+	 * @return array
+	 */
+	public function subscribe($events)
+	{
+		$events->listen('match.create', 'GolfLeague\Handlers\MatchHandler');
+	}
 }

Spacing +2 added lines, -2 removed lines

@@ -22,7 +22,7 @@ 
      */
     public function __construct(RoundRepository $roundRepo)
     {
-        $this->roundRepo= $roundRepo;
+        $this->roundRepo = $roundRepo;
     } // End of __construct
 
     /**
@@ -44,7 +44,7 @@ 
          'score' => 0,
          'esc' =>0
          );
-         foreach($match['player'] as $player){
+         foreach ($match['player'] as $player) {
          $input['player_id'] = $player['player_id'];
          $this->roundRepo->create($input);
  }

Braces +2 added lines, -3 removed lines

@@ -12,8 +12,7 @@ 
  *
  * @author          Michael Schmidt
  */
-class MatchHandler
-{
+class MatchHandler {
     /**
      * Create a new instance of the MatchHandler
      *
@@ -44,7 +43,7 @@ 
          'score' => 0,
          'esc' =>0
          );
-         foreach($match['player'] as $player){
+         foreach($match['player'] as $player) {
          $input['player_id'] = $player['player_id'];
          $this->roundRepo->create($input);
  }

app/library/Handlers/RoundHandler.php

Doc Comments -2 removed lines

@@ -17,7 +17,6 @@ 
     /**
      * Create a new instance of the MatchHandler
      *
-     * @param  GolfLeague\Storage\Round\RoundRepository $roundRepo
      * @return void
      */
     public function __construct(HoleScoreRepository $holescoreRepo)
@@ -28,7 +27,6 @@ 
     /**
      * Create an initial round for each player after a new match is created
      *
-     * @param  Match $match
      * @return void
      */
     public function handle($round)

Indentation +43 added lines, -43 removed lines

@@ -14,47 +14,47 @@
  */
 class RoundHandler
 {
-    /**
-     * Create a new instance of the MatchHandler
-     *
-     * @param  GolfLeague\Storage\Round\RoundRepository $roundRepo
-     * @return void
-     */
-    public function __construct(HoleScoreRepository $holescoreRepo)
-    {
-        $this->holescoreRepo= $holescoreRepo;
-    } // End of __construct
-
-    /**
-     * Create an initial round for each player after a new match is created
-     *
-     * @param  Match $match
-     * @return void
-     */
-    public function handle($round)
-    {
-        $holes = Hole::where('course_id', '=', $round['course_id'])->get();
-        foreach($holes as $hole){
-            $input = array(
-                'score' => null,
-                'hole_id' => $hole->id,
-                'round_id' => $round['id']
-            );
-            $this->holescoreRepo->create($input);
-        }
-
-
-
-    }
-
-    /**
-     * Register the listeners for the subscriber.
-     *
-     * @param  Illuminate\Events\Dispatcher $events
-     * @return array
-     */
-    public function subscribe($events)
-    {
-        $events->listen('eloquent.created: Round', 'GolfLeague\Handlers\RoundHandler');
-    }
+	/**
+	 * Create a new instance of the MatchHandler
+	 *
+	 * @param  GolfLeague\Storage\Round\RoundRepository $roundRepo
+	 * @return void
+	 */
+	public function __construct(HoleScoreRepository $holescoreRepo)
+	{
+		$this->holescoreRepo= $holescoreRepo;
+	} // End of __construct
+
+	/**
+	 * Create an initial round for each player after a new match is created
+	 *
+	 * @param  Match $match
+	 * @return void
+	 */
+	public function handle($round)
+	{
+		$holes = Hole::where('course_id', '=', $round['course_id'])->get();
+		foreach($holes as $hole){
+			$input = array(
+				'score' => null,
+				'hole_id' => $hole->id,
+				'round_id' => $round['id']
+			);
+			$this->holescoreRepo->create($input);
+		}
+
+
+
+	}
+
+	/**
+	 * Register the listeners for the subscriber.
+	 *
+	 * @param  Illuminate\Events\Dispatcher $events
+	 * @return array
+	 */
+	public function subscribe($events)
+	{
+		$events->listen('eloquent.created: Round', 'GolfLeague\Handlers\RoundHandler');
+	}
 }

Spacing +2 added lines, -2 removed lines

@@ -22,7 +22,7 @@ 
      */
     public function __construct(HoleScoreRepository $holescoreRepo)
     {
-        $this->holescoreRepo= $holescoreRepo;
+        $this->holescoreRepo = $holescoreRepo;
     } // End of __construct
 
     /**
@@ -34,7 +34,7 @@ 
     public function handle($round)
     {
         $holes = Hole::where('course_id', '=', $round['course_id'])->get();
-        foreach($holes as $hole){
+        foreach ($holes as $hole) {
             $input = array(
                 'score' => null,
                 'hole_id' => $hole->id,

Braces +2 added lines, -3 removed lines

@@ -12,8 +12,7 @@ 
  *
  * @author          Michael Schmidt
  */
-class RoundHandler
-{
+class RoundHandler {
     /**
      * Create a new instance of the MatchHandler
      *
@@ -34,7 +33,7 @@ 
     public function handle($round)
     {
         $holes = Hole::where('course_id', '=', $round['course_id'])->get();
-        foreach($holes as $hole){
+        foreach($holes as $hole) {
             $input = array(
                 'score' => null,
                 'hole_id' => $hole->id,

app/library/Services/MatchRoundService.php

Doc Comments +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
     /**
     * Loads our $matchRepo
     *
-    * @param MatchRepository $matchRepo
+    * @param MatchRepository $matchRoundRepo
     * @return MatchService
     */
     public function __construct(MatchRoundRepository $matchRoundRepo, RoundRepository $roundRepo, MatchRepository $match)
@@ -32,7 +32,7 @@ 
     /**
     * Method to get match data from input Match id
     *
-    * @param mixed $matchdata
+    * @param mixed $matchId
     * @return JSON object
     */
     public function getByMatch($matchId)

Indentation +34 added lines, -34 removed lines

@@ -9,41 +9,41 @@
 */
 class MatchRoundService
 {
-    // Containing our pokemonRepository to make all our database calls to
-    protected $matchRepo;
+	// Containing our pokemonRepository to make all our database calls to
+	protected $matchRepo;
 
-    /**
-    * Loads our $matchRepo
-    *
-    * @param MatchRepository $matchRepo
-    * @return MatchService
-    */
-    public function __construct(MatchRoundRepository $matchRoundRepo, RoundRepository $roundRepo, MatchRepository $match)
-    {
-        $this->matchRoundRepo = $matchRoundRepo;
-        $this->roundRepo = $roundRepo;
-        $this->match = $match;
-    }
+	/**
+	 * Loads our $matchRepo
+	 *
+	 * @param MatchRepository $matchRepo
+	 * @return MatchService
+	 */
+	public function __construct(MatchRoundRepository $matchRoundRepo, RoundRepository $roundRepo, MatchRepository $match)
+	{
+		$this->matchRoundRepo = $matchRoundRepo;
+		$this->roundRepo = $roundRepo;
+		$this->match = $match;
+	}
 
-    public function all()
-    {
-        return $this->matchRoundRepo->all();
-    }
-    /**
-    * Method to get match data from input Match id
-    *
-    * @param mixed $matchdata
-    * @return JSON object
-    */
-    public function getByMatch($matchId)
-    {
-        return $this->matchRoundRepo->getByMatch($matchId);
-    }
+	public function all()
+	{
+		return $this->matchRoundRepo->all();
+	}
+	/**
+	 * Method to get match data from input Match id
+	 *
+	 * @param mixed $matchdata
+	 * @return JSON object
+	 */
+	public function getByMatch($matchId)
+	{
+		return $this->matchRoundRepo->getByMatch($matchId);
+	}
 
-    public function getByMatchAndGroup($matchdata)
-    {
-        //Retrieve players in group
-        $players = $this->matchRoundRepo->matchGroup($matchdata['match_id'], $matchdata['group']);
-        return $players;
-    }
+	public function getByMatchAndGroup($matchdata)
+	{
+		//Retrieve players in group
+		$players = $this->matchRoundRepo->matchGroup($matchdata['match_id'], $matchdata['group']);
+		return $players;
+	}
 }

Braces +1 added lines, -2 removed lines

@@ -7,8 +7,7 @@
 /**
 * Our MatchService, containing all useful methods for business logic around Matches
 */
-class MatchRoundService
-{
+class MatchRoundService {
     // Containing our pokemonRepository to make all our database calls to
     protected $matchRepo;
 

app/library/Services/MoneyService.php

Doc Comments -1 removed lines

@@ -21,7 +21,6 @@
     /**
     * Loads our $matchRepo
     *
-    * @param MatchRepository $matchRepo
     * @return MatchService
     */
     public function __construct()

Unused Use Statements -2 removed lines

@@ -7,8 +7,6 @@
 use \Netwinner;
 use \Skin;
 
-use Illuminate\Events\Dispatcher;
-
 /**
 * MoneyService, containing all useful methods for business logic for money relating to a match
 */

Indentation +20 added lines, -20 removed lines

@@ -15,28 +15,28 @@
 class MoneyService
 {
 
-    // Containing our matchRepository to make all our database calls
-    protected $matchRepo;
+	// Containing our matchRepository to make all our database calls
+	protected $matchRepo;
 
-    /**
-    * Loads our $matchRepo
-    *
-    * @param MatchRepository $matchRepo
-    * @return MatchService
-    */
-    public function __construct()
-    {
+	/**
+	 * Loads our $matchRepo
+	 *
+	 * @param MatchRepository $matchRepo
+	 * @return MatchService
+	 */
+	public function __construct()
+	{
 
-    }
+	}
 
-    public function totalMatchMoney($matchId)
-    {
-        //get player id and money for ctp
-        $results['ctps'] =  Ctp::with('player')->where('match_id', '=', $matchId)->get();
-        $results['skins'] = Skin::with('player', 'hole')->where('match_id', '=', $matchId)->get();
-        $results['netwinner'] = Netwinner::with('player')->where('match_id', '=', $matchId)->get();
-        $results['grosswinner'] = Grosswinner::with('player')->where('match_id', '=', $matchId)->get();
-        $results['moneylist'] = Match::with('players')->where('id', '=', $matchId)->get();
+	public function totalMatchMoney($matchId)
+	{
+		//get player id and money for ctp
+		$results['ctps'] =  Ctp::with('player')->where('match_id', '=', $matchId)->get();
+		$results['skins'] = Skin::with('player', 'hole')->where('match_id', '=', $matchId)->get();
+		$results['netwinner'] = Netwinner::with('player')->where('match_id', '=', $matchId)->get();
+		$results['grosswinner'] = Grosswinner::with('player')->where('match_id', '=', $matchId)->get();
+		$results['moneylist'] = Match::with('players')->where('id', '=', $matchId)->get();
 		return $results;
-    }
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     public function totalMatchMoney($matchId)
     {
         //get player id and money for ctp
-        $results['ctps'] =  Ctp::with('player')->where('match_id', '=', $matchId)->get();
+        $results['ctps'] = Ctp::with('player')->where('match_id', '=', $matchId)->get();
         $results['skins'] = Skin::with('player', 'hole')->where('match_id', '=', $matchId)->get();
         $results['netwinner'] = Netwinner::with('player')->where('match_id', '=', $matchId)->get();
         $results['grosswinner'] = Grosswinner::with('player')->where('match_id', '=', $matchId)->get();

Braces +1 added lines, -2 removed lines

@@ -12,8 +12,7 @@
 /**
 * MoneyService, containing all useful methods for business logic for money relating to a match
 */
-class MoneyService
-{
+class MoneyService {
 
     // Containing our matchRepository to make all our database calls
     protected $matchRepo;

app/models/Hole.php

Indentation +9 added lines, -9 removed lines

@@ -3,17 +3,17 @@
 class Hole extends Eloquent 
 {
 	public function course()
-    {
-        return $this->belongsTo('Course');
-    }
+	{
+		return $this->belongsTo('Course');
+	}
 	
 	public function holescores()
-    {
-        return $this->hasMany('Holescore');
-    }
+	{
+		return $this->hasMany('Holescore');
+	}
 	
 	public function courses()
-    {
-        return $this->hasManyThrough('Course','Holescore');
-    }
+	{
+		return $this->hasManyThrough('Course','Holescore');
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -14,6 +14,6 @@
 	
 	public function courses()
     {
-        return $this->hasManyThrough('Course','Holescore');
+        return $this->hasManyThrough('Course', 'Holescore');
     }
 }

Braces +4 added lines, -5 removed lines

@@ -1,19 +1,18 @@
 <?php
 
-class Hole extends Eloquent 
-{
+class Hole extends Eloquent {
 	public function course()
-    {
+	{
         return $this->belongsTo('Course');
     }
 	
 	public function holescores()
-    {
+	{
         return $this->hasMany('Holescore');
     }
 	
 	public function courses()
-    {
+	{
         return $this->hasManyThrough('Course','Holescore');
     }
 }

app/models/Single.php

Indentation +7 added lines, -7 removed lines

@@ -2,13 +2,13 @@
 
 class Single extends Eloquent
 {
-    public function match()
-    {
-        return $this->belongsTo('Match');
-    }
+	public function match()
+	{
+		return $this->belongsTo('Match');
+	}
 
 	public function players()
-    {
-        return $this->hasMany('Player');
-    }
+	{
+		return $this->hasMany('Player');
+	}
 }
\ No newline at end of file

Braces +2 added lines, -3 removed lines

@@ -1,14 +1,13 @@
 <?php
 
-class Single extends Eloquent
-{
+class Single extends Eloquent {
     public function match()
     {
         return $this->belongsTo('Match');
     }
 
 	public function players()
-    {
+	{
         return $this->hasMany('Player');
     }
 }
\ No newline at end of file