MatchRoundService::all() - Code Metrics - BigBad/golfleague - Measure and Improve Code Quality continuously with Scrutinizer

MatchRoundService::all() A
last analyzed 2017-05-30 15:22 UTC

↳ Parent: MatchRoundService

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php namespace GolfLeague\Services;

use GolfLeague\Storage\Match\MatchRepository;
use GolfLeague\Storage\MatchRound\MatchRoundRepository;
use GolfLeague\Storage\Round\RoundRepository;

/**
* Our MatchService, containing all useful methods for business logic around Matches
*/
class MatchRoundService
{
    // Containing our pokemonRepository to make all our database calls to
    protected $matchRepo;

    /**
    * Loads our $matchRepo
    *
    * @param MatchRepository $matchRepo
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
    * @return MatchService

    */
    public function __construct(MatchRoundRepository $matchRoundRepo, RoundRepository $roundRepo, MatchRepository $match)
    {
        $this->matchRoundRepo = $matchRoundRepo;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->roundRepo = $roundRepo;

        $this->match = $match;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function all()
    {
        return $this->matchRoundRepo->all();
    }
    /**
    * Method to get match data from input Match id
    *
    * @param mixed $matchdata
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
    * @return JSON object
    */
    public function getByMatch($matchId)
    {
        return $this->matchRoundRepo->getByMatch($matchId);
    }

    public function getByMatchAndGroup($matchdata)
    {
        //Retrieve players in group
        $players = $this->matchRoundRepo->matchGroup($matchdata['match_id'], $matchdata['group']);
        return $players;
    }
}


1			<?php namespace GolfLeague\Services;
2
3			use GolfLeague\Storage\Match\MatchRepository;
4			use GolfLeague\Storage\MatchRound\MatchRoundRepository;
5			use GolfLeague\Storage\Round\RoundRepository;
6
7			/**
8			* Our MatchService, containing all useful methods for business logic around Matches
9			*/
10			class MatchRoundService
11			{
12			// Containing our pokemonRepository to make all our database calls to
13			protected $matchRepo;
14
15			/**
16			* Loads our $matchRepo
17			*
18			* @param MatchRepository $matchRepo
			0 ignored issues – show Bug introduced 2016-01-06 18:35 UTC by Report Bug Copy Issue Report There is no parameter named `$matchRepo`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
19			* @return MatchService
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-01-06 18:35 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
20			*/
21			public function __construct(MatchRoundRepository $matchRoundRepo, RoundRepository $roundRepo, MatchRepository $match)
22			{
23			$this->matchRoundRepo = $matchRoundRepo;
			0 ignored issues – show Bug introduced 2016-01-06 18:35 UTC by Report Bug Copy Issue Report The property `matchRoundRepo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			$this->roundRepo = $roundRepo;
			0 ignored issues – show Bug introduced 2016-01-06 18:35 UTC by Report Bug Copy Issue Report The property `roundRepo` does not seem to exist. Did you mean `matchRoundRepo`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
25			$this->match = $match;
			0 ignored issues – show Bug introduced 2016-01-06 18:35 UTC by Report Bug Copy Issue Report The property `match` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			}
27
28			public function all()
29			{
30			return $this->matchRoundRepo->all();
31			}
32			/**
33			* Method to get match data from input Match id
34			*
35			* @param mixed $matchdata
			0 ignored issues – show Bug introduced 2016-01-06 18:35 UTC by Report Bug Copy Issue Report There is no parameter named `$matchdata`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
36			* @return JSON object
37			*/
38			public function getByMatch($matchId)
39			{
40			return $this->matchRoundRepo->getByMatch($matchId);
41			}
42
43			public function getByMatchAndGroup($matchdata)
44			{
45			//Retrieve players in group
46			$players = $this->matchRoundRepo->matchGroup($matchdata['match_id'], $matchdata['group']);
47			return $players;
48			}
49			}
50

BigBad / golfleague

MatchRoundService::all() A last analyzed 2017-05-30 15:22 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MatchRoundService::all() A
last analyzed 2017-05-30 15:22 UTC